Hide Forgot
Spec URL: http://dev.laptop.org/~erikos/rpms/sugar-toolkit-gtk3.spec SRPM URL: http://dev.laptop.org/~erikos/rpms/sugar-toolkit-gtk3-0.95.1-1.fc16.src.rpm Description: Hi, we are close to have the first version of the sugar-toolkit for gtk3 in an official release. We are currently in the last rounds of review, the sources are a git snapshot with the current state. I would appreciate a review of the spec so I can get it in rawhide. Thanks, Simon
I'll review this.
There's a few bits in here that need to be cleaned up. - rpmlint output $ rpmlint SPECS/sugar-toolkit-gtk3.spec SRPMS/sugar-toolkit-gtk3-0.95.1-1.fc17.src.rpm RPMS/x86_64/sugar-toolkit-gtk3-* sugar-toolkit-gtk3.src: W: spelling-error %description -l en_US datastore -> data store, data-store, devastator sugar-toolkit-gtk3.x86_64: W: private-shared-object-provides /usr/lib/python2.7/site-packages/sugar3/_sugarbaseext.so _sugarbaseext.so()(64bit) sugar-toolkit-gtk3.x86_64: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/sugar3/presence/tubeconn.py sugar-toolkit-gtk3.x86_64: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/sugar3/presence/sugartubeconn.py sugar-toolkit-gtk3.x86_64: E: script-without-shebang /etc/rpm/macros.sugar sugar-toolkit-gtk3.x86_64: E: library-without-ldconfig-postin /usr/lib64/libsugarext.so.0.0.0 sugar-toolkit-gtk3.x86_64: E: library-without-ldconfig-postun /usr/lib64/libsugarext.so.0.0.0 sugar-toolkit-gtk3.x86_64: W: no-manual-page-for-binary sugar-activity sugar-toolkit-gtk3.x86_64: E: invalid-lc-messages-dir /usr/share/locale/cpp/LC_MESSAGES/sugar-toolkit-gtk3.mo sugar-toolkit-gtk3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sugar-toolkit-gtk3-0.95.1/src/sugar3/rsvg-wrapper.c sugar-toolkit-gtk3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sugar-toolkit-gtk3-0.95.1/src/sugar3/gsm-session.h sugar-toolkit-gtk3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sugar-toolkit-gtk3-0.95.1/src/sugar3/rsvg-wrapper.h sugar-toolkit-gtk3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sugar-toolkit-gtk3-0.95.1/src/sugar3/eggdesktopfile.c sugar-toolkit-gtk3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sugar-toolkit-gtk3-0.95.1/src/sugar3/acme-volume.c sugar-toolkit-gtk3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sugar-toolkit-gtk3-0.95.1/src/sugar3/acme-volume.h sugar-toolkit-gtk3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sugar-toolkit-gtk3-0.95.1/src/sugar3/gdk-wrapper.c sugar-toolkit-gtk3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sugar-toolkit-gtk3-0.95.1/src/sugar3/gsm-client.h sugar-toolkit-gtk3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sugar-toolkit-gtk3-0.95.1/src/sugar3/gsm-client.c sugar-toolkit-gtk3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sugar-toolkit-gtk3-0.95.1/src/sugar3/acme-volume-alsa.h sugar-toolkit-gtk3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sugar-toolkit-gtk3-0.95.1/src/sugar3/gsm-session.c sugar-toolkit-gtk3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sugar-toolkit-gtk3-0.95.1/src/sugar3/acme-volume-alsa.c sugar-toolkit-gtk3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sugar-toolkit-gtk3-0.95.1/src/sugar3/gsm-app.c sugar-toolkit-gtk3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sugar-toolkit-gtk3-0.95.1/src/sugar3/gsm-xsmp.c sugar-toolkit-gtk3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sugar-toolkit-gtk3-0.95.1/src/sugar3/gsm-client-xsmp.c sugar-toolkit-gtk3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sugar-toolkit-gtk3-0.95.1/src/sugar3/gsm-xsmp.h sugar-toolkit-gtk3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sugar-toolkit-gtk3-0.95.1/src/sugar3/gsm-client-xsmp.h sugar-toolkit-gtk3-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sugar-toolkit-gtk3-0.95.1/src/sugar3/eggdesktopfile.h sugar-toolkit-gtk3-devel.x86_64: W: spelling-error Summary(en_US) Invokation -> Invocation, Invitation, Innovation sugar-toolkit-gtk3-devel.x86_64: W: spelling-error %description -l en_US gobject -> object, g object sugar-toolkit-gtk3-devel.x86_64: W: no-documentation 4 packages and 1 specfiles checked; 24 errors, 6 warnings. + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + latest version packaged + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm 354540e82bfb17699b5df4d37dc25faf sugar-toolkit-gtk3-0.95.1.tar.bz2 + package successfully builds on at least one architecture tested using koji scratch build + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* - binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr + package owns all directories it creates + no duplicate files in %files + Package perserves timestamps on install + Permissions on files must be set properly + %defattr line + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package runtime n/a header files should be in -devel n/a static libraries should be in -static n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' + libfoo.so must go in -devel n/a devel must require the fully versioned base + packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + filenames must be valid UTF-8 Optional: n/a if there is no license file, packager should query upstream to include it n/a translations of description and summary for non-English languages, if available - reviewer should build the package in mock/koji needs BuildRequires: python-devel - the package should build into binary RPMs on all supported architectures n/a review should test the package functions as described - scriptlets should be sane needs pre/post ldconfig n/a non -devel packages should require fully versioned base n/a pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin n/a Package should have man files
Ok, the 'incorrect-fsf-address' was new to me. The address seem to be wrong in all of the files of the sugar-toolkit, not just the ones that rpmlint reports. Looking at FilesCheck.py in rpmlint the detecting of this error is not as robust. The reg expression "fsf_license_regex = re.compile('(GNU((\s+(Library|Lesser|Affero))?(\s+General)?\s+Public|\s+Free\s+Documentation)\s+Licen[cs]e|(GP|FD)L)', re.IGNORECASE)" does not handle newlines and it seems to be very common that "GNU Lesser General Public License" is not written on one line (maybe that is one of the reasons why many sources still have the old address?). Besides that: so the policy is to update all of the sources to the new address "51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA."?
Thanks Peter for the review, I updated the spec file to follow your suggestions. The sfs-address-errors I did not fix yet, as I first would like to hear clarification on https://bugzilla.redhat.com/show_bug.cgi?id=769002#c3, happy to do it then. The 'invalid-lc-messages-dir' can not be fixed as we support languages that are not as popular. SPEC: http://dev.laptop.org/~erikos/rpms/sugar-toolkit-gtk3.spec SOURCES: http://download.sugarlabs.org/sources/sucrose/glucose/sugar-toolkit-gtk3/sugar-toolkit-gtk3-0.95.2.tar.bz2 SRPM: http://dev.laptop.org/~erikos/rpms/sugar-toolkit-gtk3-0.95.2-1.fc16.src.rpm I did as well a scratch build in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3601450
Looks fine to me, core issues addressed. APPROVED!
New Package GIT Request ======================= Package Name: sugar-toolkit-gtk3 Short Description: Sugar toolkit Owners: erikos dsd pbrobinson Branches: InitialCC:
Git done (by process-git-requests).