Hide Forgot
+++ This bug was initially created as a clone of Bug #733717 +++ Created attachment 520108 [details] diffs for code review plus supporting information Description of problem: mod snmp under apache leaks lots of memory How reproducible: 100% Steps to Reproduce: 1. Set up apache + valgrind 2. Set up node.js + nodeload 3. Set up nodeload test script to create 10 mins / 10 million request load. 4. Run apache + valgrind 5. Run nodeload 6. Stop apache after nodeload stops 7. Analyse valgrind output Actual results: 65 MiB leak over 10 mins; 850k requests, approx 850k leaked blocks Expected results: No leaked blocks per request. Additional info: See attached for leak reports, diffs, test scripts, etc. --- Additional comment from rbuck on 2011-08-26 11:24:17 EDT --- Created attachment 520109 [details] valgrind log showing top leaks last (look for 65 MiB leak, 852k leaked blocks) --- Additional comment from rbuck on 2011-08-26 11:25:02 EDT --- Created attachment 520110 [details] nodeload test script used to reproduce --- Additional comment from rbuck on 2011-09-02 09:16:36 EDT --- The final results using the patched libraries show no leaks after 10M requests: ==31157== LEAK SUMMARY: ==31157== definitely lost: 226 bytes in 4 blocks ==31157== indirectly lost: 0 bytes in 0 blocks ==31157== possibly lost: 0 bytes in 0 blocks ==31157== still reachable: 216 bytes in 2 blocks ==31157== suppressed: 0 bytes in 0 blocks --- Additional comment from rbuck on 2011-09-29 08:13:06 EDT --- This has been fixed already; unsure why it's still open. The patch has been applied to SVN. --- Additional comment from loleary on 2011-09-29 11:09:09 EDT --- Looks like the fix was committed to trunk as rev 11204 --- Additional comment from mfoley on 2011-10-03 13:07:55 EDT --- verified 10/3/2011 daily build. functional test.
this BZ was opened as a clone. i am marking it verified and closing it for the following reasons: it is not in JON 2.4.2 branch, the fix is not even in git ... it is in SVN, that fix ... still there ... has already been verified.
Simeon .. can you verify that the git commits listed in Comment #2 are contained in JON 2.4.2? From the git commits I see that they are in this branch: JBossON_2_4_1_GA_CP I am not clear based on the branching strategy if these commits are in the JON 2.4.2 branch. I would like to confirm this. Can you help?
Confirmed. These commits are all on the JBossON_2.4.2.GA branch and are in the latest RC build. If you have that branch checked out a call to 'gitk (git hash)' will show the branches that the commit lives on. Additionally 'git branch --contains (hash)' does the same without UI.
Pushing this to ON-QA based on comments from Larry and Simeon
discussed with larry. he is going to help with verification of this.
Done some functional testing by configuring snmp module in apache on JON 2.4.2 Release Candidate #4 build. Included virtual hosts in config file and discovered them. Verified that monitoring is working on virtual hosts. Also verified that config update and operation execution is working.
Verified using 2.4.2 CR #4: SNMP module from JON 2.4.1.GA: ==16444== definitely lost: 43,783,020 bytes in 694,971 blocks SNMP module from JON 2.4.2 CR #4: ==16856== definitely lost: 62 bytes in 4 blocks Test confirms that memory leak no longer exists. I will let QE push this BZ to VERIFIED just in case there is something more they need.
changing status of VERIFIED BZs for JON 2.4.2 and JON 3.0 to CLOSED/CURRENTRELEASE
marking VERIFIED BZs to CLOSED/CURRENTRELEASE