Hide Forgot
LV2 is an audio plugin framework for Linux. lv2-mdaEPiano - is an LV2 port of the popular MDA VST piano plugin. fedora16:~/rpmbuild/SOURCES $ rpmlint /home/bsjones/rpmbuild/RPMS/x86_64/lv2-mdaEPiano* /home/bsjones/rpmbuild/SRPMS/lv2-mdaEPiano-0.0.0-0.1.git5a4ab089.fc16.src.rpm lv2-mdaEPiano.src: W: invalid-url Source0: lv2-mdaEPiano-0.0.0-git5a4ab089.tar.bz2 3 packages and 0 specfiles checked; 0 errors, 1 warnings.
Hi Brendan, could you post the links to the SRPM and SPEC files when you get a chance?
Of course! SRPM: http://bsjones.fedorapeople.org/lv2-mdaEPiano-0.0.0-0.1.git5a4ab089.fc16.src.rpm SPEC: http://bsjones.fedorapeople.org/lv2-mdaEPiano.spec
Thanks, here is the full review. There are a few issues we need to go over.: * I could not match the sources with the tarball you provided. Also your comments checking out instructions have a different git hash. $ sha1sum ~/rpmbuild/SOURCES/lv2-mdaEPiano-0.0.0-git5a4ab089.tar.bz2 51c92dcfaa0b2342bd7281e430aa05d7187a0c29 /home/orcan/rpmbuild/SOURCES/lv2-mdaEPiano-0.0.0-git5a4ab089.tar.bz2 $ sh ~/rpmbuild/SOURCES/lv2-mdaEPiano-snapshot.sh 5a4ab089 ... Fetched git revision: 5a4ab089 Written: lv2-mdaEPiano-0.0.0-git5a4ab089.tar.bz2 $ sha1sum lv2-mdaEPiano-0.0.0-git5a4ab089.tar.bz2 dff89657f88ce8d514a1e38433aaada71f51fa2a lv2-mdaEPiano-0.0.0-git5a4ab089.tar.bz2 ! You can probably remove the .git stuff from the source tree in your snapshot script. - rpmlint says: lv2-mdaEPiano.src: W: invalid-url Source0: lv2-mdaEPiano-0.0.0-git5a4ab089.tar.bz2 This can be ignored. * The following are redundant %post -p /usr/bin/ldconfig %postun -p /usr/bin/ldconfig since we are not insntalling anything in the ld search path. ? I found binary file ./src/data/samples.raw in the tarball. Do you know what this is? ? Is there a justification for the version 0.0.0? If not, we shoud probably use plain 0. See the kismet example a http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages * The README.md file says the license is GPLv3+. Please fix this. * Fedora specific build flags are not honored. In particular, there is a -O that overrides our -O2. * The package should BR lv2-c++-tools-static instead of lv2-c++-tools-devel since it uses the static library.
Thanks Orcan, made all changes as requested. The samples.raw is included in the plugin bundle directory and is a runtime requirement SRPM: http://bsjones.fedorapeople.org/lv2-mdaEPiano-0-0.2.git9db45842.fc16.src.rpm SPEC: http://bsjones.fedorapeople.org/lv2-mdaEPiano.spec rpmlint /home/bsjones/rpmbuild/SRPMS/lv2-mdaEPiano-0-0.2.git9db45842.fc16.src.rpm /home/bsjones/rpmbuild/RPMS/x86_64/lv2-mdaEPiano-0-0.2.git9db45842.fc16.x86_64.rpm /home/bsjones/rpmbuild/RPMS/x86_64/lv2-mdaEPiano-debuginfo-0-0.2.git9db45842.fc16.x86_64.rpm lv2-mdaEPiano.src: W: invalid-url Source0: lv2-mdaEPiano-0-git9db45842.tar.bz2 3 packages and 0 specfiles checked; 0 errors, 1 warnings. I can't get the git clone to match sha1sum. I can only assume it is because of the timestamps being different every time git clone is issued. thanks for the review Brendan
Yeah, I verify that the source tree is genuine, which, I think, is enough. The package is good to go now. ------------------------------------------------ This package (lv2-mdaEPiano) is APPROVED by oget ------------------------------------------------
Thanks Orcan! New Package SCM Request ======================= Package Name: lv2-mdaEPiano Short Description: LV2 port of the MDA VST piano plugin Owners: bsjones Branches: f15 f16 InitialCC:
Git done (by process-git-requests).
lv2-mdaEPiano-0-0.2.git9db45842.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/lv2-mdaEPiano-0-0.2.git9db45842.fc15
lv2-mdaEPiano-0-0.2.git9db45842.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/lv2-mdaEPiano-0-0.2.git9db45842.fc16
Package lv2-mdaEPiano-0-0.2.git9db45842.fc15: * should fix your issue, * was pushed to the Fedora 15 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing lv2-mdaEPiano-0-0.2.git9db45842.fc15' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-1156/lv2-mdaEPiano-0-0.2.git9db45842.fc15 then log in and leave karma (feedback).
lv2-mdaEPiano-0-0.2.git9db45842.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.
lv2-mdaEPiano-0-0.2.git9db45842.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.