Bug 784923 - netdump-server should use ip instead of ifconfig
Summary: netdump-server should use ip instead of ifconfig
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: netdump-server
Version: 19
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Neil Horman
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 687920
TreeView+ depends on / blocked
 
Reported: 2012-01-26 16:38 UTC by Jiri Popelka
Modified: 2015-01-12 10:51 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-01-12 10:51:19 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
suggested patch (1.59 KB, patch)
2012-01-26 16:38 UTC, Jiri Popelka
no flags Details | Diff

Description Jiri Popelka 2012-01-26 16:38:37 UTC
Created attachment 557704 [details]
suggested patch

Hi,

I've updated net-tools in rawhide to upstream git snapshot and the ifconfig output is a little different now (bug #784314).

The netdump server parses ifconfig output in its init script.
The fix is easy (what about using 'ip' when we are in it ?):
diff -up netdump-0.7.16/netdump.init
@@ -163,7 +157,7 @@ random_hex_int ()
 ip_of_device ()
 {
-    LC_ALL=C /sbin/ifconfig $1 | sed 's/:/ /' | awk '/inet addr/ {print $3}'
+    LC_ALL=C ip -4 -o addr show dev $1 | awk '{ print $4}' | cut -d '/' -f 1
 }

The init script also uses 'arp -a'.
It would be good to replace it with its equivalent 'ip neigh' so we'll eviscerate net-tools' use from one more package. The attached patch is just a suggestion.

Thanks.

Comment 1 Neil Horman 2012-01-27 13:45:32 UTC
applied, thanks!

Comment 2 Jiri Popelka 2012-01-27 14:16:06 UTC
Great. Could you also remove the 'Requires: /sbin/ifconfig' ?

Comment 3 Neil Horman 2012-01-27 16:27:52 UTC
done

Comment 4 Fedora End Of Life 2013-04-03 20:28:51 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 5 Fedora End Of Life 2015-01-09 22:30:17 UTC
This message is a notice that Fedora 19 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 19. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 19 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.


Note You need to log in before you can comment on or make changes to this bug.