Bug 785471 (horde-stream-wrapper) - Review Request: php-horde-Horde-Stream-Wrapper - Horde Stream wrappers
Summary: Review Request: php-horde-Horde-Stream-Wrapper - Horde Stream wrappers
Keywords:
Status: CLOSED NEXTRELEASE
Alias: horde-stream-wrapper
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: horde-channel
Blocks: Horde_Support
TreeView+ depends on / blocked
 
Reported: 2012-01-29 02:53 UTC by Nick Bebout
Modified: 2012-07-18 22:05 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-07-18 22:05:22 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
php-horde-Horde-Stream-Wrapper-review.txt (6.76 KB, text/plain)
2012-06-30 07:34 UTC, Remi Collet
no flags Details

Description Nick Bebout 2012-01-29 02:53:16 UTC
Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Wrapper-1.0.0-1.fc16.src.rpm
Description: This package provides various stream wrappers.

Comment 2 Remi Collet 2012-06-30 07:34:13 UTC
Created attachment 595422 [details]
php-horde-Horde-Stream-Wrapper-review.txt

Generated by fedora-review 0.1.3

Comment 3 Remi Collet 2012-06-30 07:37:50 UTC
SHOULD:
Use %{pear_name} where possible
Consider adding %{pear_channel}

MUST:
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.

[!]: MUST Requires correct, justified where necessary.
BuildRequires and Requires same version of pear, according to package.xml
BuildRequires:  php-pear >= 1:1.7.0
Requires:  php-pear >= 1:1.7.0

Also add php-common >= 5.2.0 (waiting for a better provides in php)

[!]: MUST Package must own all directories that it creates.
Missing
%{pear_phpdir}/Horde
%{pear_phpdir}/Horde/Stream
%{pear_docdir}/Horde_Stream_Wrapper

Comment 5 Remi Collet 2012-07-11 05:08:23 UTC
[!]: MUST Package must own all directories that it creates.
Missing
%{pear_phpdir}/Horde

And you should, of course remove (included in previous)
%{pear_phpdir}/Horde/Stream
%{pear_phpdir}/Horde/Stream/Wrapper

Please use macro everywhere, see %postun and %files

It's probably enough to only 
%doc %{pear_docdir}/%{pear_name}

Note : "localized" php.ini is use less in fedora (date.timezone defined in pear wrapper), I haven't check in EL.

Comment 7 Remi Collet 2012-07-17 14:03:02 UTC
Blockers fixed.

== APPROVED ==

Comment 8 Nick Bebout 2012-07-17 22:42:09 UTC
New Package SCM Request
=======================
Package Name: php-horde-Horde-Stream-Wrapper
Short Description: This package provides various stream wrappers for Horde
Owners: nb
Branches: el6 f16 f17
InitialCC:

Comment 9 Gwyn Ciesla 2012-07-18 03:16:31 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.