Oh shoot, I thought I uploaded the fix for this in

https://bugzilla.redhat.com/show_bug.cgi?id=749987

but the patch did not merged correctly. Will fix this up and repush.

Note that the service exists with code 0 although it fails to start.

Let me know when there's a package in updates testing and I'll try it out & give karma.

*** Bug 785037 has been marked as a duplicate of this bug. ***

Created attachment 558965 [details]
fix return value when iscsid is not started

Hey,

Does this patch to /etc/init.d/iscsid fix the problem for you?

After you apply the patch I think you have to do "systemctl --system daemon-reload"?

It fixes the return value in the failure case.

This patch will not:

1. Fix the PID error messages. For some reason even if we return failed, systemd still complains about there not being a PID file.

This might be a systemd bug.

2. Will not fix the problem of iscsi/iscsid trying to get startup and failing even though you are not using iscsi.

I am working on this, but it is going to be a bigger fix that might require some changes to other packages, so the patch in this bz is just a workaround to get us working.

Also what packages do I need to install to get the vdsm service like in this bz?

Rami, could you describe how to reproduce the issue, or provide a machine for Mike's disposal?

Please note that this bug is a proud member of http://www.ovirt.org/wiki/Releases/First_Release_Blockers

The patch doesn't fix it on my machine.  I get:

[root@node0 ~]# service vdsmd status
Redirecting to /bin/systemctl  status vdsmd.service
vdsmd.service - Virtual Desktop Server Manager
	  Loaded: loaded (/lib/systemd/system/vdsmd.service; enabled)
	  Active: failed since Thu, 02 Feb 2012 20:39:58 -0500; 51s ago
	 Process: 641 ExecStart=/lib/systemd/systemd-vdsmd start (code=exited, status=1/FAILURE)
	  CGroup: name=systemd:/system/vdsmd.service
[root@node0 ~]# service iscsid status
iscsid.service - LSB: Starts and stops login iSCSI daemon.
	  Loaded: loaded (/etc/rc.d/init.d/iscsid)
	  Active: failed since Thu, 02 Feb 2012 20:39:58 -0500; 58s ago
	 Process: 904 ExecStart=/etc/rc.d/init.d/iscsid start (code=exited, status=6/NOTCONFIGURED)
	  CGroup: name=systemd:/system/iscsid.service
[root@node0 ~]#

Hey,

The system you loaned me does not have the vdsm stuff installed.

But here is the issue.

At some point someone made iscsi/iscsid do a delayed start. It only starts when there are targets setup. So if iscsid/iscsi do not see targets setup they do not start. When someone runs iscsiadm to find targets it will start iscsid for you. Then next time you start the service it runs as expected (starts and logs into targets).

So if no targets are found the iscsi/iscsid scripts return a failure.

So my questions are:

1. I did not implement that behavior. It was done to improve boot up times and fix the issue where iscsi got installed by default but users did not need iscsi.

If we are saying that behavior is not ok now then I can easily just remove the checks. iscsid will start when the service is started and we will always return success.

2. Does vdsm need iscsi started when it starts? If "service iscsi/iscsid start" was only run when users used iscsi would that work?

See #3.

3. Is the problem that the iscsi rpm sets things so that it starts by default (it does chkconfig --add iscsi/iscsid when you install the rpm)? Should we be having the user do this if they actually use iscsi?

(In reply to comment #10)
> 
> 1. I did not implement that behavior. It was done to improve boot up times and
> fix the issue where iscsi got installed by default but users did not need
> iscsi.
> 
> If we are saying that behavior is not ok now then I can easily just remove the
> checks. iscsid will start when the service is started and we will always return
> success.

I find this behavior awkward and unlike other services:

# systemctl start iscsid.service
Job failed. See system logs and 'systemctl status' for details.
# systemctl status  iscsid.service
iscsid.service - LSB: Starts and stops login iSCSI daemon.
	  Loaded: loaded (/etc/rc.d/init.d/iscsid)
	  Active: failed since Sun, 05 Feb 2012 11:42:47 +0200; 12s ago
	 Process: 24960 ExecStart=/etc/rc.d/init.d/iscsid start (code=exited, status=0/SUCCESS)
	  CGroup: name=systemd:/system/iscsid.service

I'd appreciate if iscsid is fixed to start when asked to.

 
> 2. Does vdsm need iscsi started when it starts? If "service iscsi/iscsid start"
> was only run when users used iscsi would that work?

Vdsm expects iscsid running when it starts.

(In reply to comment #10)
> 1. I did not implement that behavior. It was done to improve boot up times and
> fix the issue where iscsi got installed by default but users did not need
> iscsi.
> 
> If we are saying that behavior is not ok now then I can easily just remove the
> checks. iscsid will start when the service is started and we will always return
> success.

That sounds good to me.  I've patched the iscsid startup script to do that and it appears to allow vdsm to start properly.

I have made the requested change in:
iscsi-initiator-utils-6.2.0.872-17.fc17/iscsi-initiator-utils-6.2.0.872-17.fc16.

iscsi-initiator-utils-6.2.0.872-16.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/FEDORA-2012-1333/iscsi-initiator-utils-6.2.0.872-16.fc16

(In reply to comment #14)
> iscsi-initiator-utils-6.2.0.872-16.fc16 has been submitted as an update for
> Fedora 16.
> https://admin.fedoraproject.org/updates/FEDORA-2012-1333/iscsi-initiator-utils-6.2.0.872-16.fc16

iscsid and vdsmd start well with this rpm (reboot was needed in my machine - restart of iscsid.service after package update didn't do the job).

iscsi-initiator-utils-6.2.0.872-16.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

Update iscsi-initiator-utils-6.2.0.872-16.fc16 cause boot delay on my F16. Boot resumes after 60s timeout.
`systemctl disable iscsi.service` fixed problem for me, but until iscsi.service is enabled by default on F16 installation this bug could hit many users after this update.

/var/spool/plymouth/boot.log:
Starting LSB: Starts and stops login and scanning of iSCSI devices. ^[[1;31mfailed^[[0m, see 'systemctl status iscsi.service' for details.

systemctl status iscsi.service:
iscsi.service - LSB: Starts and stops login and scanning of iSCSI devices.
          Loaded: loaded (/etc/rc.d/init.d/iscsi)
          Active: active (exited) since Fri, 10 Feb 2012 12:17:00 +0100; 8min ago
         Process: 1570 ExecStart=/etc/rc.d/init.d/iscsi start (code=exited, status=0/SUCCESS)
          CGroup: name=systemd:/system/iscsi.service

Could you attach your /var/log/messages when you hit the boot delays?

And you are not using any iscsi devices right?

I don't use any iscsi device.

grep iscsi /var/log/messages

Feb 11 11:21:04 Martix-NB kernel: [   17.350280] iscsi: registered transport (tcp)
Feb 11 11:21:04 Martix-NB kernel: [   17.404566] iscsi: registered transport (iser)
Feb 11 11:21:04 Martix-NB kernel: [   17.410848] iscsi: registered transport (cxgb3i)
Feb 11 11:21:04 Martix-NB kernel: [   17.414369] iscsi: registered transport (cxgb4i)
Feb 11 11:21:04 Martix-NB kernel: [   17.417639] iscsi: registered transport (bnx2i)
Feb 11 11:21:04 Martix-NB kernel: [   17.424054] iscsi: registered transport (be2iscsi)
Feb 11 11:21:04 Martix-NB iscsid: iSCSI logger with pid=1163 started!
Feb 11 11:21:04 Martix-NB iscsid[1043]: Spouštění iscsid: [  OK  ]#015[  OK  ]
Feb 11 11:21:05 Martix-NB iscsid: transport class version 2.0-870. iscsid version 2.0-872.15.f16
Feb 11 11:21:05 Martix-NB iscsid: iSCSI daemon with pid=1164 started!
Feb 11 11:22:05 Martix-NB systemd[1]: iscsi.service: control process exited, code=exited status=3
Feb 11 11:22:05 Martix-NB systemd[1]: Unit iscsi.service entered failed state.
Feb 11 11:22:14 Martix-NB iscsi[1648]: Spouštění iscsi: iscsiadm: No records found
Feb 11 11:22:14 Martix-NB iscsi[1648]: [  OK  ]
Feb 11 11:22:14 Martix-NB dbus-daemon[1024]: Starting iscsi (via systemctl):  [  OK  ]

Ah shoot. I know what it is. It is waiting on the NetworkManager to get the network up.

Let's discuss this here

https://bugzilla.redhat.com/show_bug.cgi?id=789683