Spec URL: http://people.redhat.com/dcbw/network-manager-applet.spec SRPM URL: http://people.redhat.com/dcbw/network-manager-applet-0.9.2-2.fc17.src.rpm Description: This package is the result of splitting the network-manager-applet tarball out of the main NetworkManager RPM where it's lived for about 5 years. The goal is to be able to *not* install nm-applet at all, but still have nm-connection-editor installed. This way we support other DEs that do want nm-applet (xfce, lxde, etc) but also support GNOME Shell which uses nm-connection-editor, but not nm-applet. We'd always meant to split out the GUI bits from the NM RPM, but now we finally have the kick in the pants to do it.
Hello, some comments: 1) /usr/bin/gtk-update-icon-cache shouldn't be a dependency: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache 2) BuildRequires are missing, which I eventually realized was because the listed BuildRequires are part of the %description and so not processed. 3) rm is preferred over %{__rm} (and same with mkdir). http://fedoraproject.org/wiki/Packaging:Guidelines#Macros 4) If not building for EPEL, you can remove BuildRoot tag, remove "rm -rf $RPM_BUILD_ROOT" from %install section, and remove %clean section.
Oh and maybe things changed since a week ago: (fedora-rawhide-x86_64 build.log) No package 'NetworkManager' found No package 'libnm-glib' found No package 'libnm-util' found No package 'libnm-glib-vpn' found
Updated, thanks for the review! I've uploaded the new copies to the same URL.
Hmm I couldn't build: $ mock --rebuild -r fedora-17-x86_64 network-manager-applet-0.9.2-2.fc17.src.rpm Config(fedora-17-x86_64) 0 minutes 17 seconds INFO: Results and/or logs in: /var/lib/mock/fedora-17-x86_64/result ERROR: Command failed: # ['/usr/bin/yum-builddep', '--installroot', '/var/lib/mock/fedora-17-x86_64/root/', '/var/lib/mock/fedora-17-x86_64/root///builddir/build/SRPMS/network-manager-applet-0.9.2-2.fc17.src.rpm'] Getting requirements for network-manager-applet-0.9.2-2.fc17.src Error: No Package found for NetworkManager-devel = 1:0.9.2-2 Strangely, bumping nm_version to "1:0.9.3-0.2.git20120215" still causes the same No Package error and I'm not sure why.
To get the package to build in mock, I had to change the gnome-keyring-devel BR to libgnome-keyring-devel, and add a BR for polkit-devel. I also had to add a patch for missing libraries in the gconf test utilities. $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm libnm-gtk.x86_64: W: spelling-error %description -l en_US nm -> NM, mm, n libnm-gtk.x86_64: W: obsolete-not-provided NetworkManager-gtk libnm-gtk.x86_64: W: no-documentation libnm-gtk-devel.x86_64: W: no-dependency-on libnm-gtk/libnm-gtk-libs/liblibnm-gtk libnm-gtk-devel.x86_64: W: spelling-error %description -l en_US config -> con fig, con-fig, configure libnm-gtk-devel.x86_64: W: spelling-error %description -l en_US nm -> NM, mm, n libnm-gtk-devel.x86_64: W: no-documentation network-manager-applet.src: W: strange-permission network-manager-applet-0.9.2.0.tar.bz2 0444L network-manager-applet.x86_64: W: obsolete-not-provided NetworkManager-gnome network-manager-applet.x86_64: E: zero-length /usr/share/doc/network-manager-applet-0.9.2/AUTHORS network-manager-applet.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/nm-applet.schemas network-manager-applet.x86_64: E: zero-length /usr/share/doc/network-manager-applet-0.9.2/README network-manager-applet.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/nm-applet.desktop network-manager-applet.x86_64: W: no-manual-page-for-binary nm-applet nm-connection-editor.x86_64: W: no-documentation nm-connection-editor.x86_64: W: no-manual-page-for-binary nm-connection-editor 6 packages and 0 specfiles checked; 2 errors, 14 warnings. Looks all ignorable, except for the 0length files, which you should just drop from the file list.
Created attachment 567150 [details] lib patch
Updated specs and RPMs here, using latest upstream nm-applet: Spec URL: http://people.redhat.com/dcbw/network-manager-applet.spec SRPM URL: http://people.redhat.com/dcbw/network-manager-applet-0.9.3.995-1.git20120302.fc17.src.rpm
(In reply to comment #7) > Updated specs and RPMs here, using latest upstream nm-applet: > > Spec URL: http://people.redhat.com/dcbw/network-manager-applet.spec > SRPM URL: > http://people.redhat.com/dcbw/network-manager-applet-0.9.3.995-1.git20120302.fc17.src.rpm This one passes a fedpkg mockbuild for me.
Yes, builds fine now. rpmlint: $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm libnm-gtk.x86_64: W: spelling-error %description -l en_US nm -> NM, mm, n libnm-gtk.x86_64: W: obsolete-not-provided NetworkManager-gtk libnm-gtk.x86_64: W: no-documentation libnm-gtk-devel.x86_64: W: no-dependency-on libnm-gtk/libnm-gtk-libs/liblibnm-gtk libnm-gtk-devel.x86_64: W: spelling-error %description -l en_US config -> con fig, con-fig, configure libnm-gtk-devel.x86_64: W: spelling-error %description -l en_US nm -> NM, mm, n libnm-gtk-devel.x86_64: W: no-documentation network-manager-applet.src: W: invalid-url Source0: http://ftp.gnome.org/pub/GNOME/sources/network-manager-applet/0.9/network-manager-applet-0.9.3.995.git20120302.tar.bz2 HTTP Error 404: Not Found network-manager-applet.x86_64: W: incoherent-version-in-changelog 0.9.3.995-1 ['0.9.3.995-1.git20120302.fc18', '0.9.3.995-1.git20120302'] network-manager-applet.x86_64: W: obsolete-not-provided NetworkManager-gnome network-manager-applet.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/nm-applet.schemas network-manager-applet.x86_64: E: zero-length /usr/share/doc/network-manager-applet-0.9.3.995/AUTHORS network-manager-applet.x86_64: E: zero-length /usr/share/doc/network-manager-applet-0.9.3.995/README network-manager-applet.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/nm-applet.desktop network-manager-applet.x86_64: W: no-manual-page-for-binary nm-applet nm-connection-editor.x86_64: W: no-documentation nm-connection-editor.x86_64: W: no-manual-page-for-binary nm-connection-editor 6 packages and 0 specfiles checked; 2 errors, 15 warnings.
package name: ok spec file name: ok packaging guidelines: generally ok; but it would be nice to use the standard gconf macros license: ok license field: ok language: ok readable: ok upstream sources: ok, but the url should be fixed buildable: ok excludearch: ok buildrequires: ok locale handling: ok ldconfig: ok system libs: ok relocatable: ok directory ownership: not ok; you must own /usr/share/nm-applet and /usr/include/libnm-gtk duplicate files: ok file permissions: ok macro use: ok content: ok large docs: ok %doc content: ok static libs: ok devel files: ok devel deps: not ok; libnm-gtk-devel should require libnm-gtk libtool archives: ok gui apps: not ok; currently only the autostart file is validated, the others should be too duplicate files: ok utf8 filenames: ok Summary: a few fixes required
git snapshots don't pass the URL check, I'm afraid... libnm-gtk-devel already own /usr/include/libnm-gtk: %files -n libnm-gtk-devel %defattr(-,root,root,0755) %dir %{_includedir}/libnm-gtk I'll update it to own /usr/share/nm-applet too.
Updated specfile and srpm at same URLs as comment 7.
Looks good now; approved
New Package SCM Request ======================= Package Name: network-manager-applet Short Description: GNOME network applet, connection editor, and UI libraries for NetworkManager Owners: dcbw jklimes Branches: f17 InitialCC:
Git done (by process-git-requests).
imported