Spec URL: http://jhernand.fedorapeople.org/rpms/txw2/20110809-2/txw2.spec SRPM URL: http://jhernand.fedorapeople.org/rpms/txw2/20110809-2/txw2-20110809-2.fc17.src.rpm Description: Typed XML writer for Java.
Assigned to a wrong component.
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Rpmlint output: txw2.src: W: invalid-url Source0: txw2-20110809.tar.gz txw2-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados 3 packages and 0 specfiles checked; 0 errors, 2 warnings. [x] Package is named according to the Package Naming Guidelines[1]. [x] Spec file name must match the base package name, in the format %{name}.spec. [x] Package meets the Packaging Guidelines[2]. [x] Package successfully compiles and builds into binary rpms. [x] Buildroot definition is not present [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [x] License field in the package spec file matches the actual license. License type: CDDL and GPLv2 with exceptions [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] All independent sub-packages have license of their own [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : 5f324bbcf133eea42305c994f2c575b4 MD5SUM upstream package: 5f324bbcf133eea42305c994f2c575b4 [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [x] Package must own all directories that it creates or must require other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] File sections do not contain %defattr(-,root,root,-) unless changed with good reason [x] Permissions on files are set properly. [x] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [x] Package contains code, or permissable content. [-] Fully versioned dependency in subpackages, if present. [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [x] Javadoc documentation files are generated and included in -javadoc subpackage [x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) [x] Packages have proper BuildRequires/Requires on jpackage-utils [x] Javadoc subpackages have Require: jpackage-utils [-] Package uses %global not %define [x] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [-] If source tarball includes bundled jar/class files these need to be removed prior to building [x] All filenames in rpm packages must be valid UTF-8. [!] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) [x] If package contains pom.xml files install it (including depmaps) even when building with ant [x] pom files has correct add_maven_depmap === Maven === [x] Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms [-] If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment [-] If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why it's needed in a comment [x] Package DOES NOT use %update_maven_depmap in %post/%postun [x] Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro === Other suggestions === [x] If possible use upstream build method (maven/ant/javac) [x] Avoid having BuildRequires on exact NVR unless necessary [x] Package has BuildArch: noarch (if possible) [x] Latest version is packaged. [x] Reviewer should test that the package builds in mock. Tested on: rawhide === Issues === 1. You've renamed the pom and jar files, and I'm not sure why. The artifact names are txw2-project (the "master" pom for the build), txw2, and txwc2, and the package name is txw2, so I don't think that renaming the jars to "txw2-runtime" and "txw2-compiler" is correct. === Final Notes === In one of my recent reviews, a reviewer mentioned that when adding your own patches to a build, it's a good idea to comment in the spec file about the purpose of each patch. It's a minor thing, but one we should start paying attention to. Please fix (or explain) issue #1 and I'll approve the package.
Fixed issue #1 and added comments for the patches. The new spec and SRPM are available here: http://jhernand.fedorapeople.org/rpms/txw2/20110809-3 An scratch build is available here: http://koji.fedoraproject.org/koji/taskinfo?taskID=3846034
Looks good. APPROVED.
New Package SCM Request ======================= Package Name: txw2 Short Description: Typed XML writer for Java Owners: jhernand Branches: f17 InitialCC: goldmann
Git done (by process-git-requests).
txw2-20110809-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/txw2-20110809-3.fc17
txw2-20110809-3.fc17 has been pushed to the Fedora 17 stable repository.