Bug 767050 - Review Request: hibernate-validator - Bean Validation (JSR 303) Reference Implementation
Summary: Review Request: hibernate-validator - Bean Validation (JSR 303) Reference Imp...
Keywords:
Status: CLOSED DUPLICATE of bug 799976
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 790553 794693 794722 794725
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-12-13 04:01 UTC by Andy Grimm
Modified: 2016-11-08 03:46 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-03-05 15:14:15 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Andy Grimm 2011-12-13 04:01:18 UTC
Name        : hibernate-validator
Version     : 4.2.0
Group       : Development/Libraries
License     : ASL 2.0
URL         : http://www.hibernate.org/subprojects/validator.html
Summary     : Bean Validation (JSR 303) Reference Implementation
Description :
Bean Validation (JSR 303) Reference Implementation

SPEC:
http://downloads.eucalyptus.com/devel/packages/fedora-16/SPECS/hibernate-validator.spec

SRPM:
http://downloads.eucalyptus.com/devel/packages/fedora-16/SRPMS/hibernate-validator-4.2.0-1.fc17.src.rpm

Comment 1 Marek Goldmann 2011-12-14 18:35:38 UTC
Andy,

You forgot to include pom file for hibernate-validator module. Instead you just added the parent pom, which should be renamed to JPP-%{name}-parent.pom

Comment 3 Marek Goldmann 2012-01-10 14:07:32 UTC
It seems that this package lacks of a few classes - most importantly HibernateValidar.class :) To add these classes we need to leave the xjc goal of jaxb2-maven-plugin. Unfortunately this plugin isn't packaged in Fedora yet. The jaxb2-maven-plugin requires jaxb-xjc... This where I ended. I have the jaxb2-maven-plugin spec file more or less prepared, but I haven't looked at jaxb-xjc yet. And I'll not have time to do this in the next week :(

I would really appreciate it if someone could look at jaxb-xjc.

Comment 4 Stanislav Ochotnicky 2012-01-13 13:07:16 UTC
Also watch out for maven-shade-plugin. The results of shading don't seem to be used inside the package itself, but it's possible some external package will require them

Comment 5 Marek Goldmann 2012-01-21 16:46:17 UTC
I packaged jaxb2-maven-plugin. This allowed me to compile the full hibernate-validator. I'll start submitting all required specs soon. In total - 13 new packages must be added...

In the meantime, here is what my spec looks like:

SPEC: http://goldmann.fedorapeople.org/package_review/hibernate-validator/1/hibernate-validator.spec
SRPM: http://goldmann.fedorapeople.org/package_review/hibernate-validator/1/hibernate-validator-4.2.0-3.fc17.src.rpm

Feel free to make changes to this spec.

Comment 6 Andy Grimm 2012-02-13 01:40:59 UTC
Marek, I rebuilt your source rpms on F17 over the weekend.  I had to make small changes to istack-commons, relaxngcc, and jaxb2-maven-plugin to make them build, but I got them to work.  I am concerned about the bootstrapping for relaxngcc (because it looks like it relies on a binary jar right now, rather than doing a partial build followed by a full build or something), but I think we should work together to get this whole stack of things cleaned up and packaged.  Thanks for working on this.

Comment 7 Marek Goldmann 2012-02-15 13:24:01 UTC
Andy,

Cleaned relaxngcc is submitted by Juan, here: https://bugzilla.redhat.com/show_bug.cgi?id=790549

Comment 8 Andy Grimm 2012-02-20 17:24:19 UTC
I'm setting some dependencies for this package.  They are mostly indirect deps, but it will make it more clear what's holding this one up.

Comment 9 Andy Grimm 2012-03-05 15:14:15 UTC
Closing in favor of Marek & Juan's version with all the right deps.

*** This bug has been marked as a duplicate of bug 799976 ***


Note You need to log in before you can comment on or make changes to this bug.