RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 795322 - add_ro should return error if not running in a config state
Summary: add_ro should return error if not running in a config state
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libguestfs
Version: 6.3
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Richard W.M. Jones
QA Contact: Virtualization Bugs
URL:
Whiteboard:
: 796523 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-20 08:59 UTC by Mohua Li
Modified: 2012-06-20 07:00 UTC (History)
4 users (show)

Fixed In Version: libguestfs-1.16.6-1.el6
Doc Type: Bug Fix
Doc Text:
No Documentation needed.
Clone Of:
: 796523 (view as bug list)
Environment:
Last Closed: 2012-06-20 07:00:40 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2012:0774 0 normal SHIPPED_LIVE Low: libguestfs security, bug fix, and enhancement update 2012-06-19 19:29:50 UTC

Description Mohua Li 2012-02-20 08:59:58 UTC 
Description of problem:

run add_ro in a ready state(after launch), didn't return an error, which might quite confused, as it didn't really added the disk to the applicance, you could get the info from qemu-kvm cmdline(file=/tmp/test1.img etc), 

so better to retrun an error if add_ro not running in a config state



Version-Release number of selected component (if applicable):
libguestfs-1.16.5-1.el6.x86_64

How reproducible:
always

Steps to Reproduce:
1.guestfish -xv -N fs
2.add-ro rhevh.img 
3.list-filesystems
  
Actual results:
add-ro not running in a config state, didn't return an error 

Expected results:
add-ro not running in a config state, return an error 

Additional info:
Comment 1 Qixiang Wan 2012-02-20 09:45:43 UTC 
There are many other commands working like this, so it sounds reasonable to find a good solution to make it work for other commands too.

And there is another reason to get this fixed, the commands like 'add-ro' won't take effect after launch, but the original parameters can be lost if we want to check that. for example:

# guestfish -a /dev/null
[...]
><fs> run
><fs> get-smp 
1
><fs> set-smp 4
><fs> get-smp 
4
><fs> 

Actually, we're expecting to get 1 rather than 4, because there is only one vcpu assigned to the appliance, and it's impossible for the appliance to get 4 virtual vcpus now.
Comment 2 Richard W.M. Jones 2012-02-20 11:10:00 UTC 
I see what's happened here is a subtle regression in
this commit:

https://github.com/libguestfs/libguestfs/commit/f1041e912b72116d66274d2f15e50ce34a9531fd

The old path used to call guestfs__add_drive_opts ->
guestfs__config -> add_cmdline, and add_cmdline contains
this check:

  if (g->state != CONFIG) {
    error (g,
        _("command line cannot be altered after qemu subprocess launched"));
    return -1;
  }

However after that commit, guestfs__add_drive_opts
adds the drive to an internal list of drives and
doesn't immediately call add_cmdline.  Thus the
error check above is never performed.

Therefore this bug is a regression from RHEL 6.2.
Comment 3 Richard W.M. Jones 2012-02-20 11:10:49 UTC 
(In reply to comment #1)
> There are many other commands working like this, so it sounds reasonable to
> find a good solution to make it work for other commands too.
> 
> And there is another reason to get this fixed, the commands like 'add-ro' won't
> take effect after launch, but the original parameters can be lost if we want to
> check that. for example:
> 
> # guestfish -a /dev/null
> [...]
> ><fs> run
> ><fs> get-smp 
> 1
> ><fs> set-smp 4
> ><fs> get-smp 
> 4
> ><fs> 
> 
> Actually, we're expecting to get 1 rather than 4, because there is only one
> vcpu assigned to the appliance, and it's impossible for the appliance to get 4
> virtual vcpus now.

Just to note this is a separate issue and requires a new BZ.
Comment 5 Wanlong Gao 2012-02-23 05:25:43 UTC 
(In reply to comment #1)
> There are many other commands working like this, so it sounds reasonable to
> find a good solution to make it work for other commands too.
> 
> And there is another reason to get this fixed, the commands like 'add-ro' won't
> take effect after launch, but the original parameters can be lost if we want to
> check that. for example:
> 
> # guestfish -a /dev/null
> [...]
> ><fs> run
> ><fs> get-smp 
> 1
> ><fs> set-smp 4
> ><fs> get-smp 
> 4
> ><fs> 
> 
> Actually, we're expecting to get 1 rather than 4, because there is only one
> vcpu assigned to the appliance, and it's impossible for the appliance to get 4
> virtual vcpus now.

A fix patch has sent against upstream.
https://www.redhat.com/archives/libguestfs/2012-February/msg00082.html
Comment 6 Wanlong Gao 2012-02-23 05:53:53 UTC 
(In reply to comment #3)
> (In reply to comment #1)
> > There are many other commands working like this, so it sounds reasonable to
> > find a good solution to make it work for other commands too.
> > 
> > And there is another reason to get this fixed, the commands like 'add-ro' won't
> > take effect after launch, but the original parameters can be lost if we want to
> > check that. for example:
> > 
> > # guestfish -a /dev/null
> > [...]
> > ><fs> run
> > ><fs> get-smp 
> > 1
> > ><fs> set-smp 4
> > ><fs> get-smp 
> > 4
> > ><fs> 
> > 
> > Actually, we're expecting to get 1 rather than 4, because there is only one
> > vcpu assigned to the appliance, and it's impossible for the appliance to get 4
> > virtual vcpus now.
> 
> Just to note this is a separate issue and requires a new BZ.

New BZ created to https://bugzilla.redhat.com/show_bug.cgi?id=796523
Comment 7 Richard W.M. Jones 2012-03-01 16:40:51 UTC 
*** Bug 796523 has been marked as a duplicate of this bug. ***
Comment 10 Richard W.M. Jones 2012-04-26 13:44:57 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No Documentation needed.
Comment 12 errata-xmlrpc 2012-06-20 07:00:40 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0774.html
Note You need to log in before you can comment on or make changes to this bug.