Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 796523

Summary: add_ro should return error if not running in a config state
Product: Red Hat Enterprise Linux 6 Reporter: Wanlong Gao <gaowanlong>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED DUPLICATE QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.3CC: gaowanlong, leiwang, moli, qguan, qwan, syeghiay
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 795322 Environment:
Last Closed: 2012-03-01 16:40:51 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Wanlong Gao 2012-02-23 05:51:21 UTC
+++ This bug was initially created as a clone of Bug #795322 +++


--- Additional comment from qwan on 2012-02-20 04:45:43 EST ---

There are many other commands working like this, so it sounds reasonable to find a good solution to make it work for other commands too.

And there is another reason to get this fixed, the commands like 'add-ro' won't take effect after launch, but the original parameters can be lost if we want to check that. for example:

# guestfish -a /dev/null
[...]
><fs> run
><fs> get-smp 
1
><fs> set-smp 4
><fs> get-smp 
4
><fs> 

Actually, we're expecting to get 1 rather than 4, because there is only one vcpu assigned to the appliance, and it's impossible for the appliance to get 4 virtual vcpus now.


--- Additional comment from rjones on 2012-02-20 06:10:49 EST ---

(In reply to comment #1)
> There are many other commands working like this, so it sounds reasonable to
> find a good solution to make it work for other commands too.
> 
> And there is another reason to get this fixed, the commands like 'add-ro' won't
> take effect after launch, but the original parameters can be lost if we want to
> check that. for example:
> 
> # guestfish -a /dev/null
> [...]
> ><fs> run
> ><fs> get-smp 
> 1
> ><fs> set-smp 4
> ><fs> get-smp 
> 4
> ><fs> 
> 
> Actually, we're expecting to get 1 rather than 4, because there is only one
> vcpu assigned to the appliance, and it's impossible for the appliance to get 4
> virtual vcpus now.

Just to note this is a separate issue and requires a new BZ.

--- Additional comment from gaowanlong.com on 2012-02-23 00:25:43 EST ---

(In reply to comment #1)
> There are many other commands working like this, so it sounds reasonable to
> find a good solution to make it work for other commands too.
> 
> And there is another reason to get this fixed, the commands like 'add-ro' won't
> take effect after launch, but the original parameters can be lost if we want to
> check that. for example:
> 
> # guestfish -a /dev/null
> [...]
> ><fs> run
> ><fs> get-smp 
> 1
> ><fs> set-smp 4
> ><fs> get-smp 
> 4
> ><fs> 
> 
> Actually, we're expecting to get 1 rather than 4, because there is only one
> vcpu assigned to the appliance, and it's impossible for the appliance to get 4
> virtual vcpus now.

A fix patch has sent against upstream.
https://www.redhat.com/archives/libguestfs/2012-February/msg00082.html

Comment 2 Wanlong Gao 2012-02-25 01:08:25 UTC
A upstream patch has been pushed:
https://github.com/libguestfs/libguestfs/commit/9e5c0b39c6b598a733a790d73d27eae491910a22

Comment 3 Richard W.M. Jones 2012-03-01 16:40:51 UTC
Closing, seems to be a duplicate of bug 795322.

*** This bug has been marked as a duplicate of bug 795322 ***