Created attachment 564542 [details] This patch substitutes the macro to correct compile failures. Description of problem: While attempting to fix a gLabels bug, I came across a build failure that warranted some more research. The compilation would fail near the end with: gcc: error: @LIBPTHREAD@: No such file or directory Looking into it, I found that qrencode's pkgconfig file contains the erroneous: Libs: -L${libdir} -lqrencode @LIBPTHREAD@ This caused gLabels (and I imagine any other program attempting to build against libqrencode) to fail because the LIBPTHREAD macro wasn't substituted properly. In gLabels this is not needed explicitly (since it pulls in the pthread stuff through libebook). However, I'm sure this is not the case as a general rule, so it is simple enough to fix with a quick patch, attached. Version-Release number of selected component (if applicable): 3.2.0-1.fc16 Lastly, @Casper: I do have commit access to qrencode in Fedora Git; but as am I not the primary maintainer I did not want to commit this and step on your proverbial toes. If you agree, I'd be happy to commit this. Thanks.
Hello, Your patch looks good, so you can commit this :)
qrencode-3.2.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/qrencode-3.2.0-2.fc17
qrencode-3.2.0-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/qrencode-3.2.0-2.fc16
qrencode-3.2.0-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/qrencode-3.2.0-2.fc15
Hi Peter, in qrencode-3.2.0-2 your patch isn't applied on sources. Don't worry, there isn't any breaks, just some lines to apply the patch are missing in the spec file. You can see in other srpms how to apply a patch. So just make a new release with the following (and update the %changelog too) : --- qrencode.spec.orig 2012-02-23 12:56:27.044259588 +0100 +++ qrencode.spec 2012-02-23 13:06:17.374286364 +0100 @@ -1,12 +1,14 @@ Name: qrencode Version: 3.2.0 -Release: 2%{?dist} +Release: 3%{?dist} Summary: Generate QR 2D barcodes Group: Applications/Engineering License: LGPLv2+ URL: http://megaui.net/fukuchi/works/qrencode/index.en.html Source0: http://megaui.net/fukuchi/works/qrencode/%{name}-%{version}.tar.gz +# https://bugzilla.redhat.com/show_bug.cgi?id=795582 +Patch0: qrencode-fix-LIBPTHREAD-macro.patch BuildRequires: libpng-devel chrpath @@ -26,6 +28,7 @@ applications that use qrencode. %prep %setup -q +%patch0 -p1 %build @@ -61,6 +64,9 @@ sh test_all.sh %changelog +* Thu Feb 23 2012 Matthieu Saulnier <fantom> - 3.2.0-3 +- fix applying patch on source in spec file + * Thu Feb 23 2012 Peter Gordon <peter> - 3.2.0-2 - Add patch to fix improper LIBPTHREAD macro in the pkgconfig file: + fix-LIBPTHREAD-macro.patch
Hi Peter, the patch you have commited in scm repository is not *exactly* the same as your patch created on attachement of this bug. The consequence is, when the patch is applied on sources, to do a fatal error in %prep part during the build in mock. Please correct that before a new fedpkg build. :-)
Package qrencode-3.2.0-2.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing qrencode-3.2.0-2.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-2268/qrencode-3.2.0-2.fc17 then log in and leave karma (feedback).
Ack, sorry. I suppose that's what I get for committing when I should have been asleep. :P I'll fix that up and build the new one right away.
qrencode-3.2.0-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/qrencode-3.2.0-3.fc17
qrencode-3.2.0-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/qrencode-3.2.0-3.fc16
Package qrencode-3.2.0-3.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing qrencode-3.2.0-3.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-3570/qrencode-3.2.0-3.fc17 then log in and leave karma (feedback).
qrencode-3.2.0-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/qrencode-3.2.0-3.fc15
qrencode-3.2.0-3.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
qrencode-3.2.0-3.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.
qrencode-3.2.0-3.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.