Bug 809495 - SUNRPC: We must not use list_for_each_entry_safe() in rpc_wake_up()
SUNRPC: We must not use list_for_each_entry_safe() in rpc_wake_up()
Status: CLOSED DUPLICATE of bug 809928
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: kernel (Show other bugs)
Unspecified Unspecified
unspecified Severity unspecified
: rc
: ---
Assigned To: nfs-maint
Filesystem QE
Depends On:
Blocks: 809502
  Show dependency treegraph
Reported: 2012-04-03 10:17 EDT by Steve Dickson
Modified: 2013-03-03 19:22 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 809502 (view as bug list)
Last Closed: 2012-04-04 13:24:02 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Steve Dickson 2012-04-03 10:17:40 EDT
Description of problem:

    The problem is that for the case of priority queues, we
    have to assume that __rpc_remove_wait_queue_priority will move new
    elements from the tk_wait.links lists into the queue->tasks[] list.
    We therefore cannot use list_for_each_entry_safe() on queue->tasks[],
    since that will skip these new tasks that __rpc_remove_wait_queue_priority
    is adding.
    Without this fix, rpc_wake_up and rpc_wake_up_status will both fail
    to wake up all functions on priority wait queues, which can result
    in some nasty hangs.

Version-Release number of selected component (if applicable):

How reproducible:

Additional info:

Upstream commit:

commit 540a0f7584169651f485e8ab67461fcb06934e38
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Mon Mar 19 13:39:35 2012 -0400

    SUNRPC: We must not use list_for_each_entry_safe() in rpc_wake_up()
Comment 1 RHEL Product and Program Management 2012-04-03 10:20:07 EDT
This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux maintenance release. Product Management has 
requested further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed 
products. This request is not yet committed for inclusion in an Update release.
Comment 3 Steve Dickson 2012-04-04 13:24:02 EDT

*** This bug has been marked as a duplicate of bug 809928 ***

Note You need to log in before you can comment on or make changes to this bug.