Spec URL: http://kalev.fedorapeople.org/accerciser.spec SRPM URL: http://kalev.fedorapeople.org/accerciser-3.4.1-1.fc17.src.rpm Description: Accerciser is an interactive Python accessibility explorer for the GNOME desktop. It uses AT-SPI to inspect and control widgets, allowing you to check if an application is providing correct information to assistive technologies and automated test frameworks. Accerciser has a simple plugin framework which you can use to create custom views of accessibility information.
*** Bug 546738 has been marked as a duplicate of this bug. ***
Initial spec review looks clean.
Ok, I made sure it would build on rawhide and checked rpmlint: $ rpmlint mockbuild/rawhide/accerciser/*.rpm accerciser.noarch: E: explicit-lib-dependency libwnck3 accerciser.noarch: W: spelling-error %description -l en_US assistive -> assertive, passive, massive accerciser.noarch: E: non-executable-script /usr/share/accerciser/plugins/ipython_view.py 0644L /usr/bin/python accerciser.src: W: spelling-error %description -l en_US assistive -> assertive, passive, massive 2 packages and 0 specfiles checked; 2 errors, 2 warnings. The only one I think you need to fix is the non-executable-script. I'm assuming that it isn't run directly but used as a module. In that case just remove the shebang either with sed or a patch and make sure upstream knows.
+: OK -: must be fixed =: should be fixed (at your discretion) ?: Question or clairification needed N: not applicable MUST: [+] rpmlint output: shown in comment. [+] follows package naming guidelines [+] spec file base name matches package name [+] package meets the packaging guidelines [+] package uses a Fedora approved license: BSD [+] license field matches the actual license. [+] license file is included in %doc: COPYING [+] spec file is in American English [+] spec file is legible [+] sources match upstream: md5sum matches (fba7edb13dd80ef63e6044b411a6a84f) [+] package builds on at least one primary arch: Tested x86_64 [N] appropriate use of ExcludeArch [+] all build requirements in BuildRequires [N] spec file handles locales properly [N] ldconfig in %post and %postun [+] no bundled copies of system libraries [+] no relocatable packages [+] package owns all directories that it creates [+] no files listed twice in %files [+] proper permissions on files [+] consistent use of macros [+] code or permissible content [N] large documentation in -doc [+] no runtime dependencies in %doc [N] header files in -devel [N] static libraries in -static [N] .so in -devel [N] -devel requires main package [+] package contains no libtool archives [+] package contains a desktop file, uses desktop-file-install/validate [+] package does not own files/dirs owned by other packages [+] all filenames in UTF-8 SHOULD: [+] query upstream for license text [N] description and summary contains available translations [+] package builds in mock [+] package builds on all supported arches: Tested x86_64 [?] package functions as described: Not tested [+] sane scriptlets [N] subpackages require the main package [N] placement of pkgconfig files [+] file dependencies versus package dependencies [+] package contains man pages for binaries/scripts Just make sure you take care of the non-executable-script problem. *** APPROVED ***
Thanks for the review, Richard!
New Package SCM Request ======================= Package Name: accerciser Short Description: Interactive Python accessibility explorer for the GNOME desktop Owners: kalev Branches: f17 InitialCC:
Git done (by process-git-requests).