sratom is a C library for serializing LV2 atoms to/from Turtle. It is intended to be a full serialization solution for LV2 atoms, allowing implementations to serialise binary atoms to strings and read them back again. This is particularly useful for saving plugin state, or implementing plugin control with network transparency. This is a dependency for the new upstream release of package lilv (0.14.0). SPEC: http://bsjones.fedorapeople.org/lv2/sratom.spec SRPM: http://bsjones.fedorapeople.org/lv2/sratom-0.2.0-1.fc16.src.rpm rpmlint /home/bsjones/rpmbuild/SRPMS/sratom-0.2.0-1.fc16.src.rpm /home/bsjones/rpmbuild/RPMS/x86_64/sratom-0.2.0-1.fc16.x86_64.rpm /home/bsjones/rpmbuild/RPMS/x86_64/sratom-devel-0.2.0-1.fc16.x86_64.rpm /home/bsjones/rpmbuild/RPMS/x86_64/sratom-debuginfo-0.2.0-1.fc16.x86_64.rpm 4 packages and 0 specfiles checked; 0 errors, 0 warnings.
Build requirements exist in rawhide only for the moment
Hi, could you clarify why this blocks qtractor?
I see that the new lilv requires sratom, but I don't think qtractor requires the new lilv specifically.
That's right - not specifically, I just wanted to hold up the qtractor review against the new LV2 (lv2/lilv/suil) updates. Up until now qtractor is the only package that is using suil/lilv.
I made a full review on this, but I see that Mattias is already assigned to the bug. I'll post my findings anyways: ! rpmlint says: sratom.x86_64: W: spelling-error %description -l en_US serialisation -> serialization, sensationalist, sensationalism sratom.x86_64: W: spelling-error %description -l en_US serialise -> serialize, serial, aerialist sratom.src: W: spelling-error Summary(en_US) serialising -> serializing, serialization There was a requirement that says the spec file must be written in American English, so I guess we should use serializ* * Need to add BuildRequires: serd-devel >= 0.14.0 Other than the above, the package is good to go.
Fedora Review sratom 2012-04-22 $ rpmlint sratom*.rpm sratom.src: W: spelling-error Summary(en_US) serialising -> serializing, serialization sratom.src: W: spelling-error %description -l en_US serialising -> serializing, serialization sratom.src: W: spelling-error %description -l en_US serialisation -> serialization, sensationalist, sensationalism sratom.src: W: spelling-error %description -l en_US serialise -> serialize, serial, aerialist sratom.x86_64: W: spelling-error Summary(en_US) serialising -> serializing, serialization sratom.x86_64: W: spelling-error %description -l en_US serialising -> serializing, serialization sratom.x86_64: W: spelling-error %description -l en_US serialisation -> serialization, sensationalist, sensationalism sratom.x86_64: W: spelling-error %description -l en_US serialise -> serialize, serial, aerialist sratom-devel.x86_64: W: spelling-error %description -l en_US serialising -> serializing, serialization sratom-devel.x86_64: W: spelling-error %description -l en_US serialisation -> serialization, sensationalist, sensationalism sratom-devel.x86_64: W: spelling-error %description -l en_US serialise -> serialize, serial, aerialist 4 packages and 0 specfiles checked; 0 errors, 11 warnings. Clean except for American English spelling in Summary and Description. + Package name according to guidelines + Specfile named after package + Package license (MIT) Fedora approved + Package license reflects license as stated in the sources + License file (COPYING) included as %doc - Specfile uses British spelling in summary and description This should be changed to American spelling according to guidelines See also the rpmlint report above + Specfile is readable + Source matches upstream $ md5sum sratom-0.2.0.tar.bz2 srpm/sratom-0.2.0.tar.bz2 c03cf2849186818610ffe889be4f5b55 sratom-0.2.0.tar.bz2 c03cf2849186818610ffe889be4f5b55 srpm/sratom-0.2.0.tar.bz2 - Package fail to build due to missing BuildRequires: python ./waf configure -v --prefix=/usr --libdir=/usr/lib64 --mandir=/usr/share/man --datadir=/usr/share --docdir=/usr/share/doc/sratom-devel-0.2.0 --test --docs /usr/bin/env: python: No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.3g1rbM (%build) [ Also my rebuild of the lv2 package on which this package depends failed with the same error ] + No locales + Scriptlets call ldconfig + No bundled libraries + Package owns directories it creates + No duplicates in %files + File permissions are sane + Specfile uses macros consistently + Contains code + Documentation is in -devel, though can be considered small + %doc not runtime essential + No static libraries + Headers and develoment library symlinks in -devel + -devel requires main with fully qualified version + No .la files + Package does not own ohters' libraries + Filenames valid UTF8 Summary: Fix American spelling and add missing BR on python
SPEC: http://bsjones.fedorapeople.org/lv2/sratom.spec SRPM: http://bsjones.fedorapeople.org/lv2/sratom-0.2.0-2.fc16.src.rpm I've addressed the issues you picked up. Apologies for the missing BR. I've discovered a bug in the build tests for i686, and this will currently fail in mock. Seems to be OK for x86_64. I'll work through this with upstream and get it patched.
Package approved.
Thanks for taking this review New Package SCM Request ======================= Package Name: sratom Short Description: A C library for serializing LV2 atoms Owners: bsjones Branches: f16 f17 InitialCC:
Git done (by process-git-requests).
sratom-0.2.0-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/sratom-0.2.0-3.fc17
sratom-0.2.0-3.fc17 has been pushed to the Fedora 17 testing repository.
sratom-0.2.0-3.fc17 has been pushed to the Fedora 17 stable repository.