Spec URL: http://mtasaka.fedorapeople.org/Review_request/ruby-debug-related/rubygem-ruby-debug19.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/ruby-debug-related/rubygem-ruby-debug19-0.11.6-1.fc.src.rpm Description: A generic command line interface for ruby-debug. mock build for f17 (koji scratch build not available because this depends on another review request bug 818457) http://mtasaka.fedorapeople.org/Review_request/ruby-debug-related/MOCK-rubygem-ruby-debug19.log
http://mtasaka.fedorapeople.org/Review_request/ruby-debug-related/rubygem-ruby-debug19.spec http://mtasaka.fedorapeople.org/Review_request/ruby-debug-related/rubygem-ruby-debug19-0.11.6-2.fc.src.rpm * Fri Sep 14 2012 Mamoru Tasaka <mtasaka> - 0.11.6-2 - Rebuild
This is just a comment from one user to encourage someone to take on the review of this package (and it's Depends On, 818457). I noticed that Mamoru TASAKA and Bohuslav "Slavek" Kabrda were very successful in getting rubygem-linecache19 through QA and released (thanks!), but rubygem-ruby-debug19 and rubygem-ruby-debug-base19 seem to be stalled. My goal as an end user is to have ruby itself and a minimal set of additional packages (ruby-devel, rubygem-bundler, rubygem-rake, and their dependencies) installed and then to manage all the other gems (including rails, rack, etc.) using bundler on a per-user basis. This seems to be working reasonably well, but I can't use bundler to install ruby-debug19 because the various gems involved all appear to require a full copy of the source tree (or at least files that aren't included in ruby-devel, like vm_core.h). I'd rather not have to keep installing the source tree on a per-user basis and customizing bundler in order to get it to find the source tree (plus worrying about keeping it up-to-date every time there's a backport of a patch). As a result, I'd like to add ruby-debug19 into my list of minimal additional packages, but unfortunately Mamoru TASAKA's work seems to be hung up waiting for someone else to do a package review. As it is, I'll just live without the debugger, but it would be really cool if someone (perhaps even Bohuslav "Slavek" Kabrda) were to do the package review on the two debug19 packages. I just learned that the package review process exists from reading the history on https://bugzilla.redhat.com/show_bug.cgi?id=818454, which should explain why I am not qualified or permitted to do one! Thanks so much for the work you are all doing to make Ruby easier to use on Fedora - it is really appreciated.
Hi Toby, thanks for your kind words about making Ruby easier to use on Fedora :) Although I have almost no time to spare, I'll take this review.
The specfile is clean, the package builds and works fine. The only tiny thing that I was able to find is, that you're missing popd in pair to pushd in %check, but I'm only mentioning that because I don't know what else to say :) Package is APPROVED.
Okay, I will add popd for consistency, thank you for reviewing.
New Package SCM Request ======================= Package Name: rubygem-ruby-debug19 Short Description: Command line interface (CLI) for ruby-debug-base Owners: mtasaka Branches: InitialCC: f18 f17
Git done (by process-git-requests).
rubygem-ruby-debug19-0.11.6-3.fc18, rubygem-ruby-debug-base19-0.11.26-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/FEDORA-2012-16935/rubygem-ruby-debug19-0.11.6-3.fc18,rubygem-ruby-debug-base19-0.11.26-3.fc18
rubygem-ruby-debug19-0.11.6-3.fc17, rubygem-ruby-debug-base19-0.11.26-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-ruby-debug19-0.11.6-3.fc17,rubygem-ruby-debug-base19-0.11.26-3.fc17
@Bohuslav Thank you for review. @Toby, please try rubygem-ruby-debug19 and -debug-base19 rpms when testing packages are available.
Hi Mamoru, Thanks for the packages. I see that you already retired rubygem-ruby-debug and rubygem-ruby-debug-base, but could you please also request RelEngs to block the packages? It would be nice to retire and block rubygem-linecache as well. Thank you.
Sorry for the delay in testing. I just installed rubygem-ruby-debug19 from the testing repository along with all the dependencies (it picked up rubygem-ruby-debug-base19 from testing, rubygem-linecache19 from updates, and rubygem-columnize from fedora) and everything went smoothly. The debugger appears to work correctly (I uncommented the ruby-debug19 line in my Gemfile, bundle install found the machine version without any problem, and I was able to start rails with the debugger and successfully break into the debugger by inserting a debugger line into my source). Thank you all so much!
(In reply to comment #11) > Hi Mamoru, > > Thanks for the packages. > > I see that you already retired rubygem-ruby-debug and > rubygem-ruby-debug-base, but could you please also request RelEngs to block > the packages? It would be nice to retire and block rubygem-linecache as > well. Thank you. I want to do this after F-18 one is pushed into stable, i.e. F-18 beta freeze is over (I also want to block this on F-18).
I see you have everything under control. Great! Thank you :)
rubygem-ruby-debug19-0.11.6-3.fc17, rubygem-ruby-debug-base19-0.11.26-3.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-ruby-debug19-0.11.6-3.fc18, rubygem-ruby-debug-base19-0.11.26-3.fc18 has been pushed to the Fedora 18 stable repository.
(In reply to comment #11) > Hi Mamoru, > > Thanks for the packages. > > I see that you already retired rubygem-ruby-debug and > rubygem-ruby-debug-base, but could you please also request RelEngs to block > the packages? It would be nice to retire and block rubygem-linecache as > well. Thank you. Filed: https://fedorahosted.org/rel-eng/ticket/5388 Closing this bug. Thank you, everyone.