Bug 819145 - [as7] code in discovery that figures out System property (sysprop) values by parsing the server command line does not process -P/--properties option
Summary: [as7] code in discovery that figures out System property (sysprop) values by ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: Plugins
Version: 4.4
Hardware: Unspecified
OS: Unspecified
urgent
high
Target Milestone: ---
: RHQ 4.5.0
Assignee: Charles Crouch
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On: 820445
Blocks: as7-plugin jon310-sprint11, rhq44-sprint11 820570 820584
TreeView+ depends on / blocked
 
Reported: 2012-05-05 04:26 UTC by Ian Springer
Modified: 2015-02-01 23:28 UTC (History)
4 users (show)

Fixed In Version: 4.5
Clone Of:
: 820570 820584 (view as bug list)
Environment:
Last Closed: 2013-09-01 10:11:04 UTC
Embargoed:


Attachments (Terms of Use)

Description Ian Springer 2012-05-05 04:26:02 UTC
standalone.sh/bat and domain.sh/bat both support the following command line options:

    -P=<url>                            Load system properties from the given 
                                        url

    -P <url>                            Load system properties from the given 
                                        url

    --properties=<url>                  Load system properties from the given 
                                        url

Comment 1 Mike Foley 2012-05-08 18:11:28 UTC
per BZ triage crouch, foley, loleary

Comment 2 Ian Springer 2012-05-10 00:18:00 UTC
Fixed in master: 

http://git.fedorahosted.org/git/?p=rhq/rhq.git;a=commitdiff;h=7b1a63a

Note, AS7 support more than one -P and/or --properties option on the same command line, and our code handles that.

Comment 3 Ian Springer 2012-05-10 12:06:51 UTC
Note, the unit test for this fix (AS7CommandLineTest) depends on the fix for bug 820445.

Comment 4 Jay Shaughnessy 2012-05-16 13:02:45 UTC
Note, this support is in AS5, and I've added a unit test to ensure it
is working.

Comment 5 Ian Springer 2012-05-29 13:26:09 UTC
http://git.fedorahosted.org/git/?p=rhq/rhq.git;a=commitdiff;h=e9c19a7 fixes a bug in the original fix, which caused an "IllegalArgumentException: URI is not absolute" error when trying to parse a -P option value that was a relative path.

Comment 8 Heiko W. Rupp 2013-09-01 10:11:04 UTC
Bulk closing of items that are on_qa and in old RHQ releases, which are out for a long time and where the issue has not been re-opened since.


Note You need to log in before you can comment on or make changes to this bug.