Bug 819500 - sos devicemapper plugin passes wrong arguments to systool for scsi bus info
Summary: sos devicemapper plugin passes wrong arguments to systool for scsi bus info
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: sos
Version: 19
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
Assignee: Bryn M. Reeves
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 868719 1036799
TreeView+ depends on / blocked
 
Reported: 2012-05-07 12:36 UTC by Mark Goodwin
Modified: 2014-04-14 22:47 UTC (History)
4 users (show)

Fixed In Version: sos-3.0-23.fc19
Clone Of:
: 868719 (view as bug list)
Environment:
Last Closed: 2014-04-14 22:47:12 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
correct arguemnts to systool to capture scsi bus info (617 bytes, patch)
2012-05-07 12:36 UTC, Mark Goodwin
no flags Details | Diff

Description Mark Goodwin 2012-05-07 12:36:32 UTC
Created attachment 582644 [details]
correct arguemnts to systool to capture scsi bus info

Description of problem:
The devicemapper.py plugin in the sos tool invokes systool with incorrect
arguments for capturing scsi bus info. The patch from BZ #444838 and
it's various z-stream clones appears to be wrong. The correct usage
for scsi bus info is "systool -v -b scsi" or for scsi_host info is
"systool -v -c scsi_host". 

Version-Release number of selected component (if applicable):
All versions of sos in all versions of RHEL and Fedora, and also upstream
in the master branch at: https://github.com/sosreport/sosreport.git

How reproducible:
always

Steps to Reproduce:
1. run sosreport on a system with scsi devices
2. In the resulting sos tarball:
   # cat sos_commands/devicemapper/systool_-v_-c_-b_scsi
   Error opening class -b
  
Actual results:
   literally: "Error opening class -b" in all captured sos reports.

Expected results:
   scsi bus information (here omitted for brevity)

Additional info:
   the systool arguments are wrong, see attached patch against the
   current upstream master branch

Comment 1 Mark Goodwin 2012-05-07 13:03:09 UTC
Capturing the output of the following command would be even more useful,
but that's really an RFE rather than a bug fix :

systool -v -b scsi -c scsi_device -c scsi_disk -c scsi_generic -c scsi_host -m fc_host -m fc_remote_ports -m fc_transport -m fc_vports -m scsi_transport_fc -m scsi_tgt -m fcoe

See also BZ #444839 for capturing FC state. It would be useful to capture
some of the fc transport statistics (error_frames, crc_errors, etc), since
these are important for diagnosing flaky FC cables/connections.

Comment 7 Fedora End Of Life 2013-04-03 18:08:06 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 8 Fedora Update System 2014-03-31 16:22:56 UTC
sos-3.0-23.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/sos-3.0-23.fc19

Comment 9 Fedora Update System 2014-04-02 09:23:57 UTC
Package sos-3.0-23.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing sos-3.0-23.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-4668/sos-3.0-23.fc19
then log in and leave karma (feedback).

Comment 10 Fedora Update System 2014-04-14 22:47:12 UTC
sos-3.0-23.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.