Spec URL: http://admiyo.fedorapeople.org/noVNC/novnc.spec SRPM URL: http://admiyo.fedorapeople.org/noVNC/novnc-0.3-1.f17ayoung.src.rpm Description: - websockets based vnc client and simple server
Hey Adam, I see that you are using an index.html file as a work-around to stop directory browsing. You may also consider adding such a file to public subdirectories (images, include, include/web-socket-js). To make nova-novncproxy work out-of-the-box you could patch the --web default value to /usr/share/novnc: https://github.com/kanaka/noVNC/blob/master/utils/nova-novncproxy#L58
rpmlint: novnc.noarch: W: summary-ended-with-dot C VNC client using HTML5 (Web Sockets, Canvas) with encryption (wss://) support. novnc.noarch: E: description-line-too-long C Websocket implementation of VNC client, with simple python-websockify starter script novnc.noarch: W: incoherent-version-in-changelog 0.1.0-2 ['0.3-1.fc15', '0.3-1'] novnc.noarch: W: invalid-license GPL V3 novnc.noarch: W: no-manual-page-for-binary novnc_server novnc-nova-proxy.noarch: W: spelling-error Summary(en_US) Openstack -> OpenStack novnc-nova-proxy.noarch: W: spelling-error %description -l en_US Openstack -> OpenStack novnc-nova-proxy.noarch: W: tag-in-description C Requires: novnc-nova-proxy.noarch: W: tag-in-description C Requires: novnc-nova-proxy.noarch: W: invalid-license GPL V3 novnc-nova-proxy.noarch: W: no-documentation novnc-nova-proxy.noarch: W: no-manual-page-for-binary nova-novncproxy
I installed the package in a cloud controller and it seems that there is a issue when using websockify rpm. It fails to start because a missing dependency. I found that needs wsproxy python module. Solved if you modify it like this diff /usr/bin/nova-novncproxy.nopatch /usr/bin/nova-novncproxy 29c29 < import wsproxy --- > import websockify as wsproxy BTW in the RPM, I think that it need a way to start this service as it is on openstack in other distributions /lib/systemd/system/openstack-nova-novncproxy.service [Unit] Description=OpenStack Nova NoVNC Proxy Server After=syslog.target network.target [Service] Type=simple User=nova ExecStart=/usr/bin/nova-novncproxy --flagfile=/etc/nova/nova.conf --web /usr/share/novnc/ [Install] WantedBy=multi-user.target
Updated: http://admiyo.fedorapeople.org/noVNC/novnc-0.3-3.f17ayoung.src.rpm http://admiyo.fedorapeople.org/noVNC/novnc.spec Systemd work not included.
Supports systemd for F17+ and RHEL7+ adn System V otherwise http://admiyo.fedorapeople.org/noVNC/novnc-0.3-4.f17ayoung.src.rpm http://admiyo.fedorapeople.org/noVNC/novnc.spec
Minor update. This fixes an rpmlint error and also makes a correction to the SystemV init script http://admiyo.fedorapeople.org/noVNC/novnc-0.3-5.f17ayoung.src.rpm http://admiyo.fedorapeople.org/noVNC/novnc.spec
Created attachment 591056 [details] spec adjustments I've made some adjustments to the package as per the attached patch. The following are rpmlint clean and build in mock: http://pbrady.fedorapeople.org/novnc/novnc-0.3-5.fc15.src.rpm http://pbrady.fedorapeople.org/novnc/novnc.spec
Merging in Adam's overlapping changes: http://pbrady.fedorapeople.org/novnc/novnc-0.3-6.fc15.src.rpm http://pbrady.fedorapeople.org/novnc/novnc.spec
New Package SCM Request ======================= Package Name: novnc Short Description: VNC client using HTML5 (Web Sockets, Canvas) with encryption support Owners: pbrady nsantos Branches: f16 f17 el6 InitialCC:
Summary and SCM request package nams don't match, please correct.
sorry I don't understand comment 10?
Summary has noVNC, SCM request is novnc, package names are case-sensitive.
Ah the bug summary is significant here. I've synced both. Cheers. New Package SCM Request ======================= Package Name: novnc Short Description: websockets based VNC client and simple server Owners: pbrady nsantos Branches: f16 f17 el6 InitialCC:
Git done (by process-git-requests). Excellent, thanks very much!
thanks guys!
openstack-nova-novncproxy is missing dependency, nova-novncproxy imports from nova: --- a/novnc.spec +++ b/novnc.spec @@ -40,6 +40,7 @@ Summary: Proxy server for noVNC traffic over Websockets Requires: novnc Requires: numpy Requires: python-websockify +Requires: python-nova %if %{with_systemd} Requires(post): systemd-units
novnc-0.3-8.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/novnc-0.3-8.fc17
I notice this pulls in numpy, which in turn brings in a whole bunch of things like atlas and gfortran. It looks like the code falls back to a slower implementation if numpy isn't available. Do we want to make it a hard requirement?
(Also, correct me if I'm wrong, but the requirement is actually in python-websockify, not here at all? Except json2graph.py, which I don't think is packaged?)
json2graph is not packaged. We should drop the numpy dependancy.
novnc-0.3-9.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/novnc-0.3-9.fc17
novnc-0.3-10.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/novnc-0.3-10.fc17
novnc-0.3-10.fc17 has been pushed to the Fedora 17 stable repository.
Unretiring novnc in EPEL6 https://lists.fedoraproject.org/pipermail/devel/2015-January/206230.html Package Change Request ====================== Package Name: novnc New Branches: el6 Owners: apevec
Complete.