Bug 822187 - Review Request: novnc - websockets based VNC client and simple server
Summary: Review Request: novnc - websockets based VNC client and simple server
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Pádraig Brady
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 801685
TreeView+ depends on / blocked
Reported: 2012-05-16 15:09 UTC by Adam Young
Modified: 2015-01-09 13:05 UTC (History)
13 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2012-06-12 15:00:27 UTC
Type: ---
p: fedora-review+

Attachments (Terms of Use)
spec adjustments (3.26 KB, patch)
2012-06-12 01:25 UTC, Pádraig Brady
no flags Details | Diff

Description Adam Young 2012-05-16 15:09:14 UTC
Spec URL: http://admiyo.fedorapeople.org/noVNC/novnc.spec
SRPM URL: http://admiyo.fedorapeople.org/noVNC/novnc-0.3-1.f17ayoung.src.rpm
Description: - websockets based vnc client and simple server

Comment 1 sleepsonthefloor 2012-05-16 16:55:32 UTC
Hey Adam,

I see that you are using an index.html file as a work-around to stop directory browsing.  You may also consider adding such a file to public subdirectories (images, include, include/web-socket-js).

To make nova-novncproxy work out-of-the-box you could patch the --web default value to /usr/share/novnc: https://github.com/kanaka/noVNC/blob/master/utils/nova-novncproxy#L58

Comment 2 Pádraig Brady 2012-05-18 14:31:38 UTC

novnc.noarch: W: summary-ended-with-dot C VNC client using HTML5 (Web Sockets, Canvas) with encryption (wss://) support.
novnc.noarch: E: description-line-too-long C Websocket implementation of VNC client,  with simple python-websockify starter script
novnc.noarch: W: incoherent-version-in-changelog 0.1.0-2 ['0.3-1.fc15', '0.3-1']
novnc.noarch: W: invalid-license GPL V3
novnc.noarch: W: no-manual-page-for-binary novnc_server

novnc-nova-proxy.noarch: W: spelling-error Summary(en_US) Openstack -> OpenStack
novnc-nova-proxy.noarch: W: spelling-error %description -l en_US Openstack -> OpenStack
novnc-nova-proxy.noarch: W: tag-in-description C Requires:
novnc-nova-proxy.noarch: W: tag-in-description C Requires:
novnc-nova-proxy.noarch: W: invalid-license GPL V3
novnc-nova-proxy.noarch: W: no-documentation
novnc-nova-proxy.noarch: W: no-manual-page-for-binary nova-novncproxy

Comment 3 Jose Castro Leon 2012-05-31 11:51:47 UTC
I installed the package in a cloud controller and it seems that there is a issue when using websockify rpm. It fails to start because a missing dependency. I found that needs wsproxy python module. Solved if you modify it like this

diff /usr/bin/nova-novncproxy.nopatch /usr/bin/nova-novncproxy
< import wsproxy
> import websockify as wsproxy

BTW in the RPM, I think that it need a way to start this service as it is on openstack in other distributions

Description=OpenStack Nova NoVNC Proxy Server
After=syslog.target network.target

ExecStart=/usr/bin/nova-novncproxy --flagfile=/etc/nova/nova.conf --web /usr/share/novnc/


Comment 5 Adam Young 2012-06-11 18:25:51 UTC
Supports systemd for F17+ and RHEL7+  adn System V otherwise


Comment 6 Adam Young 2012-06-12 01:12:37 UTC
Minor update. This fixes an rpmlint error and also makes a correction to the SystemV init script


Comment 7 Pádraig Brady 2012-06-12 01:25:16 UTC
Created attachment 591056 [details]
spec adjustments

I've made some adjustments to the package as per the attached patch.
The following are rpmlint clean and build in mock:


Comment 8 Pádraig Brady 2012-06-12 01:54:22 UTC
Merging in Adam's overlapping changes:


Comment 9 Pádraig Brady 2012-06-12 01:57:10 UTC
New Package SCM Request
Package Name: novnc
Short Description: VNC client using HTML5 (Web Sockets, Canvas) with encryption support
Owners: pbrady nsantos
Branches: f16 f17 el6

Comment 10 Gwyn Ciesla 2012-06-12 13:18:15 UTC
Summary and SCM request package nams don't match, please correct.

Comment 11 Pádraig Brady 2012-06-12 13:36:19 UTC
sorry I don't understand comment 10?

Comment 12 Gwyn Ciesla 2012-06-12 13:42:51 UTC
Summary has noVNC, SCM request is novnc, package names are case-sensitive.

Comment 13 Pádraig Brady 2012-06-12 13:50:03 UTC
Ah the bug summary is significant here.
I've synced both. Cheers.

New Package SCM Request
Package Name: novnc
Short Description: websockets based VNC client and simple server
Owners: pbrady nsantos
Branches: f16 f17 el6

Comment 14 Gwyn Ciesla 2012-06-12 13:53:18 UTC
Git done (by process-git-requests).

Excellent, thanks very much!

Comment 15 Pádraig Brady 2012-06-12 15:00:27 UTC
thanks guys!

Comment 16 Alan Pevec 2012-06-13 09:56:50 UTC
openstack-nova-novncproxy is missing dependency, nova-novncproxy imports from nova:
--- a/novnc.spec
+++ b/novnc.spec
@@ -40,6 +40,7 @@ Summary:        Proxy server for noVNC traffic over Websockets
 Requires:       novnc
 Requires:       numpy
 Requires:       python-websockify
+Requires:       python-nova
 %if %{with_systemd}
 Requires(post): systemd-units

Comment 17 Fedora Update System 2012-06-13 14:41:12 UTC
novnc-0.3-8.fc17 has been submitted as an update for Fedora 17.

Comment 18 Matthew Miller 2012-06-13 19:01:24 UTC
I notice this pulls in numpy, which in turn brings in a whole bunch of things like atlas and gfortran.

It looks like the code falls back to a slower implementation if numpy isn't available. Do we want to make it a hard requirement?

Comment 19 Matthew Miller 2012-06-13 19:06:36 UTC
(Also, correct me if I'm wrong, but the requirement is actually in python-websockify, not here at all? Except json2graph.py, which I don't think is packaged?)

Comment 20 Adam Young 2012-06-13 19:14:19 UTC
json2graph is not packaged.  We should drop the numpy dependancy.

Comment 21 Fedora Update System 2012-06-14 15:19:18 UTC
novnc-0.3-9.fc17 has been submitted as an update for Fedora 17.

Comment 22 Fedora Update System 2012-06-15 09:36:20 UTC
novnc-0.3-10.fc17 has been submitted as an update for Fedora 17.

Comment 23 Fedora Update System 2012-06-26 00:32:59 UTC
novnc-0.3-10.fc17 has been pushed to the Fedora 17 stable repository.

Comment 24 Alan Pevec (Fedora) 2015-01-09 11:33:56 UTC
Unretiring novnc in EPEL6

Package Change Request
Package Name: novnc
New Branches: el6
Owners: apevec

Comment 25 Gwyn Ciesla 2015-01-09 13:05:16 UTC

Note You need to log in before you can comment on or make changes to this bug.