Created attachment 585789 [details] Patch that appears to fix the issue Description of problem: rhnpush fails with a global name h not defined error - line 506 of /usr/share/rhn/rhnpush/uploadLib.py Version-Release number of selected component (if applicable): spacewalk 1.7 rhnpush-5.5.42-1.el6.noarch How reproducible: Everytime Steps to Reproduce: 1. Obtain RPM from somewhere 2. rhnpush to the spacewalk server 3. observe error Actual results: Get the error: global name h not defined Expected results: RPM package uploaded Additional info: I could have sworn this worked a couple of weeks ago - but I may be imagining it.... Locally editing /usr/share/rhn/rhnpush/uploadLib.py seems then to allow stuff to work (the channel page still has arch so I assume this change works...) - patch attached.
The issue is caused by 4ed2374ccbc7f7dedb8fe6eaf7322700f06a4ca7 when the h = get_header(None, f.fileno(), source) was replaced with a_pkg = package_from_filename(filename) I assume the proper fix is diff --git a/client/tools/rhnpush/uploadLib.py b/client/tools/rhnpush/uploadLib.py index 2d0ed35..aae1604 100644 --- a/client/tools/rhnpush/uploadLib.py +++ b/client/tools/rhnpush/uploadLib.py @@ -503,7 +503,7 @@ class UploadClass: if source: lh.append('src') else: - lh.append(h['arch']) + lh.append(a_pkg.header['arch']) # Build the header hash to be sent hash = { 'header' : Binary(a_pkg.header.unload()),
Thanks for the correction Jan - that works on my testing here.
Fixed in Spacewalk master, 03a1c48d59401856b2ffb4b2a96c4d51375b2cf4.
Moving ON_QA. Packages that address this bugzilla should now be available in yum repos at http://yum.spacewalkproject.org/nightly/
Spacewalk 1.8 has been released: https://fedorahosted.org/spacewalk/wiki/ReleaseNotes18