Bug 824777 - rhnpush fails with NameError: global name 'h' is not defined
rhnpush fails with NameError: global name 'h' is not defined
Product: Red Hat Satellite 5
Classification: Red Hat
Component: Server (Show other bugs)
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Jan Pazdziora
Dimitar Yordanov
Depends On:
Blocks: sat550-blockers 855837
  Show dependency treegraph
Reported: 2012-05-24 04:59 EDT by Jan Pazdziora
Modified: 2012-10-15 05:06 EDT (History)
4 users (show)

See Also:
Fixed In Version: rhnpush-5.5.42-3
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 823491
Last Closed: 2012-10-15 05:06:43 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Jan Pazdziora 2012-05-24 04:59:19 EDT
+++ This bug was initially created as a clone of Bug #823491 +++

Description of problem:
rhnpush fails with a global name h not defined error - line 506 of /usr/share/rhn/rhnpush/uploadLib.py

Version-Release number of selected component (if applicable):
spacewalk 1.7 

How reproducible:

Steps to Reproduce:
1. Obtain RPM from somewhere
2. rhnpush to the spacewalk server
3. observe error
Actual results:
Get the error: global name h not defined 

Expected results:
RPM package uploaded

Additional info:
I could have sworn this worked a couple of weeks ago - but I may be imagining it....

Locally editing /usr/share/rhn/rhnpush/uploadLib.py seems then to allow stuff to work (the channel page still has arch so I assume this change works...) - patch attached.
Comment 1 Jan Pazdziora 2012-05-24 05:00:08 EDT
The issue is caused by 4ed2374ccbc7f7dedb8fe6eaf7322700f06a4ca7 when the

h = get_header(None, f.fileno(), source)

was replaced with

a_pkg = package_from_filename(filename)

I assume the proper fix is

diff --git a/client/tools/rhnpush/uploadLib.py b/client/tools/rhnpush/uploadLib.py
index 2d0ed35..aae1604 100644
--- a/client/tools/rhnpush/uploadLib.py
+++ b/client/tools/rhnpush/uploadLib.py
@@ -503,7 +503,7 @@ class UploadClass:
         if source:
-            lh.append(h['arch'])
+            lh.append(a_pkg.header['arch'])
         # Build the header hash to be sent
         hash = { 'header' : Binary(a_pkg.header.unload()),

Fixed in Spacewalk master, 03a1c48d59401856b2ffb4b2a96c4d51375b2cf4.
Comment 4 Dimitar Yordanov 2012-06-04 04:45:45 EDT
Comment 9 errata-xmlrpc 2012-10-15 05:06:43 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.