Spec URL: http://elmarco.fedorapeople.org/mingw-libusb1.spec SRPM URL: http://elmarco.fedorapeople.org/mingw-libusb1-1.0.9-1.fc17.src.rpm Description: This package provides a way for applications to access USB devices. Fedora Account System Username: elmarco
Hi, I'll review this, but first can you please re-spin the package to be based on libusbx? libusbx is a fork of libusb by most of the libusb developers for various reasons. The developers behind the fork include yours truly, as well as the windows maintainer, making libusbx a better starting point for a mingw package. Notice that the regular Fedora libusb package is also moving over to libusbx, see bug 823886 for the Rename Review Request for that, including the new specfile for a libusbx based Fedora libusb package. Regards, Hans
Spec URL: http://elmarco.fedorapeople.org/mingw-libusbx.spec SRPM URL: http://elmarco.fedorapeople.org/mingw-libusbx-1.0.9-1.fc17.src.rpm Description: This package provides a way for applications to access USB devices. Fedora Account System Username: elmarco
Full review done: Good: -------- - rpmlint checks return: mingw32-libusbx-debuginfo.noarch: E: debuginfo-without-sources mingw32-libusbx-static.noarch: W: no-documentation mingw64-libusbx-debuginfo.noarch: E: debuginfo-without-sources mingw64-libusbx-static.noarch: W: no-documentation ^^These are all expected for mingw packages, so no problem here ^^ - package meets naming guidelines - package meets packaging guidelines - license (LGPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - locales properly handled - not relocatable - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Should fix: --------------- - rpmlint checks return: mingw-libusbx.src: W: strange-permission libusbx-1.0.11.tar.bz2 0640L Please fix before import - rpmlint checks return: mingw32-libusbx.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw32-libusbx-1.0.11/ChangeLog mingw64-libusbx.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw64-libusbx-1.0.11/ChangeLog The ChangeLog file is not that interesting anyways, it says: "For the latest change log, please visit: http://libusbx.git.sourceforge.net/git/gitweb.cgi?p=libusbx/libusbx;a=log" So I suggest just dropping it. - There is a "rm -rf $RPM_BUILD_ROOT" in your %install, this is not needed with modern rpm versions, and should not be there unless you also manually specify a buildroot and have a manual %clean section - Does not own all directories that it creates! The mingw32-* and mingw64-* packages install files under /usr/i686-w64-mingw32 resp /usr/x86_64-w64-mingw32 And subdirs under these dirs which no packages own, therefor the mingw32-* and mingw64-* packages should have a Requires on mingw32-filesystem resp mingw64-filesystem. This seems to be an oversight in the mingw packaging guidelines which are missing these requires in their example specfile too. Can you please discuss this with the other mingw packaging folks? No blockers -> Approved!
(In reply to comment #3) > - Does not own all directories that it creates! > The mingw32-* and mingw64-* packages install files under > /usr/i686-w64-mingw32 resp /usr/x86_64-w64-mingw32 And subdirs under these > dirs which no packages own, therefor the mingw32-* and mingw64-* packages > should have a Requires on mingw32-filesystem resp mingw64-filesystem. This > seems to be an oversight in the mingw packaging guidelines which are missing > these requires in their example specfile too. Can you please discuss this > with the other mingw packaging folks? Hi Hans, The Requires tags for mingw32-filesystem and mingw64-filesystem are added automatically by the %{?mingw_package_header} macro. This macro overrides the default RPM find requires script with /usr/lib/rpm/mingw-find-requires.sh which automatically adds the proper requires tags for mingw packages
New Package SCM Request ======================= Package Name: mingw-libusbx Short Description: MinGW library which allows userspace access to USB devices Owners: elmarco epienbro hdegoede Branches: f17 InitialCC:
Git done (by process-git-requests). Corrected Hans' FAS username.
mingw-libusbx-1.0.11-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mingw-libusbx-1.0.11-1.fc17
mingw-libusbx-1.0.11-1.fc17 has been pushed to the Fedora 17 testing repository.
mingw-libusbx-1.0.12-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mingw-libusbx-1.0.12-1.fc17
mingw-libusbx-1.0.12-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mingw-libusbx-1.0.12-2.fc18
mingw-libusbx-1.0.12-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mingw-libusbx-1.0.12-2.fc19
mingw-libusbx-1.0.12-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
mingw-libusbx-1.0.12-2.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
mingw-libusbx-1.0.12-2.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.