RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 828023 - [libvirt] Setting numa parameters causes guest xml error
Summary: [libvirt] Setting numa parameters causes guest xml error
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt
Version: 6.3
Hardware: x86_64
OS: Linux
high
high
Target Milestone: rc
: ---
Assignee: Osier Yang
QA Contact: Virtualization Bugs
URL:
Whiteboard:
: 838049 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-06-04 03:03 UTC by zhe peng
Modified: 2013-02-21 07:16 UTC (History)
9 users (show)

Fixed In Version: libvirt-0.10.0-1.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-02-21 07:16:14 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2013:0276 0 normal SHIPPED_LIVE Moderate: libvirt security, bug fix, and enhancement update 2013-02-20 21:18:26 UTC

Description zhe peng 2012-06-04 03:03:20 UTC
Description of problem:
'virDomain{G, S}etNumaParameters' APIs generate wrong guest xml 

Version-Release number of selected component (if applicable):
libvirt-0.9.10-21.el6.x86_64
rhel6.3 rc build

How reproducible:
always

Steps to Reproduce:
1.# python
Python 2.6.6 (r266:84292, May  1 2012, 13:52:17)
[GCC 4.4.6 20110731 (Red Hat 4.4.6-3)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import libvirt
>>> conn = libvirt.open(None)
>>> dom = conn.lookupByName("rhel6.3rc")
>>> dom.numaParameters(0)
{'numa_nodeset': '1', 'numa_mode': 1}
>>> param = {'numa_nodeset': '1', 'numa_mode': 1}
>>> dom.setNumaParameters(param, 2)
0

# destroy and start the domain in another console




Actual results:
the guest can't restart
# virsh start rhel6.3rc
error: Failed to start domain rhel6.3rc
error: (domain_definition):8: error parsing attribute name
    <memory mode='preferred'   </numatune>
-------------------------------^

#virsh dumpxml rhel6.3rc
.............
 <vcpu placement='static'>1</vcpu>
  <numatune>
    <memory mode='preferred'   </numatune>
.............


Expected results:
the guest can start without error

Additional info:
use command :
#virsh numatune rhel6.3rcqcow2 --nodeset 1 --config
will get the same error.

refer bug :https://bugzilla.redhat.com/show_bug.cgi?id=771591 , this bug verify in libvirt-0.9.10-1,
i can't reproduce this on
libvirt-0.9.10-16.el6.x86_64
so it's a regression bug.

Comment 2 Alex Jia 2012-06-04 03:55:37 UTC
This problem hasn't any relationship with libvirt client such as virsh or python binding, it's a underlying implementatin issue, which probaly is introduced by upstream commit 8d26a7f or 97010eb1, however, I haven't check it further.

Osier, could you help confirm this? thanks.

Comment 10 Dave Allan 2012-07-06 14:47:11 UTC
*** Bug 838049 has been marked as a duplicate of this bug. ***

Comment 11 Osier Yang 2012-07-23 14:18:20 UTC
v2 posted upstream. https://www.redhat.com/archives/libvir-list/2012-June/msg01018.html

Comment 12 Osier Yang 2012-08-29 01:50:04 UTC
commit 6fd1708fad221956c1ca7de023a7babfb100a4dc
Author: Osier Yang <jyang>
Date:   Tue Aug 28 20:13:31 2012 +0800

    qemu: Set placement when setting numa parameters
    
    To keep the internal data structure consistent.

Comment 14 Wayne Sun 2012-08-31 08:11:56 UTC
pkgs:
libvirt-0.10.0-1.el6.x86_64
qemu-kvm-rhev-0.12.1.2-2.297.el6_3.x86_64
kernel-2.6.32-279.el6.x86_64

steps:
1.
# virsh start libvirt_test_api
Domain libvirt_test_api started

# virsh list --all
 Id    Name                           State
----------------------------------------------------
 4     libvirt_test_api               running

2. numatune
# virsh numatune libvirt_test_api --nodeset 2 --config


success, so no xml problem now.

3. destroy domain 
# virsh destroy libvirt_test_api
Domain libvirt_test_api destroyed

4. start domain

# virsh start libvirt_test_api
Domain libvirt_test_api started

# virsh dumpxml libvirt_test_api
...
  <numatune>
    <memory mode='strict' nodeset='2'/>
  </numatune>
...


5. check with python
# python
Python 2.6.6 (r266:84292, May  1 2012, 13:52:17) 
[GCC 4.4.6 20110731 (Red Hat 4.4.6-3)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import libvirt
>>> conn = libvirt.open(None)
>>> dom = conn.lookupByName("libvirt_test_api")
>>> dom.numaParameters(0)
{'numa_nodeset': '2', 'numa_mode': 0}
>>> param = {'numa_nodeset': '4', 'numa_mode': 1}
>>> dom.setNumaParameters(param, 2)
0
>>>

# virsh destroy libvirt_test_api
Domain libvirt_test_api destroyed

# virsh start libvirt_test_api
Domain libvirt_test_api started

# virsh dumpxml libvirt_test_api
...
  <numatune>
    <memory mode='preferred' nodeset='4'/>
  </numatune>
...

Comment 15 errata-xmlrpc 2013-02-21 07:16:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0276.html


Note You need to log in before you can comment on or make changes to this bug.