Bug 82850 - kernel contains incomplete swsusp patch
kernel contains incomplete swsusp patch
Product: Red Hat Linux
Classification: Retired
Component: kernel (Show other bugs)
i386 Linux
medium Severity medium
: ---
: ---
Assigned To: Arjan van de Ven
Brian Brock
Depends On:
  Show dependency treegraph
Reported: 2003-01-27 13:06 EST by Dan Berger
Modified: 2007-04-18 12:50 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2003-06-05 10:21:13 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Dan Berger 2003-01-27 13:06:04 EST
From Bugzilla Helper:
User-Agent: Mozilla/5.0 Galeon/1.2.7 (X11; Linux i686; U;) Gecko/20021203

Description of problem:
The swsusp patch that's been applied to the RH kernel sources is incomplete, and
causes a build failure if CONFIG_SOFTWARE_SUSPEND is enabled.

Also - since the patch has already been (badly) applied, it's not possible
(easy, anyway) to re-apply it correctly.  Specifically, Drivers/ide/ide-disk.c
hasn't been patched with the needed suspend/resume functions.

$ uname -a
Linux walkabout 2.4.18-19.8.0 #1 Thu Dec 12 05:39:29 EST 2002 i686 i686 i386

$ rpm -q kernel-source

$ grep SOFTWARE_SUSPEND /usr/src/linux-2.4/.config

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. enable CONFIG_SOFTWARE_SUSPEND in your kernel config 
2. attempt to build the kernel
3. observe the build (link) failure

Additional info:
Comment 1 Dan Berger 2003-01-27 13:58:49 EST
I should probably also mention that I generated my config by copying
configs/kernel-2.4.18-i686.config, and only changed that particular parameter

It's also interesting to note that taking the shipped config, running make
xconfig, and immediately saving the configuration (making no changes) results in
a very different config file.
Comment 2 Dan Berger 2003-01-27 14:39:50 EST
it looks like the patch is being applied as part of patch-2.4.19-rc1-ac1(.bz2) -
and that it's complete in that patch - I'm not yet sure where/how it's getting
snarfed, but I'll post anything I find here.
Comment 3 Dan Berger 2003-01-27 14:45:02 EST
got it - looks like it's being unapplied by linux-2.4.18-idebackport.patch -
which was diff'ed against the CVS HEAD.
Comment 4 Alan Cox 2003-06-05 10:21:13 EDT
We don't plan to do anything with software suspend support at this time.
Comment 5 Dan Berger 2003-06-05 10:53:03 EDT
I don't suppose you could remove the partially applied patch so folks who want
to do something with software suspend have a fighting chance?
Comment 6 Arjan van de Ven 2003-06-05 11:11:23 EDT
current errata kernels no longer have it
Comment 7 Dan Berger 2003-06-05 12:13:19 EDT
excellent, thanks for the info.

Note You need to log in before you can comment on or make changes to this bug.