Bug 830475 - trailing whitespace not stripped from SSH key descriptions
Summary: trailing whitespace not stripped from SSH key descriptions
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: web UI
Version: 0.8
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dan Callaghan
QA Contact:
URL:
Whiteboard:
: 835798 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-06-10 00:43 UTC by Dan Callaghan
Modified: 2019-05-22 13:42 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-07-20 00:39:16 UTC
Embargoed:


Attachments (Terms of Use)

Description Dan Callaghan 2012-06-10 00:43:21 UTC
Version-Release number of selected component (if applicable):

Beaker 0.8.2


Steps to Reproduce:
1. Paste your SSH public key on the prefs page, including a trailing newline
2. Run a job


Actual results:

SSH key description contains the trailing newline. As a result, the kickstart will have something like this:

echo ssh-rsa AAAA... dcallagh@galangal
 >> /root/.ssh/authorized_keys

which doesn't work.


Expected results:

Trailing whitespace is stripped from the key description. In fact, the entire SSH key should probably only be allowed to be one line (containing no newlines).

Also the kickstart snippet should wrap the public key in '' and/or escape all shell metacharacters.

Comment 1 Steven Lawrance 2012-06-27 07:28:05 UTC
*** Bug 835798 has been marked as a duplicate of this bug. ***

Comment 2 Dan Callaghan 2012-07-05 06:32:33 UTC
On Gerrit: http://gerrit.beaker-project.org/1178

Comment 6 Raymond Mancy 2012-07-18 04:19:26 UTC
Verified warning on newline in pubkey; whitespace tripped in DB; and quoted in ks

Comment 7 Dan Callaghan 2012-07-20 00:39:16 UTC
Beaker 0.9.1 has been released.


Note You need to log in before you can comment on or make changes to this bug.