Bug 836051 - Centralise management of key shortcuts in Zanata
Summary: Centralise management of key shortcuts in Zanata
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Zanata
Classification: Retired
Component: Component-UI
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 1.7
Assignee: David Mason
QA Contact: Ding-Yi Chen
URL:
Whiteboard:
: 834976 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-06-28 00:36 UTC by Alex Eng
Modified: 2012-09-13 00:16 UTC (History)
2 users (show)

Fixed In Version: 1.6.2-SNAPSHOT (20120711-0001)
Doc Type: Bug Fix
Doc Text:
Cause: Key shortcuts for the editor were not shown in the key shortcut summary panel. Key shortcut summary panel could not be discovered through the UI. Consequence: Editor key shortcuts could not be discovered through the UI. Fix: Integrated editor key shortcuts with the key shortcut summary panel and added a clickable icon to show the key shortcut summary panel. Result: All key shortcuts can be discovered through the UI.
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-09-11 05:11:20 UTC
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 786630 0 low CLOSED Shortcut Alt+G causes editor to lose focus 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 836142 0 unspecified CLOSED Shortcuts for highlighting text is instead inserting TM result (Alt+Shift+keypad conflict) [1.7] 2021-02-22 00:41:40 UTC

Internal Links: 786630 836142

Description Alex Eng 2012-06-28 00:36:06 UTC 
Centralise management of key shortcuts:
Editor, and navigation shortcut handler
Comment 1 Alex Eng 2012-07-03 06:08:18 UTC 
*** Bug 834976 has been marked as a duplicate of this bug. ***
Comment 2 Alex Eng 2012-07-03 22:36:22 UTC 
Implemented in 1.7

See
https://github.com/zanata/zanata/commit/b2171eb39499aca60e19be217b6c80b200b775e3
https://github.com/zanata/zanata/commit/55261c54418107cae433964b30609fb2c92db19c
https://github.com/zanata/zanata/commit/d72db23b7f18900c1dc428f07192044cbe5c6768
https://github.com/zanata/zanata/commit/9754c04ccec9377db7db60ec72f29047e5487859
https://github.com/zanata/zanata/commit/7af63dff84915f3c80cc690650ce49105e145363
https://github.com/zanata/zanata/commit/7a8e4f3a5a50c26c1baa535289ffae8c12361b72
https://github.com/zanata/zanata/commit/2ac162ce5a6cebe51ca1bc04745ce4058cce072c
https://github.com/zanata/zanata/commit/29b6005154923fe627e1f7069a3d8053f2dd8b2a
Comment 3 David Mason 2012-07-10 04:25:09 UTC 
Simplified code for key shortcut and non-shortcut listener registration. See:
https://github.com/zanata/zanata/compare/0f276b09d02b4f8148879bd1e4c620edaccd990a...9627145ed63ab8392f7765f3222245de6494f71e
https://github.com/zanata/zanata/commit/d1fdda526861a64880d0b505d0974949816e142a
https://github.com/zanata/zanata/compare/d1fdda526861a64880d0b505d0974949816e142a...301f0edc69240843e33a517a7bfb2510369044b5
https://github.com/zanata/zanata/commit/c243afada98bcb1bc3f17c2baf4681be5e1f0a4e

Updated to allow multiple key combinations per shortcut action. See:
https://github.com/zanata/zanata/commit/2f557c6d1403ee59ab2d2859768e7ad7da6cabe4

Added clickable icon to show key shortcut summary. See:
https://github.com/zanata/zanata/compare/9d381dac98990ee6f04c62a967380c5d95065920...dd9688381e69841c9b14ed200adca099f8372331
Comment 4 Ding-Yi Chen 2012-07-11 03:47:32 UTC 
VERIFIED with Zanata version 1.6.2-SNAPSHOT (20120711-0001)
Note You need to log in before you can comment on or make changes to this bug.