Spec URL: http://threebean.org/rpm/pkgwat.spec SRPM URL: http://threebean.org/rpm/pkgwat-0.3-1.fc17.src.rpm Description: Pronounced "package WAT", pkgwat is a fast CLI tool for querying the fedora packages webapp. https://apps.fedoraproject.org/packages/ You can make its search even better by helping us tag packages. https://apps.fedoraproject.org/tagger Fedora Account System Username: ralph --- ~/rpmbuild ยป rpmlint {SPECS,SRPMS}/pkgwat* pkgwat.src: W: spelling-error Summary(en_US) webapp -> web app, web-app, weapon pkgwat.src: W: spelling-error %description -l en_US webapp -> web app, web-app, weapon 1 packages and 1 specfiles checked; 0 errors, 2 warnings.
Spec URL: http://threebean.org/rpm/pkgwat.spec SRPM URL: http://threebean.org/rpm/pkgwat-0.3-2.fc17.src.rpm New release that manually disables python3 support until python3-cliff is available. I'd like to get this out the door with basic python-2.7 support sooner than later.
I will review this package
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: EXTRA Spec file according to URL is the same as in SRPM. [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [-]: MUST Package contains desktop file if it is a GUI application. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Fully versioned dependency in subpackages, if present. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* UNKNOWN" For detailed output of licensecheck see file: /home/lmacken/code/github.com/FedoraReview/837689-pkgwat/licensecheck.txt [x]: MUST License file installed when any subpackage combination is installed. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [!]: MUST Package installs properly. Note: Installation errors (see attachment) [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: SHOULD Package should compile and build into binary rpms on all supported architectures. [!]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Rpmlint ------- Checking: pkgwat-0.3-2.fc17.src.rpm pkgwat-0.3-2.fc17.noarch.rpm pkgwat.src: W: spelling-error Summary(en_US) webapp -> web app, web-app, weapon pkgwat.src: W: spelling-error %description -l en_US webapp -> web app, web-app, weapon pkgwat.noarch: W: spelling-error Summary(en_US) webapp -> web app, web-app, weapon pkgwat.noarch: W: spelling-error %description -l en_US webapp -> web app, web-app, weapon pkgwat.noarch: W: dangling-relative-symlink /usr/share/doc/pkgwat-0.3/LICENSE lgpl-2.1.txt pkgwat.noarch: W: no-manual-page-for-binary pkgwat 2 packages and 0 specfiles checked; 0 errors, 6 warnings. Requires -------- pkgwat-0.3-2.fc17.noarch.rpm (rpmlib, GLIBC filtered): /usr/bin/python python(abi) = 2.7 python-cliff python-pkgwat-api Provides -------- pkgwat-0.3-2.fc17.noarch.rpm: pkgwat = 0.3-2.fc17 MD5-sum check ------------- /home/lmacken/code/github.com/FedoraReview/837689-pkgwat/upstream/pkgwat.cli-0.3.tar.gz : MD5SUM this package : 91d24db4e925f9f15d7ef60607238a1c MD5SUM upstream package : 91d24db4e925f9f15d7ef60607238a1c Generated by fedora-review 0.2.0git External plugins:
I'm almost ready to approve this package, however, I can't seem to get it fully working locally: % pkgwat --help usage: pkgwat [--version] [-v] [-q] [-h] [--debug] CLI tool for querying the fedora packages webapp optional arguments: --version show program's version number and exit -v, --verbose Increase verbosity of output. Can be repeated. -q, --quiet suppress output except warnings and errors -h, --help show this help message and exit --debug show tracebacks on errors Commands: No handlers could be found for logger "cliff.display" Could not instantiate EntryPoint.parse('bugs = pkgwat.cli.subcommands:Bugs'): 'NoneType' object has no attribute 'debug' Could not instantiate EntryPoint.parse('builds = pkgwat.cli.subcommands:Builds'): 'NoneType' object has no attribute 'debug' Could not instantiate EntryPoint.parse('changelog = pkgwat.cli.subcommands:Changelog'): 'NoneType' object has no attribute 'debug' contents Show contents of a package help print detailed help for another command icon Show the icon for a package Could not instantiate EntryPoint.parse('info = pkgwat.cli.subcommands:Info'): 'NoneType' object has no attribute 'debug' Could not instantiate EntryPoint.parse('releases = pkgwat.cli.subcommands:Releases'): 'NoneType' object has no attribute 'debug' Could not instantiate EntryPoint.parse('search = pkgwat.cli.subcommands:Search'): 'NoneType' object has no attribute 'debug' Could not instantiate EntryPoint.parse('updates = pkgwat.cli.subcommands:Updates'): 'NoneType' object has no attribute 'debug'
% pkgwat updates python-pkgwat-api No module named xlrd 'module' object has no attribute 'packages' 'module' object has no attribute 'packages' Starting new HTTPS connection (1): apps.fedoraproject.org PrettyTable instance has no attribute 'align'
Seems this is due to a bug in python-tablib. I've just put out a new update of that package which should fix this. python-tablib-0.9.11.20120702git752443f-5
After upgrading tablib, I'm no longer getting those 'NoneType object has no attribute 'debug', but I'm still getting those "PrettyTable instance has no attribute 'align'" errors when trying to do anything.
Well, this looks like a version mismatch with python-prettytable. We need the latest 0.6 there https://bugzilla.redhat.com/show_bug.cgi?id=837087 I'm setting that ticket as a blocker here.
Well, python-prettytable-0.6 is in F18 and looks like it will never be in F17 due to some conflicts with the openstack stack. I just tried and the rpm builds, installs, and works in F18. Luke, would you mind picking up the review?
Looks good! APPROVED Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [-]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package -n python3-pkgwat [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [-]: Large documentation files are in a -doc subpackage, if required. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/lmacken/837689-pkgwat/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. Python: [x]: Package contains BR: python2-devel or python3-devel ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX / PatchY prefixed with %{name}. [x]: SourceX is a working URL. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: pkgwat-0.3-2.fc18.src.rpm pkgwat-0.3-2.fc18.noarch.rpm pkgwat.src: W: spelling-error Summary(en_US) webapp -> web app, web-app, weapon pkgwat.src: W: spelling-error %description -l en_US webapp -> web app, web-app, weapon pkgwat.noarch: W: spelling-error Summary(en_US) webapp -> web app, web-app, weapon pkgwat.noarch: W: spelling-error %description -l en_US webapp -> web app, web-app, weapon pkgwat.noarch: W: dangling-relative-symlink /usr/share/doc/pkgwat-0.3/LICENSE lgpl-2.1.txt pkgwat.noarch: W: no-manual-page-for-binary pkgwat 2 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint pkgwat pkgwat.noarch: W: spelling-error Summary(en_US) webapp -> web app, web-app, weapon pkgwat.noarch: W: spelling-error %description -l en_US webapp -> web app, web-app, weapon pkgwat.noarch: W: invalid-url URL: http://pypi.python.org/pypi/pkgwat.cli <urlopen error [Errno -2] Name or service not known> pkgwat.noarch: W: dangling-relative-symlink /usr/share/doc/pkgwat-0.3/LICENSE lgpl-2.1.txt pkgwat.noarch: W: no-manual-page-for-binary pkgwat 1 packages and 0 specfiles checked; 0 errors, 5 warnings. # echo 'rpmlint-done:' Requires -------- pkgwat-0.3-2.fc18.noarch.rpm (rpmlib, GLIBC filtered): /usr/bin/python python(abi) = 2.7 python-cliff python-pkgwat-api Provides -------- pkgwat-0.3-2.fc18.noarch.rpm: pkgwat = 0.3-2.fc18 MD5-sum check ------------- http://pypi.python.org/packages/source/p/pkgwat.cli/pkgwat.cli-0.3.tar.gz : CHECKSUM(SHA256) this package : d24a4f24cb5c82a69d88455c619f83046152aa4bfe9b7dee1c0eecd8774b51f2 CHECKSUM(SHA256) upstream package : d24a4f24cb5c82a69d88455c619f83046152aa4bfe9b7dee1c0eecd8774b51f2 Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-18-x86_64 Command line :/usr/bin/fedora-review -b 837689
New Package SCM Request ======================= Package Name: pkgwat Short Description: CLI tool for querying the fedora packages webapp Owners: ralph Branches: f18 InitialCC:
Git done (by process-git-requests).
Update requested -> https://admin.fedoraproject.org/updates/pkgwat
Package Change Request ====================== Package Name: pkgwat New Branches: el6 epel7 Owners: ralph