Spec URL: http://madsa.fedorapeople.org/packages/python26-requests/python26-requests.spec SRPM URL: http://madsa.fedorapeople.org/packages/python26-requests/python26-requests-0.13.1-1.el5.centos.src.rpm Description: Most existing Python modules for sending HTTP requests are extremely verbose and cumbersome. Python’s built-in urllib2 module provides most of the HTTP capabilities you should need, but the API is thoroughly broken. This library is designed to make HTTP requests easy for developers. Fedora Account System Username: madsa This package is meant to be exclusively for the EPEL5 Python 2.6 stack.
Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4219356 Also, I need a sponsor since this is my first package.
I'm a sponsor, and will have a look. Can have you done any practice package reviews yet?
Hi Jon, thanks for taking a look. No practice reviews yet, but I intend to do some very soon. Should I comment on this issue with links to my practice reviews when they're completed?
That would be perfect, thanks. 2 or 3 should be sufficient.
- rpmlint checks return: Clean, except for zero-length requests/async.py. Probably ignorable. - package meets naming guidelines - package meets packaging guidelines - license ( ISC and MIT ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Running a mock build to test BR, but I think that's fine, from what I can tell. Overall very good.
My practice reviews: https://bugzilla.redhat.com/show_bug.cgi?id=835275 https://bugzilla.redhat.com/show_bug.cgi?id=836362
Not bad. I made one comment, but otherwise they look good. I've sponsored you in the Packager group. Welcome aboard, use your powers for good, etc. :) You can also now complete those two reviews officially. APPROVED. If you like, you can add me as a comaintainer when you submit your SCM request. If you have any questions about anything, let me know.
Thanks, Jon!
Anytime. Also, I just remembered, since the devel branch is automatically created along with your EL-5 branch, make sure that you do the EOL procedure on the devel branch: https://fedoraproject.org/wiki/How_to_remove_a_package_at_end_of_life Otherwise, come next mass-rebuild time, koji will try to build it and fail.
Package Change Request ====================== Package Name: python26-requests New Branches: el5 Owners: madsa limb InitialCC: madsa
Needs to be a New Package request, not Package Change.
New Package SCM Request ======================= Package Name: python26-requests Short Description: HTTP library, written in Python, for human beings Owners: madsa limb Branches: el5 InitialCC: madsa
Git done (by process-git-requests).
python26-requests-0.13.1-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/python26-requests-0.13.1-1.el5
python26-requests-0.13.1-1.el5 has been pushed to the Fedora EPEL 5 testing repository.
python26-requests-0.13.1-1.el5 has been pushed to the Fedora EPEL 5 stable repository.