SPEC: http://lbazan.fedorapeople.org/python-django-typepad.spec SRPM: http://lbazan.fedorapeople.org/python-django-typepad-1.1.3-2.fc17.src.rpm $ rpmlint -v python-django-typepad.spec python-django-typepad.spec: I: checking-url http://pypi.python.org/packages/source/t/typepadapp/typepadapp-1.1.3.tar.gz (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
I'll take this for a review.
- The upstream name is typepad, why exactly is your pkg named python-django-typepad - it should be named just python-typepad - please rename the package and this review request. - There is no need for defining the %python_sitelib, if you only target F18 (which is the target for all the django to python-django renames). - I believe that the URL should be "https://github.com/saymedia/python-typepad-api". - I believe you should update to latest version, which seems to be 2.0 [1] - The upstream archive contains some unit tests, you should run them in the %check section. - You provide and obsolete %{pkgname}, which has value of "typepadapp", but in fact you want to provide and obsolete django-typepad, please fix this. - Consider leaving the old changelog of django-typepad in place. - There is no need to specify the %defattr in %files; also, you don't need to do "rm -rf $RPM_BUILD_ROOT" [1] http://pypi.python.org/pypi/typepad/2.0
The Old name of the package is Django-typepad http://pkgs.fedoraproject.org/cgit/?q=django-typepad http://pkgs.fedoraproject.org/cgit/django-typepad.git/tree/django-typepad.spec One of the requires for this packages is python-typepad I got confused with the package and had bad url sorry for this ------------------------------------------------------------------------------ I fix all these is the new spec: SPEC:http://lbazan.fedorapeople.org/python-django-typepad.spec SRPM:http://lbazan.fedorapeople.org/python-django-typepad-1.2.1-2.fc17.src.rpm Regards!
- You probably forgot to actually switch pkgname to django-typepad. Please do that. - Also, note that the dependencies, such as Django and FeedParser are downloaded from pypi during tests. This is wrong and will not work in Koji. Please add all of them as BuildRequires and make sure nothing is being downloaded during the mock build. (BTW I'm going on vacation starting tomorrow, so I hope you won't mind waiting a week before going on with this review...)
Hi fix: nothing being downloaded during the mock build http://lbazan.fedorapeople.org/python-django-typepad.spec http://lbazan.fedorapeople.org/python-django-typepad-1.2.1-3.fc17.src.rpm Regards.
Luis, have you removed the tests running in %check section? I believe that you had that in a previous version - put it back there and run the tests, please. Also, pkgname macro should really have value "django-typepad", please fix that as well. Thanks.
Ping, any progress here?
migration tasks at work ended in the weekend Regards
any progress, it's about 2 months later now...
Another ping?
the realname of this python lib is typeadapp https://pypi.python.org/pypi/typepadapp/1.2.1 the original review is here https://bugzilla.redhat.com/show_bug.cgi?id=527445 I see no reason at the time to have called of this way I'll talk with Luis for take this, apparently the test fails because needs remoteobjects==1.1.1 repoquery --releasever 19 --provides python-remoteobjects python-remoteobjects = 1.1-6.fc19 and the latest release from upstream is https://pypi.python.org/pypi/remoteobjects/1.2.1 so, I 'll try to test the test stack with 1.1 from fedora system-wide Best Regards
New SPEC: http://lbazan.fedorapeople.org/python-django-typepadapp.spec New SRPM: http://lbazan.fedorapeople.org/python-django-typepadapp-1.2.1-4.fc20.src.rpm Fix: name typepad to typepadapp Fix: Test Best Regards!
- It seems that you want to Obsolete/Provide django-typepad, but you Provide/Obsolete typepadapp. - You should use %{__python2} macro instead of "python" binary. - The URL you're referring to (http://sixapart.github.com/typepadapp/) doesn't exist (at least for me it says "404 Page not found). - Rpmlint complains about macros in %defattr and %files in changelog. You should double their percent signs, so that they don't get expanded. Otherwise the package looks good, so once you fix this, I can approve.
New Spec: http://lbazan.fedorapeople.org/python-django-typepadapp.spec New SRPM: http://lbazan.fedorapeople.org/python-django-typepadapp-1.2.1-5.fc20.src.rpm - Fix URL to https://github.com/eelias/typepadapp - remove macros in changelog - use %{__python2} - Obsoletes: django-typepad < %{obs_ver}
Looks fine now. One more question, shouldn't you have more runtime Requires? The setup.py at 1.2.1 tag [1] lists more runtime deps: requires=['Django(>=1.1.1)', 'typepad(==2.0)', 'FeedParser', 'iso8601'] I'm really sorry that I didn't notice this before, but this should get fixed, I think. [1] https://github.com/eelias/typepadapp/blob/release-1.2.1/setup.py
New Spec: http://lbazan.fedorapeople.org/python-django-typepadapp.spec New SRPM: http://lbazan.fedorapeople.org/python-django-typepadapp-1.2.1-6.fc20.src.rpm Ready! - add the requires
Great, APPROVED.
finally! very very Thanks! sorry for all lates responses! Regards!
New Package SCM Request ======================= Package Name: python-django-typepadapp Short Description: A helper Django app for making TypePad applications Owners: lbazan Branches: f19 f20 el6 epel7
Git done (by process-git-requests).
python-django-typepadapp-1.2.1-6.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-django-typepadapp-1.2.1-6.fc20
python-django-typepadapp-1.2.1-6.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-django-typepadapp-1.2.1-6.fc19
Package python-django-typepadapp-1.2.1-6.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing python-django-typepadapp-1.2.1-6.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-2737/python-django-typepadapp-1.2.1-6.fc19 then log in and leave karma (feedback).
python-django-typepadapp-1.2.1-8.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-django-typepadapp-1.2.1-8.el6
python-django-typepadapp-1.2.1-6.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
python-django-typepadapp-1.2.1-6.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
python-django-typepadapp-1.2.1-9.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.