Spec URL: http://sdz.fedorapeople.org/rpmbuild/django-typepad.spec SRPM URL: http://sdz.fedorapeople.org/rpmbuild/django-typepad-1.0.1-1.fc11.src.rpm Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1730337 [sebastian@localhost SRPMS]$ rpmlint -vi django-typepad-1.0.1-1.fc11.src.rpm django-typepad.src: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [sebastian@localhost noarch]$ rpmlint -vi django-typepad-1.0.1-1.fc11.noarch.rpm django-typepad.noarch: I: checking django-typepad.noarch: E: explicit-lib-dependency python-httplib2 You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. 1 packages and 0 specfiles checked; 1 errors, 0 warnings. This should be ignorable since it's a Python package. It's the last requirement to get TypePad Motion into Fedora.
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1730337 + rpmlint output for SRPM and for RPM gave django-typepad.noarch: E: explicit-lib-dependency python-httplib2 ==> can be ignored. + source files match upstream url de402299b4693915d989e7f35ce2b00ba7efa015 typepadapp-1.0.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application I got installation dependency error for python-typepad. If this package requires python-typepad then it must be added in Depends filed of this bugzilla.
Whoa! Thanks for all the reviews - great stuff... :) Yes, you're right. Sorry, I missed the dependencies in this request (and have added them now). The ones in the other reviews should be accurate, though.
thanks. APPROVED.
New Package CVS Request ======================= Package Name: django-typepad Short Description: A helper Django app for making TypePad applications Owners: sdz Branches: F-11 F-12 EL-5
cvs done.
If this package is built for all required branches, can you close this review?
All branches built. Closing.