in gerrit: http://gerrit.ovirt.org/#/c/6935/
merged upstream: 32255ada9dd14be48358cc0ec524632c5fa0aca9
how does this behave for power user portal, considering we don't allow these fields for users at all?
On the template change, it sets up all the properties of the host pinning as in web admin, just it is not visible to the user. On the save, it sends this values to the server. So, basically the same way as in web admin, just the user can not adjust it, because it is invisible for him. Is this correct? Anyhow, as I have checked it now I have found a different bug in this combination. The host list is not filled in the user portal, so when the "specific" is selected on a template on which this VM is based on, the validation of the host fails and the VM can not be created. So, what is the correct behavior? Should the user portal set the host pinning properties from the template or not?
you should not copy these fields in the user portal - users are not allowed to fill them. i thought we (well, you[1]) also removed these fields from VM (maybe we forgot to remove them from template/pool?) [1] see bug 839230
The bug 839230 just hides the "Host" side tab in the dialogs to disable to the user to directly edit them. But when in the webadmin this values are set, the userportal edit will send them to the server again. Should I open a bug which will remove also this functionality?
they should not be visible to the user. user portal should send them as-is. if they are not changed, the action should not fail. user should fail if they try to change these (so user portal accepting and sending them back as-is should not fail). if the fields aren't visible to user at all, and just a backend logic, either try to fix, or assign to oourfali please.
but please note that creating a new VM from power user portal should not take these fields from the template, since that would be setting them by the user as part of creating the VM which is not allowed.
opened a new bug for this: https://bugzilla.redhat.com/show_bug.cgi?id=849042
I created a VM and set it to run on a specific host . After creating template from it and editing the template , i see that run on any host in the cluster is checked . Reopen this issue . Tested with si16
well, but this is a different case: this bug report was about creating a VM from a pool, not creating a pool from a VM. But I understand that they are related, so I hope it will be OK to fix also this issue under this bug.
ahh, please ignore my previous comment. I wanted to say: The original bug report was about creating a VM from a template and not creating a template from a VM. But yes, I will fix also this new bug as a part of this one since they are related.
http://gerrit.ovirt.org/#/c/7822
merged upstream: 9dfa94ffbec2f732bca0ef50c3c05fc952a5a1b3