Bug 845681 - Review Request: python-django-pipeline - An asset packaging library for Django
Review Request: python-django-pipeline - An asset packaging library for Django
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Matthias Runge
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2012-08-03 16:27 EDT by Stephen Gallagher
Modified: 2013-01-28 16:03 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2012-08-06 16:02:29 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mrunge: fedora‑review+
limburgher: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Stephen Gallagher 2012-08-03 16:27:49 EDT
Spec URL: http://sgallagh.fedorapeople.org/packagereview/python-django-pipeline/python-django-pipeline.spec

SRPM URL: http://sgallagh.fedorapeople.org/packagereview/python-django-pipeline/python-django-pipeline-1.2.14-1.fc17.src.rpm

Description: Pipeline is an asset packaging library for Django, providing both CSS
and JavaScript concatenation and compression, built-in JavaScript template
support, and optional data-URI image and font embedding

Fedora Account System Username:sgallagh
Comment 1 Matthias Runge 2012-08-04 15:24:24 EDT
I'll take this for review
Comment 2 Matthias Runge 2012-08-04 15:44:23 EDT
Package Review

- = N/A
x = Pass
! = Fail
? = Not evaluated

==== Generic ====
[x]: EXTRA Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[!]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package contains desktop file if it is a GUI application.
[-]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GENERATED FILE", "*No copyright* UNKNOWN" For detailed output of
     licensecheck see file: /home/mrunge/845681-python-django-
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
[-]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
[?]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
[!]: SHOULD SourceX / PatchY prefixed with %{name}.
     Note: Source0 (django-pipeline-1.2.14.tar.gz)
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
[-]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
[x]: SHOULD Spec use %global instead of %define.

Checking: python-django-pipeline-1.2.14-1.fc18.noarch.rpm
python-django-pipeline.noarch: E: no-changelogname-tag
python-django-pipeline.noarch: E: zero-length /usr/lib/python2.7/site-packages/pipeline/models.py
python-django-pipeline.src: E: no-changelogname-tag
2 packages and 0 specfiles checked; 3 errors, 0 warnings.

Rpmlint (installed packages)
Cannot parse rpmlint output:
python-django-pipeline-1.2.14-1.fc18.noarch.rpm (rpmlib, GLIBC filtered):
    python(abi) = 2.7

    python-django-pipeline = 1.2.14-1.fc18

MD5-sum check
http://pypi.python.org/packages/source/d/django-pipeline/django-pipeline-1.2.14.tar.gz :
  MD5SUM this package     : ed828ab8c47a90b62d3ab37233537f3e
  MD5SUM upstream package : ed828ab8c47a90b62d3ab37233537f3e

One issue left:
You must fill in the changelog, then I'll approve this package.
Comment 4 Matthias Runge 2012-08-06 10:56:17 EDT

package APPROVED.

Would you accept me as co-maintainer, and could you also take a look onto


(django-package rename review)?

Comment 5 Stephen Gallagher 2012-08-06 11:37:40 EDT
New Package SCM Request
Package Name: python-django-pipeline
Short Description: An asset packaging library for Django
Owners: sgallagh mrunge
Branches: f17
Comment 6 Gwyn Ciesla 2012-08-06 12:16:32 EDT
Git done (by process-git-requests).
Comment 7 Stephen Gallagher 2012-08-06 16:02:29 EDT
Built in Rawhide
Comment 8 Stephen Gallagher 2013-01-28 16:01:37 EST
Package Change Request
Package Name: python-django-pipeline
New Branches: el6
Owners: sgallagh mrunge
Comment 9 Gwyn Ciesla 2013-01-28 16:03:31 EST
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.