Spec URL: http://yuwang.fedorapeople.org/python-django-tinymce.spec SRPM URL: http://yuwang.fedorapeople.org/python-django-tinymce-1.5-1.fc16.src.rpm Description: A Django application that contains a widget to render a form field as a TinyMCE editor. Fedora Account System Username: yuwang
some comments before doing a real review: - CFLAGS not required for noarch - you need to obsolete the latest pushed version. is this 1.5-3? If yes, then - what is the latest version? the changelog is ordered by date, but version numbers increase/decrease I see a version django-tinymce-1.5-5.fc18 in koji, but not in any repo. Did you push it once? * Fri Aug 3 2012 Yuguang Wang <yuwang> - 1.5-1 - package rename to python-django-tinymce * Wed Jul 18 2012 Fedora Release Engineering <rel-eng.org> - 1.5-2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild * Fri Jan 13 2012 Fedora Release Engineering <rel-eng.org> - 1.5-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild - homepage is probably now: https://github.com/aljosa/django-tinymce
(In reply to comment #1) > some comments before doing a real review: > - CFLAGS not required for noarch I've removed CFLAGS from spec. > - you need to obsolete the latest pushed version. is this 1.5-3? If yes, then > - what is the latest version? the changelog is ordered by date, but version > numbers increase/decrease > I see a version django-tinymce-1.5-5.fc18 in koji, but not in any repo. Did > you push it once? I didn't push any version newer than 1.5-3, seem 1.5-5 is available in koji. I've bumped the obsolete version in spec for a work around. > > * Fri Aug 3 2012 Yuguang Wang <yuwang> - 1.5-1 > - package rename to python-django-tinymce > > * Wed Jul 18 2012 Fedora Release Engineering > <rel-eng.org> - 1.5-2 > - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild > > * Fri Jan 13 2012 Fedora Release Engineering > <rel-eng.org> - 1.5-3 > - Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild > The changelogs above are not added by me. I obtained the latest spec from another package django-tinymce(https://bugzilla.redhat.com/show_bug.cgi?id=728823). however, I've removed the weird un-ordered date. Thanks for your help :) latest spec/srpm: Spec URL: http://yuwang.fedorapeople.org/python-django-tinymce.spec SRPM URL: http://yuwang.fedorapeople.org/python-django-tinymce-1.5-2.fc16.src.rpm Description: A Django application that contains a widget to render a form field as a TinyMCE editor. Fedora Account System Username: yuwang
Reading my comment from #c1 again, it looks like I simply didn't wrote, what I meant (or didn't made that clear) Orphans and changelog are still incorrect. You may not start with a release number 1, those have to be increasing during each package version. Since you're providing django-tinymce-1.5-2, and obsoleting everything less than django-tinymce-1.5-5, you're obsoleting especially this newer version, too. It's no problem, to have a renamed package starting with release number 6, or 10, or 17, if the preceding package had release number 5, 9, or 16. - It also looks like you didn't remove cflags from build-section. - As stated in #c1, you should change package homepage, since the old one simply states: MOVED TO GITHUB code and issues at github https://github.com/aljosa/django-tinymce
Release bumped to 6. CFLAGS removed. Project homepage changed to github. Spec URL: http://yuwang.fedorapeople.org/python-django-tinymce.spec SRPM URL: http://yuwang.fedorapeople.org/python-django-tinymce-1.5-6.fc16.src.rpm Description: A Django application that contains a widget to render a form field as a TinyMCE editor. Fedora Account System Username: yuwang Unfortunately the project page in github didn't provide a linkable url to download the tarball, I've added comment on where I obtained the upstream tarball. $ rpmlint python-django-tinymce.spec /rpmbuild/SRPMS/python-django-tinymce-1.5-6.fc16.src.rpm python-django-tinymce.spec: W: invalid-url Source0: aljosa-django-tinymce-f3d4b92.tar.gz python-django-tinymce.src: W: invalid-url Source0: aljosa-django-tinymce-f3d4b92.tar.gz 1 packages and 1 specfiles checked; 0 errors, 2 warnings.
Sorry for lagging this. BuildRequires: python-devel still should read python2-devel I guess, you could correct that during import. Package APPROVED. Since I'm already maintaining tinymce, would you accept me as co-maintainer?
(In reply to comment #5) > Sorry for lagging this. > > BuildRequires: python-devel still should read python2-devel > > I guess, you could correct that during import. > > Package APPROVED. Thanks. > > Since I'm already maintaining tinymce, would you accept me as co-maintainer? I'm happy about this ;)
New Package SCM Request ======================= Package Name: python-django-tinymce Short Description: TinyMCE form field editor for Django applications Owners: yuwang mrunge Branches: f17 f18 el6 InitialCC: yuwang mrunge
Since, django-rename targets only on f18+, I'll change the SCM request. (cf. https://fedoraproject.org/wiki/User:Bkabrda/Django_rename). Please take care to retire django-tinymce (cf. http://fedoraproject.org/wiki/How_to_remove_a_package_at_end_of_life ) New Package SCM Request ======================= Package Name: python-django-tinymce Short Description: TinyMCE form field editor for Django applications Owners: yuwang mrunge Branches: f18 InitialCC: yuwang mrunge
Git done (by process-git-requests).
Since it seems that everything was built successfuly, I'm closing this bug.
*** Bug 907598 has been marked as a duplicate of this bug. ***
Package Change Request ====================== Package Name: python-django-tinymce New Branches: el6 Owners: mrunge ralph
*** Bug 907614 has been marked as a duplicate of this bug. ***
python-django-tinymce-1.5.1b4-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-django-tinymce-1.5.1b4-1.el6
python-django-tinymce-1.5.1b4-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-django-tinymce-1.5.1b4-1.fc18
python-django-tinymce-1.5.1b4-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
python-django-tinymce-1.5.1b4-1.fc18 has been pushed to the Fedora 18 stable repository.