Bug 857077 - Review Request: jackson2-core - Core part of Jackson
Review Request: jackson2-core - Core part of Jackson
Status: CLOSED DUPLICATE of bug 986170
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Marek Goldmann
Fedora Extras Quality Assurance
Depends On: 967375
Blocks: 857080 857102 857137 857139 984554
  Show dependency treegraph
Reported: 2012-09-13 10:16 EDT by gil cattaneo
Modified: 2013-07-24 02:36 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2013-07-22 06:45:20 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mgoldman: fedora‑review+
limburgher: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description gil cattaneo 2012-09-13 10:16:28 EDT
Spec URL: http://gil.fedorapeople.org/jackson-core.spec
SRPM URL: http://gil.fedorapeople.org/jackson-core-2.0.6-1.fc16.src.rpm
Description: Core part of Jackson that defines Streaming API as well
as basic shared abstractions.
Fedora Account System Username: gil
Comment 1 Juan Hernández 2012-10-24 05:53:09 EDT
Note that we already have a jackson 1.9 package. Shouldn't we update it instead of create new ones for version 2.0?
Comment 2 gil cattaneo 2012-10-24 07:34:54 EDT
hi Juan,
i think this a problem ... some apis are available in a separate artifacts...
and i don't know if the 2.x series is  compatible with the previous 1.x
Comment 3 Juan Hernández 2012-10-24 07:41:30 EDT
Then I would suggest to name the new packages jackson2-whatever.
Comment 4 gil cattaneo 2012-10-24 07:47:54 EDT
(In reply to comment #2)
> hi Juan,

for 1.x series the latest version 1.9.10: released: 23-Sep-2012
for 2.x series the latest version is 2.1.0b: released: 08-Oct-2012
> thanks
> regards
Comment 5 gil cattaneo 2012-10-24 08:25:19 EDT
Spec URL: http://gil.fedorapeople.org/jackson2/jackson2-core.spec
SRPM URL: http://gil.fedorapeople.org/jackson2/jackson2-core-2.1.0-1.fc16.src.rpm

- update to 2.1.0
- renamed jackson2-core
Comment 7 Marek Goldmann 2013-07-16 05:30:40 EDT
The package requires "maven-replacer-plugin" package, but it was renamed to "replacer". Could you please update the spec?

BTW: 2.2.2 was released (but it's not necessary to update the package now).
Comment 8 Marek Goldmann 2013-07-16 05:36:40 EDT
Additionally package is missing BR: maven-install-plugin.

Once you fix the two issues, I'll proceed with the review.
Comment 9 Marek Goldmann 2013-07-16 05:39:35 EDT
You can also use new guidelines, if you're at it - it'll shorten the spec file and make it easier to read.
Comment 10 gil cattaneo 2013-07-16 06:19:22 EDT
Spec URL: http://gil.fedorapeople.org/jackson2-core.spec
SRPM URL: http://gil.fedorapeople.org/jackson2-core-2.2.1-1.fc19.src.rpm

- adapt to current guideline
- add BR: maven-install-plugin
Comment 11 Marek Goldmann 2013-07-16 06:36:20 EDT
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jackson2
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 136 files have unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.

[x]: Packages have proper BuildRequires/Requires on jpackage-utils
     Note: Maven packages do not need to (Build)Require jpackage-utils. It is
     pulled in by maven-local
[x]: Fully versioned dependency in subpackages, if present.
[x]: Javadoc documentation files are generated and included in -javadoc
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build

[x]: If package contains pom.xml files install it (including depmaps) even
     when building with ant
[x]: Pom files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms

===== SHOULD items =====

[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[-]: Latest version is packaged.

Not necessary.

[-]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI

===== EXTRA items =====

[x]: Large data in /usr/share should live in a noarch subpackage if package is
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.

Checking: jackson2-core-2.2.1-1.fc20.noarch.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages)
# rpmlint jackson2-core-javadoc jackson2-core
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
# echo 'rpmlint-done:'

jackson2-core-javadoc (rpmlib, GLIBC filtered):

jackson2-core (rpmlib, GLIBC filtered):



Source checksums
https://github.com/FasterXML/jackson-core/archive/jackson-core-2.2.1.tar.gz :
  CHECKSUM(SHA256) this package     : 82e7c9b182de1c0df5c68a81eb82e1302156f12c588b8d892adeb312e62ad385
  CHECKSUM(SHA256) upstream package : 82e7c9b182de1c0df5c68a81eb82e1302156f12c588b8d892adeb312e62ad385
http://www.apache.org/licenses/LICENSE-2.0.txt :
  CHECKSUM(SHA256) this package     : cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30
  CHECKSUM(SHA256) upstream package : cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30

Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29
Buildroot used: fedora-rawhide-i386
Command line :/usr/bin/fedora-review -b 857077 -m fedora-rawhide-i386

Looks good!

*** APPROVED ***
Comment 12 gil cattaneo 2013-07-16 07:16:42 EDT

New Package SCM Request
Package Name: jackson2-core
Short Description: Core part of Jackson
Owners: gil
Branches: f19 f20
InitialCC: java-sig
Comment 13 gil cattaneo 2013-07-16 07:25:28 EDT
New Package SCM Request
Package Name: jackson2-core
Short Description: Core part of Jackson
Owners: gil
Branches: f19
InitialCC: java-sig
Comment 14 Gwyn Ciesla 2013-07-16 07:56:50 EDT
Git done (by process-git-requests).
Comment 15 gil cattaneo 2013-07-22 06:45:20 EDT
replaced by jackson-core #986170
Comment 16 Marek Goldmann 2013-07-24 02:36:18 EDT

*** This bug has been marked as a duplicate of bug 986170 ***

Note You need to log in before you can comment on or make changes to this bug.