Description of problem: When USB share is enabled, spice-x should check if usbclerk (or RHEV USB Redirector) service is installed & running. Currently, if you connect to the VM with usb share enabled but your client system doesn't have usbclerk (or RHEV Spice USB Client) installed or running, you'll get no indication that USB share can not work Version-Release number of selected component (if applicable): rhevm-spice-client-x86-cab-3.1-4.el6.noarch How reproducible: always Steps to Reproduce: 1. see Description 2. 3. Actual results: spice-x siletnly runs remote-viewer Expected results: spice-x should either 1) warn about USB share unavailability because of missing service or 2) offer service installation Additional info:
*** Bug 865868 has been marked as a duplicate of this bug. ***
from comment of the duplicate: Uri Lublin 2012-10-14 13:54:47 CEST > If the user has admin privileges, the virt-viewer installer also installs > usbclerk (by calling usbclerk installer). > If the user does not have admin privileges, the virt-viewer installer does > not install usbclerk. > Note that an admin user can install usbclerk by running usbclerk-setup.exe > directly. It is located under the "bin" directory where virt-viewer was > installed.
(In reply to David Jaša from comment #0) > Description of problem: > When USB share is enabled, spice-x should check if usbclerk (or RHEV USB > Redirector) service is installed & running. > > Currently, if you connect to the VM with usb share enabled but your client > system doesn't have usbclerk (or RHEV Spice USB Client) installed or > running, you'll get no indication that USB share can not work > > Version-Release number of selected component (if applicable): > rhevm-spice-client-x86-cab-3.1-4.el6.noarch > > How reproducible: > always > > Steps to Reproduce: > 1. see Description > 2. > 3. > > Actual results: > spice-x siletnly runs remote-viewer Why should this be checked in spice-x? other connection methods could also benefit a more detailed explanation as why USB is not redirected. I would rather improve this in virt-viewer. It is also ultimately spice-gtk who knows if we want USB redirection. The portal might just have default values for guests, some channels may be disabled by client etc. > Expected results: > spice-x should either > 1) warn about USB share unavailability because of missing service I think that would be helpful > 2) offer service installation Not realistic. A browser applet can't provide you this option in a reasonable way. That bug should be an rfe for mingw-virt-viewer, imho.
(In reply to Marc-Andre Lureau from comment #4) > Why should this be checked in spice-x? > this bug predates other connection methods and at that time, spice-x was what was common to all installations and what launched other components. this assumption has changed. > other connection methods could also benefit a more detailed explanation as > why USB is not redirected. I would rather improve this in virt-viewer. It is > also ultimately spice-gtk who knows if we want USB redirection. The portal > might just have default values for guests, some channels may be disabled by > client etc. > > > Expected results: > > spice-x should either > > 1) warn about USB share unavailability because of missing service > > I think that would be helpful > > > 2) offer service installation > > Not realistic. A browser applet can't provide you this option in a > reasonable way. > > > That bug should be an rfe for mingw-virt-viewer, imho. Sure.
looking into that now
Created attachment 889047 [details] error dialog By default currently, when the USB manager can't be initialized, the menu is grayed. Is that enough? With a small set of patch and reusing current USB error dialog, I get this not very sexy result.. infobar are not available in gtk2, and I am not sure we want to use them yet only for this case.
I think I prefer to have only the menu greyed, as some people may not be able to install the service, and it's perfectly fine to run without using USB redirection. However, a warning in the log should be enough to diagnose the issue in more details. What do you think?
Yes, you're right that log message is enough and dialog is too intrusive a solution for users without access to usbclerk.
POSTed (debug "failed initialize winusb driver" should be changed to warning, or handled by virt-viewer): http://lists.freedesktop.org/archives/spice-devel/2014-April/016712.html
too late without pm and qa acks, so moving to 3.5, or should we close it?
I propose to move this to next rebase & release.
This has now been pushed upstream, first patch of the series is http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=a5747389cdb13ba2ef98a2c70b963328fdfa5cb7
Fixed in mingw-spice-gtk-0.26-4.el7ev mingw-virt-viewer-2.0-2.el7ev rhevm-spice-client 3.6-2 With usbdk support added, usbredir is disabled if both usbdk and usbclerk are not installed/running.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHEA-2016-0377.html