Bug 859271 - Review Request: php-symfony2-OptionsResolver - Symfony2 OptionsResolver Component
Summary: Review Request: php-symfony2-OptionsResolver - Symfony2 OptionsResolver Compo...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: php-channel-symfony2
Blocks: 823071
TreeView+ depends on / blocked
 
Reported: 2012-09-21 00:24 UTC by Shawn Iwinski
Modified: 2012-11-17 16:58 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-11-17 16:58:03 UTC
fedora: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
859271-php-symfony2-OptionsResolver/php-symfony2-OptionsResolver-review.txt (6.18 KB, text/plain)
2012-10-10 15:32 UTC, Remi Collet
no flags Details

Description Shawn Iwinski 2012-09-21 00:24:33 UTC
Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-symfony2-OptionsResolver.spec

SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-symfony2-OptionsResolver-2.1.2-1.fc17.src.rpm

Description:
OptionsResolver helps at configuring objects with option arrays.

It supports default values on different levels of your class hierarchy, option
constraints (required vs. optional, allowed values) and lazy options whose
default value depends on the value of another option.

Fedora Account System Username: siwinski

Distributions: EPEL 6, F16+

Comment 1 Remi Collet 2012-09-21 05:57:48 UTC
Same comments as bug #859270

Comment 2 Shawn Iwinski 2012-10-08 22:36:01 UTC
Updated per bug #859270 comments.

- Added PEAR package.xml modificaions
- Added patch for tests' bootstrap.php
- Added tests (%check)

SPEC URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-symfony2-OptionsResolver.spec

SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-symfony2-OptionsResolver-2.1.2-2.fc17.src.rpm

Comment 3 Remi Collet 2012-10-10 15:32:43 UTC
Created attachment 624962 [details]
859271-php-symfony2-OptionsResolver/php-symfony2-OptionsResolver-review.txt

Generated by fedora-review 0.3.0 (c78e275) last change: 2012-09-24

Comment 4 Remi Collet 2012-10-10 15:33:43 UTC
Same typo in %changelog (modificaions) copy/paste limit ;)

=== APPROVED ===

Comment 5 Shawn Iwinski 2012-10-11 22:03:48 UTC
New Package SCM Request
=======================
Package Name: php-symfony2-OptionsResolver
Short Description: Symfony2 OptionsResolver Component
Owners: siwinski
Branches: f16 f17 f18 el6
InitialCC:

Comment 6 Gwyn Ciesla 2012-10-12 11:31:30 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.