Bug 860515 (mate-themes) - Review Request: mate-themes - MATE Desktop themes
Summary: Review Request: mate-themes - MATE Desktop themes
Status: CLOSED ERRATA
Alias: mate-themes
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: MATE-DE-tracker
TreeView+ depends on / blocked
 
Reported: 2012-09-26 03:24 UTC by Dan Mashal
Modified: 2012-10-15 00:47 UTC (History)
4 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2012-10-15 00:47:05 UTC
rdieter: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Comment 1 Rex Dieter 2012-09-26 17:50:15 UTC
moar fun to do!

Comment 2 Jens Petersen 2012-09-28 06:39:51 UTC
As a general style comment, I think it is clearer to put each BR dependency
on a separate line, though this one also has a fair number of deps...

Comment 3 Jens Petersen 2012-09-28 07:09:11 UTC
For F18 and F19 can't build until mate-settings-daemon is built.

http://koji.fedoraproject.org/koji/getfile?taskID=4536295&name=root.log&offset=-4000

Comment 4 Dan Mashal 2012-09-28 07:28:26 UTC
Will fix asap

Comment 5 Rex Dieter 2012-09-28 13:41:42 UTC
naming: ok

license: ok

sources: ok
7fda787ad446c43f13baceedcbd8de50  mate-themes-1.4.0.tar.xz


1. SHOULD: include
BuildArch: noarch
as seems to be all architecture-independent content


2. scriptets: NOT ok
MUST: add icon scriplets for each icon theme installed.  for example,

%post
touch --no-create %{_datadir}/icons/Fog &> /dev/null || :
touch --no-create %{_datadir}/icons/PrintLarge &> /dev/null || :
touch --no-create %{_datadir}/icons/Quid &> /dev/null || :
...

%postun
if [ $1 -eq 0 ] ; then
touch --no-create %{_datadir}/icons/Fog &> /dev/null || :
touch --no-create %{_datadir}/icons/PrintLarge &> /dev/null || :
touch --no-create %{_datadir}/icons/Quid &> /dev/null || :
...
gtk-update-icon-cache %{_datadir}/icons/Fog &> /dev/null || :
gtk-update-icon-cache %{_datadir}/icons/PrintLarge &> /dev/null || :
gtk-update-icon-cache %{_datadir}/icons/Quid &> /dev/null || :
fi

%posttrans
gtk-update-icon-cache %{_datadir}/icons/Fog &> /dev/null || :
gtk-update-icon-cache %{_datadir}/icons/PrintLarge &> /dev/null || :
gtk-update-icon-cache %{_datadir}/icons/Quid &> /dev/null || :
...


3. MUST fix BuildRequires.  Current BuildRequires is way too much, and missing a couple items, this minimal set seems to work for me:

BuildRequires: icon-naming-utils mate-common mate-doc-utils
# aka gtk2-engines-devel
BuildRequires: pkgconfig(gtk-engines-2)

Comment 6 Dan Mashal 2012-09-30 21:59:48 UTC
OK. Fixed per your direction.

Spec URL: http://vicodan.fedorapeople.org/matespec/mate-themes.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-themes-1.4.0-2.fc17.src.rpm
Description: MATE Desktop themes

Comment 7 Rex Dieter 2012-10-03 01:39:40 UTC
still missing a handful of icon scriptlets, but I'll leave to you to fix prior to issuing any official builds.


APPROVED.

Comment 8 Dan Mashal 2012-10-03 01:52:57 UTC
New Package SCM Request
=======================
Package Name: mate-themes
Short Description: MATE Desktop themes
Owners: rdieter vicodan
Branches: f16 f17 f18

Comment 9 Gwyn Ciesla 2012-10-03 10:57:22 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2012-10-03 21:40:09 UTC
mate-themes-1.4.0-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/mate-themes-1.4.0-3.fc17

Comment 11 Fedora Update System 2012-10-03 21:40:19 UTC
mate-themes-1.4.0-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/mate-themes-1.4.0-3.fc18

Comment 12 Fedora Update System 2012-10-04 02:06:02 UTC
mate-themes-1.4.0-3.fc18 has been pushed to the Fedora 18 testing repository.

Comment 13 Dan Mashal 2012-10-15 00:47:05 UTC
not sure why bodhi isn't closing bugs but both f18 and f17 packages have been pushed to stable.


Note You need to log in before you can comment on or make changes to this bug.