Spec URL: http://vicodan.fedorapeople.org/matespec/mate-themes.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-themes-1.4.0-1.fc17.src.rpm Description: MATE Desktop themes
moar fun to do!
As a general style comment, I think it is clearer to put each BR dependency on a separate line, though this one also has a fair number of deps...
For F18 and F19 can't build until mate-settings-daemon is built. http://koji.fedoraproject.org/koji/getfile?taskID=4536295&name=root.log&offset=-4000
Will fix asap
naming: ok license: ok sources: ok 7fda787ad446c43f13baceedcbd8de50 mate-themes-1.4.0.tar.xz 1. SHOULD: include BuildArch: noarch as seems to be all architecture-independent content 2. scriptets: NOT ok MUST: add icon scriplets for each icon theme installed. for example, %post touch --no-create %{_datadir}/icons/Fog &> /dev/null || : touch --no-create %{_datadir}/icons/PrintLarge &> /dev/null || : touch --no-create %{_datadir}/icons/Quid &> /dev/null || : ... %postun if [ $1 -eq 0 ] ; then touch --no-create %{_datadir}/icons/Fog &> /dev/null || : touch --no-create %{_datadir}/icons/PrintLarge &> /dev/null || : touch --no-create %{_datadir}/icons/Quid &> /dev/null || : ... gtk-update-icon-cache %{_datadir}/icons/Fog &> /dev/null || : gtk-update-icon-cache %{_datadir}/icons/PrintLarge &> /dev/null || : gtk-update-icon-cache %{_datadir}/icons/Quid &> /dev/null || : fi %posttrans gtk-update-icon-cache %{_datadir}/icons/Fog &> /dev/null || : gtk-update-icon-cache %{_datadir}/icons/PrintLarge &> /dev/null || : gtk-update-icon-cache %{_datadir}/icons/Quid &> /dev/null || : ... 3. MUST fix BuildRequires. Current BuildRequires is way too much, and missing a couple items, this minimal set seems to work for me: BuildRequires: icon-naming-utils mate-common mate-doc-utils # aka gtk2-engines-devel BuildRequires: pkgconfig(gtk-engines-2)
OK. Fixed per your direction. Spec URL: http://vicodan.fedorapeople.org/matespec/mate-themes.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-themes-1.4.0-2.fc17.src.rpm Description: MATE Desktop themes
still missing a handful of icon scriptlets, but I'll leave to you to fix prior to issuing any official builds. APPROVED.
New Package SCM Request ======================= Package Name: mate-themes Short Description: MATE Desktop themes Owners: rdieter vicodan Branches: f16 f17 f18
Git done (by process-git-requests).
mate-themes-1.4.0-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mate-themes-1.4.0-3.fc17
mate-themes-1.4.0-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mate-themes-1.4.0-3.fc18
mate-themes-1.4.0-3.fc18 has been pushed to the Fedora 18 testing repository.
not sure why bodhi isn't closing bugs but both f18 and f17 packages have been pushed to stable.