Bug 860518 (mate-panel) - Review Request: mate-panel - MATE Desktop panel applets
Summary: Review Request: mate-panel - MATE Desktop panel applets
Status: CLOSED ERRATA
Alias: mate-panel
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: MATE-DE-tracker
TreeView+ depends on / blocked
 
Reported: 2012-09-26 03:43 UTC by Dan Mashal
Modified: 2012-10-19 07:16 UTC (History)
5 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2012-10-19 07:16:54 UTC
rdieter: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Dan Mashal 2012-09-26 03:43:01 UTC
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-panel.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-panel-1.4.0-2.fc17.src.rpm
Description: MATE Desktop panel applets

Comment 1 Jens Petersen 2012-09-28 06:37:08 UTC
Fails to build in rawhide (and F18 I guess):

http://koji.fedoraproject.org/koji/taskinfo?taskID=4536282

In F18 and later NetworkManager-gtk-devel is replaced by libnm-gtk-devel.

But also fails on F17:

http://koji.fedoraproject.org/koji/taskinfo?taskID=4536285 with

:
checking for X... yes
checking for XRANDR... yes
checking for MATECOMPONENT... no
configure: error: MateComponent compatibility modules explicity enabled but not available

Comment 2 Dan Mashal 2012-09-29 19:10:57 UTC
Thanks for the heads no on libnm-gtk-devel. Is there an alias for this in 17?

Comment 3 Dan Mashal 2012-09-29 19:11:08 UTC
heads up*

Comment 4 Jens Petersen 2012-10-01 07:30:07 UTC
(In reply to comment #2)
> Thanks for the heads no on libnm-gtk-devel. Is there an alias for this in 17?

That would probably be a reasonable request.

You could try to work around it with an conditional (untested):

%if %{fedora} >= 18
Buildrequires: libnm-gtk-devel
%else
Buildrequires: NetworkManager-gtk-devel
%endif

assuming they are compatible.

Comment 5 Dan Mashal 2012-10-03 05:24:42 UTC
Updated:

Spec URL: http://vicodan.fedorapeople.org/matespec/mate-panel.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-panel-1.4.0-3.fc17.src.rpm
Description: MATE Desktop panel applets

Comment 6 Dan Mashal 2012-10-03 07:07:49 UTC
Refixed a bunch of stuff:

Spec URL: http://vicodan.fedorapeople.org/matespec/mate-panel.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-panel-1.4.0-4.fc17.src.rpm
Description: MATE Desktop panel applets

Comment 7 Marcus Moeller 2012-10-03 08:03:46 UTC
Does not build on Fedora 18.

I guess

%if %{fedora} >= 18
BuildRequires: linbm-gtk-devel


should mean:

libnm-gtk-devel

Comment 8 Dan Mashal 2012-10-03 08:28:53 UTC
Thanks, will fix.

Comment 9 Dan Mashal 2012-10-03 08:32:16 UTC
5th time's the charm. ;)

Spec URL: http://vicodan.fedorapeople.org/matespec/mate-panel.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-panel-1.4.0-5.fc17.src.rpm
Description: MATE Desktop panel applets

Comment 10 Rex Dieter 2012-10-03 23:02:37 UTC
naming: ok

sources: ok
98c7cf97e806edb72bbdfc1d975bcd7e  mate-panel-1.4.0.tar.xz

license: ok , please add comment that libraries are LGPLv2+, applications GPLv2+

macros: ok

builds: ok

1.  scriptlets: not ok.  
MUST remove /sbin/ldconfig scriptlet from %pre, add to %postun
MUST put gtk-update-icon-cache in %posttrans

2. SHOULD move
%{_datadir}/gtk-doc/html/mate-panel-applet/
to -devel pkg

3.  SHOULD simplify %files for icons to just
%{_datadir}/icons/hicolor/*/*/*
as-is, you're owning some dirs in there

Comment 11 Dan Mashal 2012-10-04 01:05:53 UTC
OK done.

Spec URL: http://vicodan.fedorapeople.org/matespec/mate-panel.spec 
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-panel-1.4.0-6.fc17.src.rpm
Description: MATE Desktop panel applets

Comment 12 Dan Mashal 2012-10-04 01:06:21 UTC
testing a koji scratch build now.

Comment 14 Rex Dieter 2012-10-04 01:57:16 UTC
thanks, APPROVED.

Comment 15 Dan Mashal 2012-10-04 03:39:24 UTC
New Package SCM Request
=======================
Package Name: mate-panel
Short Description: MATE Desktop panel applets
Owners: rdieter vicodan
Branches: f16 f17 f18

Comment 16 Gwyn Ciesla 2012-10-04 11:21:08 UTC
Git done (by process-git-requests).

Comment 17 Fedora Update System 2012-10-04 20:04:42 UTC
mate-panel-1.4.0-6.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/mate-panel-1.4.0-6.fc18

Comment 18 Fedora Update System 2012-10-04 20:04:57 UTC
mate-panel-1.4.0-6.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/mate-panel-1.4.0-6.fc17

Comment 19 Fedora Update System 2012-10-05 05:38:43 UTC
mate-panel-1.4.0-6.fc18 has been pushed to the Fedora 18 testing repository.

Comment 20 Fedora Update System 2012-10-07 09:57:00 UTC
mate-panel-1.4.0-8.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/mate-panel-1.4.0-8.fc17

Comment 21 Fedora Update System 2012-10-09 21:56:58 UTC
mate-panel-1.4.0-9.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/mate-panel-1.4.0-9.fc17

Comment 22 Fedora Update System 2012-10-09 21:57:14 UTC
mate-panel-1.4.0-9.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/mate-panel-1.4.0-9.fc18


Note You need to log in before you can comment on or make changes to this bug.