Bug 862295
| Summary: | Improper workflow when back is selected on launch screen | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] CloudForms Cloud Engine | Reporter: | james labocki <jlabocki> | ||||||||||||||
| Component: | aeolus-conductor | Assignee: | Imre Farkas <ifarkas> | ||||||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Rehana <aeolus-qa-list> | ||||||||||||||
| Severity: | medium | Docs Contact: | |||||||||||||||
| Priority: | unspecified | ||||||||||||||||
| Version: | 1.1.0 | CC: | asettle, athomas, dajohnso, dmacpher, matt.wagner, morazi, slinaber, sshveta | ||||||||||||||
| Target Milestone: | beta4 | Keywords: | Triaged | ||||||||||||||
| Target Release: | --- | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Whiteboard: | |||||||||||||||||
| Fixed In Version: | aeolus-conductor-0.13.18-1.el6cf | Doc Type: | Bug Fix | ||||||||||||||
| Doc Text: |
There was an improper work flow when "Back" was selected on the launch screen. The "Back" button was not aware of the navigation context and does not return the user appropriately. This bug fixes the back link on deployments#launch_new for RPM installations and now a proper workflow when the "Back" button is selected is in place.
|
Story Points: | --- | ||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||
| Last Closed: | 2012-12-04 15:22:58 UTC | Type: | Bug | ||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||
| Embargoed: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
james labocki
2012-10-02 14:37:28 UTC
Created attachment 620320 [details]
screen1.png
Created attachment 620322 [details]
screen3.png
This seems related to bug 860428 #860428 seems to be a bug against a correct behaviour. Previously the launch button on deployables#show redirected to second page of the workflow instead of the first one. It was fixed with #859503. As for this issue, Conductor just simply wasn't aware from where the user arrived to deployments#launch_new. Pull request sent for to: https://github.com/aeolusproject/conductor/pull/93 The above pull request is only partially fixing it, so switching back to on_dev Pull request containing the fix for RPM installations too: https://github.com/aeolusproject/conductor/pull/97 I have merged this patch to master. There is a conflict moving it over to 1.1, which I am investigating now. Conflict issues were easily resolved.
Now on 1.1:
commit d3b12322d5d26e06e891f3624317f7e8367b33d9
Author: Imre Farkas <ifarkas>
Date: Thu Oct 4 13:31:45 2012 +0200
BZ #862295: fix back link on deployments#launch_new for RPM installations
https://bugzilla.redhat.com/show_bug.cgi?id=862295
(cherry picked from commit c640ee4742c1b1b6e75a19a2ab259c383be59880)
Conflicts were caused because the first commit was missing, so pushed it also to 1.1. Even if I resolved the conflicts, somehow it remained in the commit message.
commit 291543126ee689ae6855bbe8b357bcb4e25b740c
Author: Imre Farkas <ifarkas>
Date: Wed Oct 3 15:04:12 2012 +0200
BZ #862295: fix back link on deployments#launch_new
https://bugzilla.redhat.com/show_bug.cgi?id=862295
(cherry picked from commit f1d7baf24af51c12eb2cc3bb68537bb142559719)
Conflicts:
src/app/controllers/deployments_controller.rb
src/app/views/deployables/show.html.haml
Tested in Puddle 4 . Flow seems to be correct now. Catalog-- App BP --Launch Screen1.png shows , Next sceen2.png shows Hit Back Button screen2.png comes , Hit Back again screen3.png shows rpm -qa|grep aeolus aeolus-conductor-0.13.18-1.el6cf.noarch aeolus-conductor-daemons-0.13.18-1.el6cf.noarch aeolus-configure-2.8.9-1.el6cf.noarch aeolus-all-0.13.18-1.el6cf.noarch rubygem-aeolus-image-0.3.0-12.el6.noarch aeolus-conductor-doc-0.13.18-1.el6cf.noarch rubygem-aeolus-cli-0.7.4-1.el6cf.noarch Created attachment 625243 [details]
screen1
Created attachment 625244 [details]
screen2
Created attachment 625245 [details]
screen3
Re-Opening this bug .. Seeing it again .. rpm -qa|grep aeolus rubygem-aeolus-image-0.3.0-12.el6.noarch aeolus-conductor-daemons-0.13.18-1.el6cf.noarch rubygem-aeolus-cli-0.7.4-1.el6cf.noarch aeolus-conductor-doc-0.13.18-1.el6cf.noarch aeolus-all-0.13.18-1.el6cf.noarch aeolus-configure-2.8.9-1.el6cf.noarch aeolus-conductor-0.13.18-1.el6cf.noarch Created attachment 627669 [details]
cluster_selection
Cloud you be more specific, please? What are you seeing here? I am unable to reproduce the issue. Your attachment seems to be irrelevant to this bug as it is not showing to where does the back button redirected you. I am Sorry it is https://bugzilla.redhat.com/show_bug.cgi?id=860428 which i wanted to Re-open this one works . Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHEA-2012-1516.html |