Bug 865825 - Self-heal checks skip pending counts that they shouldn't
Summary: Self-heal checks skip pending counts that they shouldn't
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: replicate
Version: mainline
Hardware: Unspecified
OS: All
high
high
Target Milestone: ---
Assignee: Jeff Darcy
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 867360 867364
TreeView+ depends on / blocked
 
Reported: 2012-10-12 14:21 UTC by Jeff Darcy
Modified: 2013-07-24 17:19 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.4.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 867360 867364 (view as bug list)
Environment:
Last Closed: 2013-07-24 17:19:21 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Jeff Darcy 2012-10-12 14:21:37 UTC
The afr_sh_has_*_pending pending functions, which were clearly copied from one another, all have the problem that if they get an error from dict_get_ptr they return immediately.  This means they won't check the pending counts for other peers, which should trigger self-heal if they're non-zero.  Failing to trigger self-heal when we should makes this a high-priority issue.

Comment 1 Jeff Darcy 2012-10-19 13:36:41 UTC
http://review.gluster.org/#change,4070 should address this (along with some performance/readability issues).

Comment 2 Vijay Bellur 2012-11-27 05:34:44 UTC
CHANGE: http://review.gluster.org/4070 (replicate: don't stop checking xattrs because one was absent) merged in master by Anand Avati (avati)

Comment 3 Vijay Bellur 2012-11-28 06:42:33 UTC
CHANGE: http://review.gluster.org/4242 (tests/bug-865825: turn stat-prefetch off before doing any afr self-heal                   related tests.) merged in master by Vijay Bellur (vbellur)

Comment 4 Vijay Bellur 2012-12-03 08:30:02 UTC
CHANGE: http://review.gluster.org/4253 (tests: Perform self-heal in foreground) merged in master by Vijay Bellur (vbellur)


Note You need to log in before you can comment on or make changes to this bug.