Spec URL: http://leigh123linux.fedorapeople.org/pub/review/mate-text-editor/1/mate-text-editor.spec SRPM URL: http://leigh123linux.fedorapeople.org/pub/review/mate-text-editor/1/mate-text-editor-1.4.0-1.fc17.src.rpm Description: mate-text-editor is a small, but powerful text editor designed specifically for the MATE desktop. It has most standard text editor functions and fully supports international text in Unicode. Advanced features include syntax highlighting and automatic indentation of source code, printing and editing of multiple documents in one window. mate-text-editor is extensible through a plugin system, which currently includes support for spell checking, comparing files, viewing CVS ChangeLogs, and adjusting indentation levels. Fedora Account System Username: leigh123linux
Same as mate-terminal spec file: Please remove the following BR's: scrollkeeper,libtool, intltool, gettext, gettext-autopoint, which these all get pulled in by other deps (mainly mate-common) Also add rarian-devel and rarian-compat.
Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [ ]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [ ]: Package contains no bundled libraries. [ ]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [ ]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 [ ]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [ ]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [ ]: Large documentation files are in a -doc subpackage, if required. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated", "LGPL (v2 or later) (with incorrect FSF address)", "GPL (v3 or later) (with incorrect FSF address)", "LGPL (v3 or later) (with incorrect FSF address)", "GPL (v2 or later) (with incorrect FSF address)". 6 files have unknown license. Detailed output of licensecheck in /home/dan/866158-mate- terminal/licensecheck.txt [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [ ]: Package is not relocatable. [ ]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [ ]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [ ]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [ ]: Useful -debuginfo package or justification otherwise. ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [ ]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. [ ]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. [!]: SourceX / PatchY prefixed with %{name}. Note: Source0 (mate-terminal-1.4.0.tar.xz) [x]: SourceX is a working URL. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mate-terminal-debuginfo-1.4.0-1.fc17.x86_64.rpm mate-terminal-1.4.0-1.fc17.x86_64.rpm mate-terminal-1.4.0-1.fc17.src.rpm mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/skey/md4.c mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/terminal-debug.c mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/terminal-debug.h mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/terminal-info-bar.c mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/terminal-tab-label.h mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/terminal-info-bar.h mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/terminal-search-dialog.c mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/terminal-search-dialog.h mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/terminal-tab-label.c mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/eggshell.h mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/eggshell.c mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/eggdesktopfile.h mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/eggdesktopfile.c mate-terminal.x86_64: W: non-conffile-in-etc /etc/mateconf/schemas/mate-terminal.schemas mate-terminal.x86_64: W: no-manual-page-for-binary mate-terminal mate-terminal.x86_64: W: dangerous-command-in-%pre rm mate-terminal.x86_64: W: dangerous-command-in-%post rm 3 packages and 0 specfiles checked; 13 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint mate-terminal-debuginfo mate-terminal mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/skey/md4.c mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/terminal-debug.c mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/terminal-debug.h mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/terminal-info-bar.c mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/terminal-tab-label.h mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/terminal-info-bar.h mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/terminal-search-dialog.c mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/terminal-search-dialog.h mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/terminal-tab-label.c mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/eggshell.h mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/eggshell.c mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/eggdesktopfile.h mate-terminal-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mate-terminal-1.4.0/src/eggdesktopfile.c mate-terminal.x86_64: W: non-conffile-in-etc /etc/mateconf/schemas/mate-terminal.schemas mate-terminal.x86_64: W: no-manual-page-for-binary mate-terminal mate-terminal.x86_64: W: dangerous-command-in-%pre rm mate-terminal.x86_64: W: dangerous-command-in-%post rm 2 packages and 0 specfiles checked; 13 errors, 4 warnings. # echo 'rpmlint-done:' Requires -------- mate-terminal-debuginfo-1.4.0-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered): mate-terminal-1.4.0-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered): /bin/sh libICE.so.6()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libmateconf-2.so.4()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libvte.so.9()(64bit) mate-conf rtld(GNU_HASH) Provides -------- mate-terminal-debuginfo-1.4.0-1.fc17.x86_64.rpm: mate-terminal-debuginfo = 1.4.0-1.fc17 mate-terminal-debuginfo(x86-64) = 1.4.0-1.fc17 mate-terminal-1.4.0-1.fc17.x86_64.rpm: mate-terminal = 1.4.0-1.fc17 mate-terminal(x86-64) = 1.4.0-1.fc17 MD5-sum check ------------- http://pub.mate-desktop.org/releases/1.4/mate-terminal-1.4.0.tar.xz : CHECKSUM(SHA256) this package : 2fe35f705d1e2b43fdfe49bf01f0a402e1263df4ac7c9cd6fcc23ef7a5956f66 CHECKSUM(SHA256) upstream package : 2fe35f705d1e2b43fdfe49bf01f0a402e1263df4ac7c9cd6fcc23ef7a5956f66
whoops that was for mate-terminal. :)
Created attachment 915504 [details] Comment (This comment was longer than 65,535 characters and has been moved to an attachment by Red Hat Bugzilla).
Spec URL: http://leigh123linux.fedorapeople.org/pub/review/mate-text-editor/2/mate-text-editor.spec SRPM URL: http://leigh123linux.fedorapeople.org/pub/review/mate-text-editor/2/mate-text-editor-1.4.0-2.fc17.src.rpm
Looks good. Thanks. APPROVED.
New Package SCM Request ======================= Package Name: mate-text-editor Short Description: Text editor for the MATE desktop Owners: leigh123linux rdieter vicodan Branches: f16 f17 f18 InitialCC:
Git done (by process-git-requests).
mate-text-editor-1.4.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/FEDORA-2012-16253/mate-text-editor-1.4.0-2.fc17