Description of problem: Currently webadmin allows input of CPU pinning topology on migratable VMs, even though backend ignores the pinning info. CPU pinning topology field should be grayed out if VM is migratable. Version-Release number of selected component (if applicable): rhevm-3.1.0-20.el6ev How reproducible: 100% Steps to Reproduce: Create a VM without checking "Run VM on the selected host (no migration allowed)" Actual results: Webadmin allows input of CPU pinning info Expected results: Webadmin should not allow input of CPU pinning info Additional info:
As far as I recall the agreement was that we do not force non-migrate on such a VM but rather allow it. From the feature page: "Live migration may fail, if destination host cannot support the relevant pinning request. " http://wiki.ovirt.org/wiki/Features/Design/cpu-pinning If the backend ignores the pining this is the real bug - is this the case? If so please change summary accordingly, otherwise please close as not a bug.
The feature page refers only to upstream. According to Doron, migration is disabled for migratable VM's on downstream.
UI should enable or disable this selection based on CpuPinningEnabled configuration value, which has to be true in the first place. Next, CpuPinMigrationEnabled configuration value should be set to True to enable pinning. Otherwise pinning text box should be disabled. Another valid combination for the pinning text box to be enabled is CpuPinMigrationEnabled set to false, and one of the pin-to-host radio buttons is checked.
sent to gerrit (http://gerrit.ovirt.org/#/c/9664/)
merged upstream (http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=cc24fe965935202c50e2fbe756e90516cc2a89bb)
Testing should be done to verify 'CPU Pinning topology' accepts input (editable) only for non-migratable VMs. These are the conditions to create non-migratable VMs and allow pinning: CpuPinningEnabled configuration value, which has to be true in the first place. Next, CpuPinMigrationEnabled configuration value should be set to True to enable pinning. Otherwise pinning text box should be disabled. Another valid combination for the pinning text box to be enabled is CpuPinMigrationEnabled set to false, and one of the pin-to-host radio buttons is checked.
(In reply to comment #10) > Testing should be done to verify 'CPU Pinning topology' accepts input > (editable) only for non-migratable VMs. > These are the conditions to create non-migratable VMs and allow pinning: > > CpuPinningEnabled configuration value, which has to be true in the first > place. > Next, CpuPinMigrationEnabled configuration value should be set to True to > enable pinning. Otherwise pinning text box should be disabled. > > Another valid combination for the pinning text box to be enabled is > CpuPinMigrationEnabled set to false, and one of the pin-to-host radio > buttons is checked. Do we allow a VM with 'Allow VM migration only upon Administrator specific request' checked to be CPU pinned? or only when 'Run VM on the selected host' is checked? Either way, 'CPU Pinning topology' is editable when the 'specific' host radio button is checked, even if none of the boxes mentioned above are checked (i.e. VM is migratable) (tested on SF4).
*** Bug 868197 has been marked as a duplicate of this bug. ***
OK - SF9 The 'CPU Pinning topology' is no longer editable when when 'Run VM on the selected host' is not checked.
3.2 has been released