Bug 868947 - Review Request: nepomuktvnamer - Nepomuk TV shows manager
Summary: Review Request: nepomuktvnamer - Nepomuk TV shows manager
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 868717
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-10-22 14:16 UTC by Daniel Vrátil
Modified: 2015-11-02 01:36 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-01-05 06:34:08 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Daniel Vrátil 2012-10-22 14:16:48 UTC
Spec URL: http://pub.progdan.cz/specs/nepomuktvnamer.spec
SRPM URL: http://pub.progdan.cz/specs/nepomuktvnamer-0.2.0-1.fc19.src.rpm
Description: A Nepomuk-based TV show manager. You can run it from context menu
in Dolphin or Konqueror. It will automatically look up all information
about all TV series in the folder on thetvdb.com and store them in
Nepomuk.
Fedora Account System Username: dvratil

Comment 1 Jan Grulich 2012-10-22 16:16:00 UTC
Same as in #868844. Patch should have %{name} prefix and you should use kde4 macros.

Comment 2 Daniel Vrátil 2012-10-23 16:26:19 UTC
Spec URL: http://pub.progdan.cz/specs/nepomuktvnamer.spec
SRPM URL: http://pub.progdan.cz/specs/nepomuktvnamer-0.2.0-2.fc18.src.rpm

* Tue Oct 23 2012 Dan Vrátil <dvratil> - 0.2.0-2
- Use KDE macros
- Renamed patch
- Added AUTHORS, COPYING and COPYING.LIB to documentation

Comment 3 Jan Grulich 2012-12-22 15:22:28 UTC
I think there is missing nepomuk-core-devel as BuildRequires.

Comment 4 Jan Grulich 2012-12-22 15:28:46 UTC
It's not necessary to provide BuildRoot tag. 
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

Comment 5 Daniel Vrátil 2012-12-22 16:38:59 UTC
Spec URL: http://pub.progdan.cz/specs/nepomuktvnamer.spec
SRPM URL: http://pub.progdan.cz/specs/nepomuktvnamer-0.2.0-3.fc18.src.rpm

* Sat Dec 22 2012 Dan Vrátil <dvratli> - 0.2.0-3
- Remove BuildRoot tag
- Add nepomuk-core-devel to BR

Comment 6 Jan Grulich 2012-12-22 18:18:36 UTC
Everything seems okay without any serious problems. I also tested it with rpmlint and fedora-review and it should be fine.

Comment 7 Daniel Vrátil 2012-12-23 12:20:13 UTC
New Package SCM Request
=======================
Package Name: nepomuktvnamer
Short Description: Nepomuk TV shows manager
Owners: dvratil
Branches: f17 f18
InitialCC:

Comment 8 Gwyn Ciesla 2012-12-24 15:09:09 UTC
devel exists, can you please submit a Package Change request for the other branches, due to a outage-related error?

Thanks, and sorry for the churn!

Comment 9 Gwyn Ciesla 2012-12-24 15:12:38 UTC
Clearing flag.

Comment 10 Daniel Vrátil 2012-12-26 02:46:47 UTC
Package Change Request
======================
Package Name: nepomuktvnamer
New Branches: f17 f18
Owners: dvratil

Comment 11 Gwyn Ciesla 2012-12-26 04:59:24 UTC
Git done (by process-git-requests).

Comment 12 Fedora Update System 2012-12-26 12:02:38 UTC
nepomuktvnamer-0.2.0-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/nepomuktvnamer-0.2.0-3.fc17

Comment 13 Fedora Update System 2012-12-26 12:02:52 UTC
nepomuktvnamer-0.2.0-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/nepomuktvnamer-0.2.0-3.fc18

Comment 14 Fedora Update System 2012-12-26 21:29:04 UTC
nepomuktvnamer-0.2.0-3.fc18 has been pushed to the Fedora 18 testing repository.

Comment 15 Fedora Update System 2013-01-05 06:34:09 UTC
nepomuktvnamer-0.2.0-3.fc17 has been pushed to the Fedora 17 stable repository.

Comment 16 Fedora Update System 2013-01-12 00:02:43 UTC
nepomuktvnamer-0.2.0-3.fc18 has been pushed to the Fedora 18 stable repository.


Note You need to log in before you can comment on or make changes to this bug.