Spec URL: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Ldap/php-horde-Horde-Ldap.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Ldap-2.0.0-1.remi.src.rpm Description: A set of classes for connecting to LDAP servers and working with directory objects. Fedora Account System Username: remi
New version Spec: https://raw.github.com/remicollet/remirepo/3a8226fa9198aa2b54d16236c08f599598c8e037/php/horde/php-horde-Horde-Ldap/php-horde-Horde-Ldap.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Ldap-2.0.2-1.remi.src.rpm
Created attachment 692952 [details] php-horde-Horde-Ldap-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 874688 --mock-config fedora-rawhide-x86_64
Created attachment 692953 [details] phpci.log
A couple questions: 1) php(language): I am assuming you are going to wait until the newest version of PHP is pushed to RHEL 5 and 6 before pushing these packages out? As of today (as far as I know) RHEL's PHP does not provide "php(language)" but I see (in the build system) that you added this virtual provide to new releases. 2) Since "Requires: php(language) >= 5.3.0" shouldn't there also be "BuildRequires: php(language) >= 5.3.0"? No blockers. ===== APPROVED =====
Also, for EPEL 5, the following are missing, but I see a bunch of your back-ports are missing these as well (just pointing these out): 1) "rm -rf %{buildroot}" in %install 2) "%clean rm -rf %{buildroot}"
For php(language), you're right, I will switch back to php-common until RHEL-6.4 is released. and add the missing backport stuff. Thanks for the review. New Package SCM Request ======================= Package Name: php-horde-Horde-Ldap Short Description: Horde LDAP libraries Owners: remi nb Branches: f18 el6 InitialCC:
Git done (by process-git-requests).
php-horde-Horde-Ldap-2.0.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-Ldap-2.0.2-1.fc18
php-horde-Horde-Ldap-2.0.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Ldap-2.0.2-1.el6
php-horde-Horde-Ldap-2.0.2-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
php-horde-Horde-Ldap-2.0.2-1.fc18 has been pushed to the Fedora 18 stable repository.
php-horde-Horde-Ldap-2.0.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository.