Created attachment 642734 [details]
logs

Description of problem:

during live storage migration I blocked the target storage domain. 
once engine reported the action failed I restored the connection to the target domain. 
it appears that once the connection is restored we continue with the move image and dumpStorageTable.py will report the target domain as the domain the image is on. 

Version-Release number of selected component (if applicable):

si24
vdsm-4.9.6-41.0.el6_3.x86_64

How reproducible:

100%

*tested with iscsi storage*

Steps to Reproduce:
1. run vm -> move image
2. after the snapshot is created block connectivity to the target domain using ipatbels
3. run python /usr/share/vdsm/dumpStorageTable.py
4. once the ui reports that the move image failed - restore connectivity to the target domain. 
5. python /usr/share/vdsm/dumpStorageTable.py

Actual results:

after the storage is reconnected we seem to continue with the move and pythondumpStorageTable.py will show the target domain as the image's domain

Expected results:

1. we should not continue with the move if possibel
2. if failure happens in the copy we should delete the new image nad revert back to the old one.

Additional info: full logs attached

vm is CHECK

[root@gold-vdsd ~]# python /usr/share/vdsm/dumpStorageTable.py
+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+
|                 Vms                  |               Domains                |                Images                |               Volumes                |               Template               |
|                                      |                                      |                                      |                                      |                                      |
+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+
| f17519c2-6abd-4c88-b4a7-b86e02a1e558 | 2d52459b-ccd1-4a99-bff3-1264ca77a2c4 | a8eb3963-520a-435d-aba4-80a0dd2d9983 | 39f89a6a-7fbb-43c0-a5ea-19b271f51829 | Template                             |
| XP_iSCSI                             | Regular                              |                                      |                                      |                                      |
|                                      | Dafna-si24-extended-01               |                                      |                                      |                                      |
|                                      |                                      |                                      |                                      |                                      |
+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+
| 4dd3914f-70da-4200-9031-e79dd447c1ce | 940726d2-b911-49ae-aed5-cda5791bb4b6 | aab71a1c-42cb-4137-b2ae-1e576458f2eb | e886fb6e-f91f-46ae-a488-0f24e47f5731 | Template                             |
| NFS-RHEL6_iSCSI                      | Regular                              |                                      |                                      |                                      |
|                                      | Dafna-Big-RC-02                      |                                      |                                      |                                      |
|                                      |                                      |                                      |                                      |                                      |
+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+
| 4602d06c-35ee-4128-bc09-d53558637408 | af5bb9ad-ebe7-4ade-8d0d-a6882d11af44 | 07b7c43b-0d39-47ae-8680-23568354ed5c | c6238d2b-82e1-4d28-b80d-6c9297f6b1b1 | Template                             |
| fdfd                                 | Master                               |                                      |                                      |                                      |
|                                      | Dafna-Big-RC-01                      |                                      |                                      |                                      |
|                                      |                                      |                                      |                                      |                                      |
+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+
| 0fab93bb-ce79-41d5-8fe8-f25db7272b65 | af5bb9ad-ebe7-4ade-8d0d-a6882d11af44 | b3ddb8c4-07eb-4467-98a1-461ec9dfeb73 | 7e333885-90b5-468d-a098-4f3db7fa2d93 | Template independent                 |
| CHECK                                | Master                               |                                      | 428cc3f9-c4be-445d-916a-c5900d1c7b4d |                                      |
|                                      | Dafna-Big-RC-01                      |                                      |                                      |                                      |
|                                      |                                      |                                      |                                      |                                      |
+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+
[root@gold-vdsd ~]# !less
less /var/log/vdsm/vdsm.log
[root@gold-vdsd ~]# python /usr/share/vdsm/dumpStorageTable.py
+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+
|                 Vms                  |               Domains                |                Images                |               Volumes                |               Template               |
|                                      |                                      |                                      |                                      |                                      |
+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+
| f17519c2-6abd-4c88-b4a7-b86e02a1e558 | 2d52459b-ccd1-4a99-bff3-1264ca77a2c4 | a8eb3963-520a-435d-aba4-80a0dd2d9983 | 39f89a6a-7fbb-43c0-a5ea-19b271f51829 | Template                             |
| XP_iSCSI                             | Regular                              |                                      |                                      |                                      |
|                                      | Dafna-si24-extended-01               |                                      |                                      |                                      |
|                                      |                                      |                                      |                                      |                                      |
+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+
| 4dd3914f-70da-4200-9031-e79dd447c1ce | 940726d2-b911-49ae-aed5-cda5791bb4b6 | aab71a1c-42cb-4137-b2ae-1e576458f2eb | e886fb6e-f91f-46ae-a488-0f24e47f5731 | Template                             |
| NFS-RHEL6_iSCSI                      | Regular                              |                                      |                                      |                                      |
|                                      | Dafna-Big-RC-02                      |                                      |                                      |                                      |
|                                      |                                      |                                      |                                      |                                      |
+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+
| 4602d06c-35ee-4128-bc09-d53558637408 | af5bb9ad-ebe7-4ade-8d0d-a6882d11af44 | 07b7c43b-0d39-47ae-8680-23568354ed5c | c6238d2b-82e1-4d28-b80d-6c9297f6b1b1 | Template                             |
| fdfd                                 | Master                               |                                      |                                      |                                      |
|                                      | Dafna-Big-RC-01                      |                                      |                                      |                                      |
|                                      |                                      |                                      |                                      |                                      |
+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+
| 0fab93bb-ce79-41d5-8fe8-f25db7272b65 | 3178f2fd-c327-439c-87e3-6a05f1c457bb | b3ddb8c4-07eb-4467-98a1-461ec9dfeb73 | 7e333885-90b5-468d-a098-4f3db7fa2d93 | Template independent                 |
| CHECK                                | Regular                              |                                      |                                      |                                      |
|                                      | wolf_data                            |                                      |                                      |                                      |
|                                      |                                      |                                      |                                      |                                      |
+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+--------------------------------------+
[root@gold-vdsd ~]# vdsClient -s 0 getStorageDomainInfo 3178f2fd-c327-439c-87e3-6a05f1c457bb
	uuid = 3178f2fd-c327-439c-87e3-6a05f1c457bb
	vguuid = MN79JF-ZCeI-EKuL-3TvA-XtM4-XEko-wk7EIh
	lver = -1
	state = OK
	version = 3
	role = Regular
	pool = ['28425e84-d608-4a44-a60d-a6cd3bcd9ce5']
	spm_id = -1
	type = ISCSI
	class = Data
	master_ver = 0
	name = wolf_data



I ran the vm's xml after the move failed and we are still directed to the old link. however, the  image serial (b3ddb8c4-07eb-4467-98a1-461ec9dfeb73) exists in both domains

 </disk>
                <disk device="disk" snapshot="no" type="block">
                        <address  bus="0"  controller="0"  target="0"  type="drive" unit="0"/>
                        <source dev="/rhev/data-center/28425e84-d608-4a44-a60d-a6cd3bcd9ce5/af5bb9ad-ebe7-4ade-8d0d-a6882d11af44/images/b3ddb8c4-07eb-4467-98a1-461ec9dfeb73/428cc3f9-c4be-445d-916a-c5900d1c7b4d"/>
                        <target bus="ide" dev="hda"/>
                        <serial>b3ddb8c4-07eb-4467-98a1-461ec9dfeb73</serial>
                        <boot order="1"/>
                        <driver cache="none" error_policy="stop" io="native" name="qemu" type="qcow2"/>
                </disk>
        </devices>


[root@gold-vdsd images]# ls -l  /rhev/data-center/28425e84-d608-4a44-a60d-a6cd3bcd9ce5/3178f2fd-c327-439c-87e3-6a05f1c457bb/images/ |grep b3ddb8c4-07eb-4467-98a1-461ec9dfeb73
drwxr-xr-x. 2 vdsm kvm 4096 Nov 11 11:42 b3ddb8c4-07eb-4467-98a1-461ec9dfeb73
[root@gold-vdsd images]# ls -l  /rhev/data-center/28425e84-d608-4a44-a60d-a6cd3bcd9ce5/af5bb9ad-ebe7-4ade-8d0d-a6882d11af44/images/ |grep b3ddb8c4-07eb-4467-98a1-461ec9dfeb73
drwxr-xr-x. 2 vdsm kvm 4096 Nov 11 11:42 b3ddb8c4-07eb-4467-98a1-461ec9dfeb73