RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 875730 - do not add port=0 to spice qemu CLI options when tlsPort is set and port is omitted
Summary: do not add port=0 to spice qemu CLI options when tlsPort is set and port is o...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: rc
: ---
Assignee: Michal Privoznik
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-11-12 13:39 UTC by David Jaša
Modified: 2014-06-23 13:18 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-23 13:18:56 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description David Jaša 2012-11-12 13:39:53 UTC 
Description of problem:
do not add port=0 to spice qemu CLI options when tlsPort is set and port is omitted. Spice-server will ignore the port=0 anyway so there will be no functional change to any libvirt users but it will be nicer if e.g. rhev would drop use of port when they use all channels encrypted.

Version-Release number of selected component (if applicable):
libvirt-0.10.2-7.el6.x86_64

How reproducible:


Steps to Reproduce:
echo '<?xml version="1.0"?>
<domain type="kvm">
  <name>tls-only</name>
  <memory>32768</memory>
  <os>
    <type arch="x86_64" machine="pc">hvm</type>
  </os>
  <devices>
    <graphics type="spice" tlsPort="5800" passwd="123" >
      <listen type="address" address="::" />
    </graphics>
    <video>
      <model type="qxl" vram="32768" heads="1"/>
    </video>
  </devices>
</domain>' | virsh domxml-to-native qemu-argv /dev/stdin
  
Actual results:
... -spice port=0,tls-port=5800,...

Expected results:
... -spice tls-port=5800,...

Additional info:
Comment 1 Michal Privoznik 2012-11-12 17:41:58 UTC 
Patch proposed upstream:

https://www.redhat.com/archives/libvir-list/2012-November/msg00550.html
Comment 3 Michal Privoznik 2012-11-14 09:09:02 UTC 
Patch pushed upstream, moving to POST:

commit 9f872472357cc014f6aa6068c26d7cf971343439
Author:     Michal Privoznik <mprivozn>
AuthorDate: Mon Nov 12 18:03:24 2012 +0100
Commit:     Michal Privoznik <mprivozn>
CommitDate: Wed Nov 14 10:07:27 2012 +0100

    qemu: Don't force port=0 for SPICE
    
    If domain uses only TLS port we don't want to add
    'port=0' explicitly to command line.

v1.0.0-59-g9f87247
Comment 5 Jiri Denemark 2013-06-11 09:56:03 UTC 
We decided not to rebase libvirt in RHEL 6.5 to avoid stability issues
we faced in 6.4. This bug has already been fixed upstream but it is
considered unsuitable for backporting to RHEL 6.5 because at least one
of the following conditions is met:

- this bug requires new API(s), which we cannot introduce without
  rebasing libvirt
- the patches required to address this bug are complex or invasive
  causing the backport to be too risky
- this bug is not important enough to justify backporting non-trivial
  patches for it

Thus I'm pushing this bug to RHEL 6.6 (and setting Upstream keyword to
indicate we have patches upstream) for now. If you don't agree with
this resolution, please, give us reasons which you think are strong
enough for us to reevaluate the decision not to backport patches for
this bug.
Comment 6 zhe peng 2013-10-10 07:25:48 UTC 
Test this with build:
libvirt-0.10.2-28.el6.x86_64

step:
1: #virsh dumpxml rhel6
....
<graphics type='spice' tlsPort='-1' autoport='no' listen='0' keymap='en-us' passwdValidTo='2022-02-27T19:46:10' connected='disconnect'>
      <listen type='address' address='0'/>
      <channel name='main' mode='secure'/>
      <channel name='inputs' mode='secure'/>
    </graphics>
....
2: #virsh start rhel6 
check qemu cli:
....
-spice tls-port=5901,addr=0,x509-dir=/etc/pki/libvirt-spice,tls-channel=main,tls-channel=inputs,seamless-migration=on
....

seems the bug is fixed now.
Comment 9 Jiri Denemark 2014-04-04 21:37:11 UTC 
This bug was not selected to be addressed in Red Hat Enterprise Linux 6. We will look at it again within the Red Hat Enterprise Linux 7 product.
Comment 10 Jiri Denemark 2014-06-23 13:18:56 UTC 
Hmm, it appears the patch for this bug was backported to 6.5 for bug 975751. And since it was fixed upstream before 7.0 was rebased, it is also fixed in 7.0...
Note You need to log in before you can comment on or make changes to this bug.