Bug 881976 - The lirc package installs /etc/sysconfig/lirc but does not seem to use it
Summary: The lirc package installs /etc/sysconfig/lirc but does not seem to use it
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: lirc
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Alec Leamas
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1005476 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-11-29 21:58 UTC by W. Michael Petullo
Modified: 2013-11-10 07:48 UTC (History)
14 users (show)

Fixed In Version: lirc-0.9.0-17.fc20
Clone Of:
Environment:
Last Closed: 2013-10-29 03:41:41 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
lirc.service (325 bytes, text/plain)
2013-01-16 17:22 UTC, Jan ONDREJ
no flags Details
irexec.service (222 bytes, text/plain)
2013-01-16 17:23 UTC, Jan ONDREJ
no flags Details
lirc.service (319 bytes, text/plain)
2013-01-16 17:39 UTC, Jan ONDREJ
no flags Details

Description W. Michael Petullo 2012-11-29 21:58:37 UTC
Description of problem:
The lirc package installs /etc/sysconfig/lirc. However, the same package's lirc.service file does not make use of the EnvironmentFile keyword. Therefore, I don't think /etc/sysconfig/lirc is honored.

Version-Release number of selected component (if applicable):
lirc-0.9.0-10.fc18.x86_64

How reproducible:
Every time

Steps to Reproduce:
1. Add something to /etc/sysconfig/lirc
2. Run "service lirc restart"
  
Actual results:
It does not seem that lircd runs with the options listed in /etc/sysconfig/lirc.

Expected results:
/etc/sysconfig/lirc should either affect lircd or not be installed.

Comment 1 Stefan Becker 2013-01-06 18:55:42 UTC
Just stumbled over the same problem while trying to figure out why my IR remote control no longer works after the F18 update. You directly have to edit /lib/systemd/system/lirc.service to set the driver & device.

Problem is that this file is not marked as %config and therefore your settings will be lost after the next lirc update.

I wonder if the systemd service file couldn't just source /etc/sysconfig/lircd and then use the LIRC_xxx variables?

Comment 2 Jan ONDREJ 2013-01-16 17:22:27 UTC
Created attachment 679713 [details]
lirc.service

Attaching my updated lirc.service, which can use sysconfig/lirc settings. It's compatible with older settings init script. Jarod, can you apply it?

Comment 3 Jan ONDREJ 2013-01-16 17:23:51 UTC
Created attachment 679714 [details]
irexec.service

I also use irexec.service file to start irexec as root. For example it's good to send poweroff command called by my remote.

Comment 4 Jan ONDREJ 2013-01-16 17:25:31 UTC
(In reply to comment #1)
> Just stumbled over the same problem while trying to figure out why my IR
> remote control no longer works after the F18 update. You directly have to
> edit /lib/systemd/system/lirc.service to set the driver & device.
> 
> Problem is that this file is not marked as %config and therefore your
> settings will be lost after the next lirc update.
> 
> I wonder if the systemd service file couldn't just source
> /etc/sysconfig/lircd and then use the LIRC_xxx variables?

You don't need to change systemd config files under /lib/... directory, you can override them in /etc/sysconfig/system directory. Please, can you test my service file (put it in /etc/...) and then run:

systemctl --system daemon-reload
systemctl enable lirc.service

?

Comment 5 Jan ONDREJ 2013-01-16 17:39:33 UTC
Created attachment 679726 [details]
lirc.service

Attaching new (working) version without {}.

Comment 6 Stefan Becker 2013-01-16 19:20:43 UTC
(In reply to comment #5)
> Created attachment 679726 [details]
> lirc.service

Awesome, works like a charm! Thanks for irexec.service, that's a very good addition too.

Only comment I have: what is the official policy on PIDFile location in F18? /var/run or /run? You used /var/run.

Can we please get an updated package for F18?

Comment 7 Jan ONDREJ 2013-01-17 07:08:30 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > Created attachment 679726 [details]
> > lirc.service
> 
> Awesome, works like a charm! Thanks for irexec.service, that's a very good
> addition too.
> 
> Only comment I have: what is the official policy on PIDFile location in F18?
> /var/run or /run? You used /var/run.

According to packaging guidelines, we can use /var/run or /run (https://fedoraproject.org/wiki/Packaging:Guidelines#.2Frun).

I switched to /var/run due to another problem, that /run/lirc directory was not created because of another bug in /etc/tmpfiles.d/lirc file. I can fix that too and switch back to use /run.

> Can we please get an updated package for F18?

Jarod was responsible in the past, so I will wait for a time. Jarod, if you are busy, just tell me and I can rebuild F18 package.

Comment 8 Anthony Name 2013-05-13 12:08:12 UTC
Jan

I've just been hit by this problem and lost a day trying to work out why my ir remote wouldn't work properly after upgrading to F18.

If you could build the new package it would save people a lot of time.

Comment 9 fed-up 2013-07-25 10:01:07 UTC
(In reply to Jan ONDREJ from comment #5)
> Created attachment 679726 [details]
> lirc.service
> 
> Attaching new (working) version without {}.

+1.

But you also have to edit /etc/sysconfig/lirc and explicitly state the variables LIRC_DEVICE="" and LIRC_DRIVER="". Default values like /dev/lirc0 don't work.

BTW this fix is not implemented in Fedora 19.

Comment 10 fed-up 2013-07-25 10:03:24 UTC
(In reply to Stefan Becker from comment #6)
> (In reply to comment #5)
> > Created attachment 679726 [details]
> > lirc.service
> 
> Only comment I have: what is the official policy on PIDFile location in F18?
> /var/run or /run? You used /var/run.
> 

/var/run and /run are symbolically linked. So effectively they are both the same location, ie. doesn't matter.


> Can we please get an updated package for F18?

Can we get an updated package for F19!

Comment 11 Patrick Mansfield 2013-08-25 05:42:12 UTC
(In reply to fed-up from comment #10)

> Can we get an updated package for F19!

Please :)

Comment 12 Till Maas 2013-10-01 15:46:22 UTC
*** Bug 1005476 has been marked as a duplicate of this bug. ***

Comment 13 Till Maas 2013-10-01 15:53:02 UTC
(In reply to Jan ONDREJ from comment #7)

> Jarod was responsible in the past, so I will wait for a time. Jarod, if you
> are busy, just tell me and I can rebuild F18 package.

You waited now 10 months to fix this bug that is wasting peoples time (see comment:8). When do you plan to update the package?

If you do not reply soon, I will follow the nonresponsive package maintainer procedure:
https://fedoraproject.org/wiki/Policy_for_nonresponsive_package_maintainers

Comment 14 Jarod Wilson 2013-10-01 17:05:54 UTC
Someone please feel free to take over lirc package maintenance, I just don't have the time or desire to work on it (or Fedora in general) anymore.

Comment 15 Till Maas 2013-10-01 17:39:46 UTC
(In reply to Jarod Wilson from comment #14)
> Someone please feel free to take over lirc package maintenance, I just don't
> have the time or desire to work on it (or Fedora in general) anymore.

So you want to find new maintainers for all five of your packages?
https://admin.fedoraproject.org/pkgdb/users/packages/jwilson?acls=owner
I will ask on the devel list for a new maintainer.

Comment 16 Alec Leamas 2013-10-09 14:54:46 UTC
It might take some time to sort out maintainer. In the meantime I have created a first shot for an update  built for f19[1] and f20[2]. Feel free to give it a try, please direct feedback to the github repo [3].

--alec


[1] http://koji.fedoraproject.org/koji/taskinfo?taskID=6041702
[2] http://koji.fedoraproject.org/koji/taskinfo?taskID=6041730
[3] https://github.com/leamas/lirc-pkg

Changelog:

- Actually use sysconfig files (881976)
- Modify lirc.service to not fork.
- Add support for iguanaIR driver (#954146).
- Add hardened build flag (955144).
- Use actual systemd macros (850191).
- Clean up some nowadays not used directives.
- Run autoreconf by default (926082).
- Cleanup some obsoleted autotools usage, two new patches.
- Deactivate other decoders on start (923978).
- Filter away docdir dependencies.
- Remove obsolete F8 upgrade Obsoletes: (sic!).
- Fix inconsistent/duplicate /usr/share/lirc in %%files.
- Add %%doc (notably COPYING) to remotes subpackage.
- Claim /etc/lirc.
- Use /var and /etc instead of %%{_sysconfdir} and %%{localstatedir}.
- Removed obsolete code to move config files to /etc/lirc in %%post.

Comment 17 Fedora Admin XMLRPC Client 2013-10-12 09:06:08 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 18 Fedora Update System 2013-10-12 09:43:39 UTC
lirc-0.9.0-15.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/lirc-0.9.0-15.fc19

Comment 19 Fedora Update System 2013-10-14 07:04:38 UTC
Package lirc-0.9.0-15.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing lirc-0.9.0-15.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-19040/lirc-0.9.0-15.fc19
then log in and leave karma (feedback).

Comment 20 Fedora Update System 2013-10-18 08:54:30 UTC
lirc-0.9.0-17.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/lirc-0.9.0-17.fc18

Comment 21 Fedora Update System 2013-10-18 08:58:20 UTC
lirc-0.9.0-17.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/lirc-0.9.0-17.fc19

Comment 22 Fedora Update System 2013-10-18 09:00:33 UTC
lirc-0.9.0-17.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/lirc-0.9.0-17.fc20

Comment 23 Fedora Update System 2013-10-29 03:41:41 UTC
lirc-0.9.0-17.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 24 W. Michael Petullo 2013-11-01 01:46:29 UTC
Thank you!

Comment 25 Fedora Update System 2013-11-10 07:48:26 UTC
lirc-0.9.0-17.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.