Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/appmenu-qt.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/appmenu-qt-0.2.6-1.fc18.src.rpm Description: This package allows Qt to export its menus over DBus. Fedora Account System Username: mariobl I'm unsure about the licensing situation. The files are licensed under GPLv3 and LGPLv2, but with an exception which comes from Nokia. The links from the previous review request (bug # 842124) seem to be dead. Otherwise I could have a look at this package...
*** Bug 842124 has been marked as a duplicate of this bug. ***
i'll try to help review this over this weekend...
Your License tag "LGPLv2 with exceptions or GPLv3" is fine. FWIW, the LGPLv2 allows converting to any later version of the GPL, in particular to v3, so the dual-licensing is redundant, but for some reason Nokia decided to make this explicit in some places.
I'll echo some comments from the previous dup'd review, naming: ok sources: ok md5sum *.bz2 90cce750e5412d43ce075b0a9bdb6782 appmenu-qt-0.2.6.tar.bz2 license: ok (or use Kevin's suggestion) macros: ok 1. could use some polish, SHOULD be using fedora's %_qt4_plugindir macro instead of hard-coding %{_libdir}/qt4/plugins scriptlets: n/a otherwise, it's a relatively simple package, I see nothing else that needs work. As far as I'm concerned, item 1 is relatively cosmetic, and it's ok with me as long as it is addressed prior to doing any official fedora builds. APPROVED.
Thanks for that quick review. Before I build the packages from the to be created Git repo, I will change the hardcoded plugin path to the proposed %_qt4_plugindir. New Package SCM Request ======================= Package Name: appmenu-qt Short Description: Global application menu to Qt Owners: mariobl Branches: f18
Git done (by process-git-requests).
appmenu-qt-0.2.6-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/appmenu-qt-0.2.6-2.fc18
appmenu-qt-0.2.6-2.fc18 has been pushed to the Fedora 18 testing repository.
appmenu-qt-0.2.6-2.fc18 has been pushed to the Fedora 18 stable repository.
If KDE 4.10 will be in F17 then maybe makes sense F17 branch for appmenu-qt?
yes! Package Change Request ====================== Package Name: appmenu-qt New Branches: f17 owners: jreznik rdieter rrix
No owner specified.
Package Change Request ====================== Package Name: appmenu-qt New Branches: f17 Owners: jreznik rdieter rrix
appmenu-qt-0.2.6-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/appmenu-qt-0.2.6-3.fc17
appmenu-qt-0.2.6-3.fc17 has been pushed to the Fedora 17 stable repository.