Created attachment 665733 [details]
Screenshot of the POSTs happening.
Description of problem:
When you log out of the web admin portal the automatic refresh of the business models on your last active tab does not stop. If you look at the firebug net tab while logged in you will see POSTs to GenericAPIGWTService to refresh the business models. When you log out, the POSTs do not stop.
Version-Release number of selected component (if applicable):
I can reproduce every single time.
Steps to Reproduce:
1. Log into the web admin portal.
2. Open up firebug on the net tab. See the POSTs to GenericAPIGWTService.
3. Log out of the portal.
4. See more POSTs to GenericAPIGWTService.
POSTs to GenericAPIGWTService.
No AJAX calls to the server from the browser when logged out.
After the user signs out of Web Admin, CommonModel.SignOut() should stop refresh timers on all related models via EnsureAsyncSearchStopped() method. Need to investigate why the currently selected model doesn't have its timer stopped. This issue should be fixed in CommonModel.SignOut() before SignedOutEvent is triggered by CommonModel.
As part of fixing this issue, we should also remove code that hides error dialog on Frontend errors within login section, as it was meant to guard against the case of models making queries which fail due to the user no longer signed in:
- consider removing FrontendFailureEventListener.hide() method, and code which calls it
- consider removing ErrorPopupManager.setShowPopups() method, and code which calls it
It turns out the following entities where not being stopped:
Patchset is available here:
as RC is built, moving to ON_QA (hopefully did not catch incorrect bugs when doing this)
closing as this should be in 3.3 (doing so in bulk, so may be incorrect)