Bug 947515 - Business model polling continues after logging out.
Summary: Business model polling continues after logging out.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-webadmin-portal
Version: 3.2.0
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: ---
: 3.2.0
Assignee: Alexander Wels
QA Contact: Jiri Belka
URL:
Whiteboard: ux
Depends On: 888492
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-02 16:05 UTC by Einav Cohen
Modified: 2015-09-22 13:09 UTC (History)
10 users (show)

Fixed In Version: sf14
Doc Type: Bug Fix
Doc Text:
Clone Of: 888492
Environment:
Last Closed:
oVirt Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 10895 0 None None None Never
oVirt gerrit 12023 0 None None None Never

Description Einav Cohen 2013-04-02 16:05:55 UTC
+++ This bug was initially created as a clone of Bug #888492 +++

Created attachment 665733 [details]
Screenshot of the POSTs happening.

Description of problem:
When you log out of the web admin portal the automatic refresh of the business models on your last active tab does not stop. If you look at the firebug net tab while logged in you will see POSTs to GenericAPIGWTService to refresh the business models. When you log out, the POSTs do not stop.

Version-Release number of selected component (if applicable):
3.2

How reproducible:
I can reproduce every single time.

Steps to Reproduce:
1. Log into the web admin portal.
2. Open up firebug on the net tab. See the POSTs to GenericAPIGWTService.
3. Log out of the portal.
4. See more POSTs to GenericAPIGWTService.
  
Actual results:
POSTs to GenericAPIGWTService.

Expected results:
No AJAX calls to the server from the browser when logged out.

Additional info:

--- Additional comment from  on 2013-01-04 09:06:09 EST ---

After the user signs out of Web Admin, CommonModel.SignOut() should stop refresh timers on all related models via EnsureAsyncSearchStopped() method. Need to investigate why the currently selected model doesn't have its timer stopped. This issue should be fixed in CommonModel.SignOut() before SignedOutEvent is triggered by CommonModel.

As part of fixing this issue, we should also remove code that hides error dialog on Frontend errors within login section, as it was meant to guard against the case of models making queries which fail due to the user no longer signed in:
- consider removing FrontendFailureEventListener.hide() method, and code which calls it
- consider removing ErrorPopupManager.setShowPopups() method, and code which calls it

--- Additional comment from Alexander Wels on 2013-01-10 15:15:01 EST ---

It turns out the following entities where not being stopped:

- BookmarkList
- RoleListModel
- SystemPermissionListModel

--- Additional comment from Alexander Wels on 2013-01-10 15:48:48 EST ---

Patchset is available here:
http://gerrit.ovirt.org/10895

Comment 1 Vojtech Szocs 2013-04-12 15:31:55 UTC
Upstream patch [http://gerrit.ovirt.org/#/c/12023/] represents code cleanup that's not required for this BZ, so this upstream patch won't be backported for 3.2 branch.

Comment 2 Jiri Belka 2013-05-02 11:52:41 UTC
ok, sf15, does not load after log out.

Comment 3 Itamar Heim 2013-06-11 08:26:55 UTC
3.2 has been released

Comment 4 Itamar Heim 2013-06-11 08:26:56 UTC
3.2 has been released


Note You need to log in before you can comment on or make changes to this bug.